New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801819 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/webstorage by import https://crrev.com/c/866230

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Jan 13 2018

Issue description

WPT import https://crrev.com/c/866230 introduced new failures in external/wpt/webstorage:

List of new failures:
[ Android Mac10.10 ] virtual/mojo-localstorage/external/wpt/webstorage/storage_enumerate.html [ Crash ]

This import contains upstream changes from f17a824e4d0c5aa49c663c986d093c8ad7732143 to f5bdaf31e4fcc0db6e5739d9fe4f94ee698c6182:
Add test for PerformanceObserver#takeRecords(): https://github.com/w3c/web-platform-tests/commit/f5bdaf31e4fcc0db6e5739d9fe4f94ee698c6182
Improve browsing_context_name_cross_origin* slightly: https://github.com/w3c/web-platform-tests/commit/2e554993dcedadef5de39d92b56ddf5dc7eda6a6

 

Comment 1 by jsb...@chromium.org, Jan 20 2018

Owner: mek@chromium.org
Status: Assigned (was: Untriaged)
mek@ - can you take a look?

Comment 2 by mek@chromium.org, Jan 20 2018

Hmm, sorry, missed this somehow. Considering that that import didn't change that test it shouldn't be a new failure... At least "virtual/mojo-localstorage" is the old no-longer-used non-mojo codepath, so if that's all that is crashing it shouldn't be too terrible...

Unfortunately gerrit doesn't currently let me see the tryjobs from older patch-sets, so I can't actually see how it crashed (but that gerrit bug is supposed to be fixed soon). I'll check back on Monday...
Resurrected try job results using 'git cl try-results --gerrit --i ISSUE -p1'. (The Gerrit bug is really annoying...)

Android crash log: https://storage.googleapis.com/chromium-layout-test-archives/android_blink_rel/5179/layout-test-results/virtual/mojo-localstorage/external/wpt/webstorage/storage_enumerate-crash-log.txt

The Mac "crash" looks like an infra error (purple try job https://ci.chromium.org/buildbot/tryserver.blink/mac10.10_blink_rel/5569). I'll look into why it was considered as a test crash by the rebaseline tool.

mek@ if you think the Android crash is unrelated, you can probably remove the expectation line.

Comment 4 by mek@chromium.org, Jan 20 2018

Ah, thanks. That android crash also looks more or less like an infra failure (at least the test finishes successfully before the crash happened). It's not clear to me from the log what the actual crash is there though, SIGABRT but no assertion failure or anything in the output, and no symbols in the stacktrace.
Labels: Pri-2
Setting defect without priority to Pri-2.
Setting defect without priority to Pri-2.

Sign in to add a comment