Issue metadata
Sign in to add a comment
|
Crash in v8::internal::Simulator::LoadStoreHelper |
|||||||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6622339440836608 Fuzzer: inferno_layout_test_unmodified Job Type: linux_msan_content_shell_drt Platform Id: linux Crash Type: UNKNOWN WRITE Crash Address: 0x7fe7ae322ff8 Crash State: v8::internal::Simulator::LoadStoreHelper v8::internal::Simulator::Run v8::internal::Simulator::CallImpl Sanitizer: memory (MSAN) Recommended Security Severity: High Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=518240:518474 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6622339440836608 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Jan 13 2018
,
Jan 13 2018
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 13 2018
,
Jan 17 2018
hpayer can you triage this and assign an appropriate owner? Thanks.
,
Jan 17 2018
,
Jan 17 2018
Assigning to the current CF sheriff.
,
Jan 18 2018
Cannot reproduce on rodete, because instrumented libraries are missing. Michi, I know that you are quite busy, but can you help out bisecting this on trusty?
,
Jan 18 2018
,
Jan 22 2018
awhalley@ - is this okay to punt to M65?
,
Jan 22 2018
No need to block stable on it, given we've not got a fix. If there's a well baked fix landed soon we could consider for a 64 merge then.
,
Jan 23 2018
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
,
Jan 30 2018
Nothing I can do here without msan support on rodete. Back to the triaging queue.
,
Jan 30 2018
+aarya@ in case Bugs-- has any update on msan support on rodete.
,
Jan 30 2018
This bug should in principle affect all but iOS, right?
,
Jan 30 2018
,
Jan 31 2018
Let's aim for M65 for this. Please merge-request for 64 if its needed and if there is a well baked fix, but per #11, let's target 65 and marking this as non-stable blocker for 64.
,
Feb 1 2018
,
Feb 1 2018
This is a dupe of issue 610214 (which was already marked as verified but not yet fixed). What is happening here is when we are near the stack limit in an optimized function and we call another function with so many arguments that it "overflows" the allocated JS stack buffer before we manage to do a call (which will do a next stack limit check). This is a simulator-only issue because on the real hardware where we use normal stack as a JS stack we will trigger the real stack overflow during attempt to push a next argument on the stack. I think we can remove the security labels and decrease the priority. Assigning to TF team to handle this case if necessary.
,
Feb 1 2018
,
Feb 1 2018
mvstanton: Uh oh! This issue still open and hasn't been updated in the last 19 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers? If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one? If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 2 2018
According to ishell's comment, this is a duplicate of a fixed issue. Closing appropriately.
,
Feb 2 2018
No, the issue is not actually fixed. It does not fail on the test case from issue 610214 anymore but the problem on simulators is still there.
,
Feb 2 2018
Oh sorry. Okay. Fixing this simulator-only issue everywhere would be a lot of work (per discussion with mstarzinger@chromium.org), and only of benefit to the bots. It's also not a security issue. ClusterFuzz occasionally hits this issue, but not at a frequency which stops progress. Therefore, I'll close this issue as WontFix, and we can dupe future arm simulator stack-overflows to this one.
,
Feb 2 2018
I am not sure if this really is a simulator-only bug. In 788071 we came to the conclusion that this can also happen in JS and wasm code, and I uploaded a PoC for wasm. Basically whenever we are near the stack limit and then call a function with many arguments (which end up on the stack) we can run into the red zone without triggering a stack overflow.
,
Feb 2 2018
Very good, reopening, as it appears we need to fix this.
,
Feb 8 2018
,
Feb 13 2018
Any update here? Please note that M65 Stable is nearing. Please take a look asap.
,
Feb 13 2018
This issue exists since a very long time. It's not a release blocker.
,
Feb 13 2018
,
Feb 14 2018
A High is Pri-1, per https://chromium.googlesource.com/chromium/src/+/master/docs/security/severity-guidelines.md. Please note that we have a 60-day guarantee for High bugs.
,
Feb 16 2018
mvstanton: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers? If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one? If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 24
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||
Comment 1 by ClusterFuzz
, Jan 13 2018Labels: Test-Predator-Auto-Components