New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801790 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 788071
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug-Security

Blocked on:
issue 751218
issue 788071
issue 803175



Sign in to add a comment

Crash in v8::internal::Simulator::LoadStoreHelper

Project Member Reported by ClusterFuzz, Jan 13 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6622339440836608

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x7fe7ae322ff8
Crash State:
  v8::internal::Simulator::LoadStoreHelper
  v8::internal::Simulator::Run
  v8::internal::Simulator::CallImpl
  
Sanitizer: memory (MSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=518240:518474

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6622339440836608

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 13 2018

Components: Blink>JavaScript
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 13 2018

Labels: M-64
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 13 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 13 2018

Labels: Pri-1
Cc: u...@chromium.org
Owner: hpayer@chromium.org
hpayer can you triage this and assign an appropriate owner? Thanks.
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 17 2018

Status: Assigned (was: Untriaged)

Comment 7 by hpayer@chromium.org, Jan 17 2018

Cc: hpayer@chromium.org
Owner: clemensh@chromium.org
Assigning to the current CF sheriff.
Blockedon: 803175
Cc: mstarzinger@chromium.org
Labels: Needs-Bisect
Cannot reproduce on rodete, because instrumented libraries are missing.

Michi, I know that you are quite busy, but can you help out bisecting this on trusty?
Blockedon: 751218
Cc: awhalley@chromium.org
awhalley@ - is this okay to punt to M65?
Labels: -ReleaseBlock-Stable M-65
No need to block stable on it, given we've not got a fix. If there's a well baked fix landed soon we could consider for a 64 merge then.
Project Member

Comment 12 by sheriffbot@chromium.org, Jan 23 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Security_Impact-Beta Security_Impact-Stable
Cc: clemensh@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Nothing I can do here without msan support on rodete. Back to the triaging queue.
Cc: aarya@google.com
+aarya@ in case Bugs-- has any update on msan support on rodete.
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Mac OS-Windows
This bug should in principle affect all but iOS, right?
Cc: infe...@chromium.org
Labels: -M-64
Let's aim for M65 for this. Please merge-request for 64 if its needed and if there is a well baked fix, but per #11, let's target 65 and marking this as non-stable blocker for 64. 
Owner: ishell@chromium.org
Status: Started (was: Untriaged)
Cc: ishell@chromium.org
Labels: -Pri-1 Pri-2
Owner: mvstan...@chromium.org
Status: Assigned (was: Started)
This is a dupe of  issue 610214  (which was already marked as verified but not yet fixed).

What is happening here is when we are near the stack limit in an optimized function and we call another function with so many arguments that it "overflows" the allocated JS stack buffer before we manage to do a call (which will do a next stack limit check).

This is a simulator-only issue because on the real hardware where we use normal stack as a JS stack we will trigger the real stack overflow during attempt to push a next argument on the stack.
I think we can remove the security labels and decrease the priority.

Assigning to TF team to handle this case if necessary.
Blockedon: 788071
Aha. So this is basically a dupe of 788071.
Thanks for investigating!
Project Member

Comment 22 by sheriffbot@chromium.org, Feb 1 2018

mvstanton: Uh oh! This issue still open and hasn't been updated in the last 19 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 610214
Status: Duplicate (was: Assigned)
According to ishell's comment, this is a duplicate of a fixed issue. Closing appropriately.
Status: Assigned (was: Duplicate)
No, the issue is not actually fixed. 
It does not fail on the test case from  issue 610214  anymore but the problem on simulators is still there.
Status: WontFix (was: Assigned)
Oh sorry. Okay. Fixing this simulator-only issue everywhere would be a lot of work (per discussion with mstarzinger@chromium.org), and only of benefit to the bots. It's also not a security issue. ClusterFuzz occasionally hits this issue, but not at a frequency which stops progress. 

Therefore, I'll close this issue as WontFix, and we can dupe future arm simulator stack-overflows to this one.
I am not sure if this really is a simulator-only bug.
In 788071 we came to the conclusion that this can also happen in JS and wasm code, and I uploaded a PoC for wasm.
Basically whenever we are near the stack limit and then call a function with many arguments (which end up on the stack) we can run into the red zone without triggering a stack overflow.
Status: Available (was: WontFix)
Very good, reopening, as it appears we need to fix this.
Project Member

Comment 28 by sheriffbot@chromium.org, Feb 8 2018

Status: Assigned (was: Available)
Any update here?  Please note that M65 Stable is nearing.  Please take a look asap.
Labels: -Needs-Bisect -ReleaseBlock-Stable -M-65
This issue exists since a very long time. It's not a release blocker.
Project Member

Comment 31 by sheriffbot@chromium.org, Feb 13 2018

Labels: M-64
A High is Pri-1, per https://chromium.googlesource.com/chromium/src/+/master/docs/security/severity-guidelines.md. Please note that we have a 60-day guarantee for High bugs.
Project Member

Comment 33 by sheriffbot@chromium.org, Feb 16 2018

mvstanton: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: -610214 788071
Status: Duplicate (was: Assigned)
Let's merge this with 788071, and try to find a solution there.
Project Member

Comment 35 by sheriffbot@chromium.org, Jul 24

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment