New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801783 link

Starred by 1 user
Status: Fixed
Owner:
bsalo...@google.com
Closed: Jan 2018
Cc:
cwallez@chromium.org
█ bsalomon@chromium.org
vmi...@chromium.org
kjlubick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ScreenshotSync_GPURasterWithCanvas failing on Nexus 5

Project Member Reported by kbr@chromium.org, Jan 13 2018 
First failing build:
https://ci.chromium.org/buildbot/chromium.gpu.fyi/Android%20Release%20%28Nexus%205%29/8781

  AssertionError: Color mismatch at (10, 0): expected (224, 5, 6), got (226, 21, 22)

I'm not sure whether this could be due to colorspace conversion being applied where it previously wasn't, whether this is an expected change, or whether this is just a bug. However, it's failing reliably on this bot now. It's likely due to this Skia roll:

https://chromium.googlesource.com/chromium/src/+/28efb328ad3407b45341f11b62239d8377a9debc

Best guess is:
2018-01-11 kjlubick Trying gpu scaling on Nexus 5 and 5x

though there are some other suspicious CLs in the regression range. Skia team, could you triage?

Comment 1 by cwallez@chromium.org, Jan 15 2018

Cc: cwallez@chromium.org

Comment 2 by cwallez@chromium.org, Jan 15 2018

Cc: vmi...@chromium.org

Comment 3 by kjlubick@google.com, Jan 16 2018 

My change was an infrastructure only change, so I doubt that is to blame.

Comment 4 by bsalo...@google.com, Jan 16 2018

Owner: bsalo...@google.com
Status: Assigned (was: Untriaged)
This is likely my change to how texture rects are antialiased and the test probably just needs to be rebased.

Comment 5 by kbr@chromium.org, Jan 16 2018 

This test doesn't have any pixel expectations. It repeatedly draws a full-screen solid color and expects to read back the same color that was drawn. Please see:

https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/screenshot_sync_integration_test.py?l=86

https://cs.chromium.org/chromium/src/content/test/data/gpu/screenshot_sync_canvas.html

Could just the edge pixels be slightly wrong? That looks like what's happening.

Comment 6 by senorblanco@chromium.org, Jan 16 2018 

There's also "bsalomon Make GrTextureOp capable of edge antialiasing" in that roll, but I didn't think that would be live yet, only when oop raster is turned on.

Comment 7 by bsalo...@google.com, Jan 16 2018 

Re #5, Yes, that is exactly what is going on. I should have a fix soon.

Comment 8 by bsalo...@google.com, Jan 16 2018 

Actually it's not that simple. The texture draw's paint has AA. On desktop systems it winds up being pixel aligned in device space so there so edge antialiasing has no effect. On Android the view matrix has a scale factor of 1.10204 so we apply aa at the edge. I think the test may be invalid.

Comment 9 by bsalo...@google.com, Jan 16 2018 

Looking a bit more... the device space rectangle is {l=0, t=0, r=282.122, b=282.122}. The pixel that fails is on the top row which should have solid coverage. In actuality the top edge does have a slight aa border.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/4e6cf91b7e6f7908d941275dc56c829143345402

commit 4e6cf91b7e6f7908d941275dc56c829143345402
Author: Brian Salomon <bsalomon@google.com>
Date: Wed Jan 17 14:50:46 2018

Add macro to disable using GrTextureOp for AA in Chrome

Bug:  chromium:802408 
Bug:  chromium:801783 
Change-Id: Id5f097b1df08e21e1385efeb8dd8a5e61305a013
Reviewed-on: https://skia-review.googlesource.com/95564
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

[modify] https://crrev.com/4e6cf91b7e6f7908d941275dc56c829143345402/src/gpu/SkGpuDevice_drawTexture.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3781e6ffa5dd2975f5382807875e16dbf12dae2d

commit 3781e6ffa5dd2975f5382807875e16dbf12dae2d
Author: Brian Salomon <bsalomon@google.com>
Date: Thu Jan 18 04:28:18 2018

[Skia] Disable using GrTextureOp aa until bugs worked out

Bug:  802408 
Bug:  801783 
Change-Id: I20fc0a7b708488f8d85ef9ab85f866c354134dbc
Reviewed-on: https://chromium-review.googlesource.com/871270
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#530053}
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/skia/config/SkUserConfig.h
[add] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-simple-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-sizing-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-tiled-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/paint-subrect-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-simple-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-sizing-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/paint-subrect-expected.png
[modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png
[add] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-canvas-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-image-expected.png
[delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-svg-image-expected.png

Comment 12 by bsalo...@google.com, Jan 18 2018

Status: Fixed (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2141151c498888091b57f8dcbaa2172c07060d49

commit 2141151c498888091b57f8dcbaa2172c07060d49
Author: Brian Salomon <bsalomon@google.com>
Date: Thu Jan 18 16:07:00 2018

Rebaseline for color-profile-image-canvas-svg after disabling GrTextureOp AA

Somehow rebaseline-cl missed this one.

Bug:  801783 
Change-Id: I18b2e3315a9f52fa0169ed9454429abdb9611346
Reviewed-on: https://chromium-review.googlesource.com/873611
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530153}
[modify] https://crrev.com/2141151c498888091b57f8dcbaa2172c07060d49/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b

commit 76a4d4d3c761cea62266bf8d1141b0d8ac84a60b
Author: Brian Salomon <bsalomon@google.com>
Date: Mon Jan 29 18:16:41 2018

Reenable GrTextureOp antialiasing.

Bug:  801783 

Change-Id: I78455d0a50869e7a81b9bfe8613e53bcb5973c80
Reviewed-on: https://chromium-review.googlesource.com/884441
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532494}
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/skia/config/SkUserConfig.h
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[delete] https://crrev.com/937677e60f4b9c525fc5b6d2e79ebb2ef86de213/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/pixelated-canvas-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-simple-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-sizing-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-tiled-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/paint-subrect-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/pixelated-canvas-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-simple-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-sizing-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/paint-subrect-expected.png
[modify] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[delete] https://crrev.com/937677e60f4b9c525fc5b6d2e79ebb2ef86de213/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/pixelated-canvas-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-image-expected.png
[add] https://crrev.com/76a4d4d3c761cea62266bf8d1141b0d8ac84a60b/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-svg-image-expected.png
►

Sign in to add a comment