Missing Images on pages - Skia + Discardable Images texture bindings interaction |
|||||||
Issue descriptionBefore we unlock a discardable texture in CC, we tell Skia to flush pending IO on the texture. However, this doesn't clear any outstanding texture bindings involving this texture which Skia has created. Unfortunately, the act of unlocking in CC does clear these bindings on the GPU service side, leaving Skia's understanding of GL state incorrect. This leads to errors if we quickly re-lock this texture and use it in Skia, as Skia will assume the texture is still bound, won't re-bind it, and we'll hit an error when trying to draw. This leads to missing images on websites. This was discovered via WIP canvas work on the following layout test: fast/canvas/patternfill-repeat.html However analysis of the code shows that this can be hit in the current M64 code today.
,
Jan 15 2018
This bug is very likely to cause users to have missing images during page display, and is a regression. The fix is very targeted / safe, and I'd like to merge to M64.
,
Jan 15 2018
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 16 2018
,
Jan 16 2018
Thanks for the details. Eric - can you please confirm this bug is well tested in canary and extremely safe? This is our last M64 Beta tomorrow, so would like to ensure only critical and absolutely safe merges are in.
,
Jan 16 2018
abdulsyed@, The fix should be extremely safe, and was tested on ToT. I'll spend some time this morning doing additional testing on today's Canary to verify that everything is as expected and will update here. when is the merge cutoff for tomorrow's beta?
,
Jan 16 2018
Thanks! I'm pre-approving this merge for now (branch:3282). Can you please merge after you're done with additional testing/verifications and if things look good? Please merge before 5PM PDT to make it to tomorrow's release.
,
Jan 16 2018
After additional testing, we don't believe this bug hittable with the code that exists in M64 (repro case was a WIP CL on ToT, which was believed to generalize to current code, but turns out to not do so). Removing merge request. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jan 14 2018