New issue
Advanced search Search tips

Issue 801762 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Overlay play button is in the wrong spot when preload=none

Project Member Reported by steimel@chromium.org, Jan 13 2018

Issue description

The overlay play button shown when preload=none is in a different spot. Likely due to assumptions made when the overlay play button was only on Android
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18741e7d3917c9746bad6b8be4c8a6a65d41767a

commit 18741e7d3917c9746bad6b8be4c8a6a65d41767a
Author: Tommy Steimel <steimel@chromium.org>
Date: Fri Jan 19 10:30:00 2018

Hide the timeline differently to avoid moving the overlay play button

This CL changes preload=none video CSS to hide the timeline via
visibility instead of display to avoid messing up the overlay play
button position.

Bug:  801762 
Change-Id: I571932364715a13e358ba9b09710f96e66d17dfe
Reviewed-on: https://chromium-review.googlesource.com/875238
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530474}
[modify] https://crrev.com/18741e7d3917c9746bad6b8be4c8a6a65d41767a/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Started)

Sign in to add a comment