The pre-MD UI had a collection of kiosk mode related tests, see [1]. The new UI does not seem to have any such tests, see [2]. Need to evaluate the previous tests, and most likely migrate them to the MD UI's tests. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js [2] https://cs.chromium.org/search/?q=kiosk+file:%5Esrc/chrome/test/data/webui/extensions/+package:%5Echromium$&type=cs
I think we can probably just say that this will be "Evaluate and port" (rather than "possibly port"). This is probably something we want to do.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/251b6cf4acaa427e190b0967b30b71f1e2c10ba2 commit 251b6cf4acaa427e190b0967b30b71f1e2c10ba2 Author: Scott Chen <scottchen@chromium.org> Date: Fri Jan 19 22:38:10 2018 MD Extensions: add some tests for kiosk mode Bug: 801755 Change-Id: Ia22d9182283ae16abb6f73f602371b914b060a2e Reviewed-on: https://chromium-review.googlesource.com/872200 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530637} [modify] https://crrev.com/251b6cf4acaa427e190b0967b30b71f1e2c10ba2/chrome/test/data/webui/extensions/cr_extensions_browsertest.js [add] https://crrev.com/251b6cf4acaa427e190b0967b30b71f1e2c10ba2/chrome/test/data/webui/extensions/extension_kiosk_mode_test.js [modify] https://crrev.com/251b6cf4acaa427e190b0967b30b71f1e2c10ba2/chrome/test/data/webui/extensions/extension_manager_unit_test.js [modify] https://crrev.com/251b6cf4acaa427e190b0967b30b71f1e2c10ba2/chrome/test/data/webui/extensions/extension_toolbar_test.js [add] https://crrev.com/251b6cf4acaa427e190b0967b30b71f1e2c10ba2/chrome/test/data/webui/extensions/test_kiosk_browser_proxy.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66c184e41439dd2169ae9165aa69af3d217793b2 commit 66c184e41439dd2169ae9165aa69af3d217793b2 Author: Scott Chen <scottchen@chromium.org> Date: Tue Jan 23 00:02:14 2018 MD Extensions: add more kiosk mode tests Follow-up of 872200. Bug: 801755 Change-Id: Ice20453d3b90243885b3aca99ef68ab9868fede2 Reviewed-on: https://chromium-review.googlesource.com/875309 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531068} [modify] https://crrev.com/66c184e41439dd2169ae9165aa69af3d217793b2/chrome/test/data/webui/extensions/cr_extensions_browsertest.js [modify] https://crrev.com/66c184e41439dd2169ae9165aa69af3d217793b2/chrome/test/data/webui/extensions/extension_kiosk_mode_test.js [modify] https://crrev.com/66c184e41439dd2169ae9165aa69af3d217793b2/chrome/test/data/webui/extensions/test_kiosk_browser_proxy.js
ported tests to the new UI
Comment 1 by dpa...@chromium.org
, Jan 13 2018Cc: rdevlin....@chromium.org