New issue
Advanced search Search tips

Issue 801738 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.7% regression in thread_times.key_silk_cases at 528401:528533

Project Member Reported by benhenry@google.com, Jan 13 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 13 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=801738

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=745f9049eb134c5470013ec85b47ec94d196e704fe87ae08acadd50657afe7f4


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 13 2018

Cc: ericrk@chromium.org
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author ericrk@chromium.org ===

Hi ericrk@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Eric Karl
  Commit : 7db283d1d769d05e88b565d5b583980f3d2202aa
  Date   : Wed Jan 10 21:35:18 2018
  Subject: GPU raster tile size calculation should account for DSF rounding

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : thread_times.key_silk_cases
  Metric       : thread_IO_cpu_time_per_frame/silk_finance.html
  Change       : 7.48% | 1.98861956597 -> 2.13738231844

Revision             Result                    N
chromium@528400      1.98862 +- 0.071936       6      good
chromium@528417      1.97136 +- 0.0659436      6      good
chromium@528426      1.9693 +- 0.0627779       6      good
chromium@528430      1.99279 +- 0.0223102      6      good
chromium@528431      2.14602 +- 0.0871701      6      bad       <--
chromium@528432      2.17243 +- 0.0744236      6      bad
chromium@528434      2.15845 +- 0.0378554      6      bad
chromium@528467      2.14776 +- 0.195569       9      bad
chromium@528533      2.13738 +- 0.0860906      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=silk.finance.html thread_times.key_silk_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8957560122935575184


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jan 13 2018

 Issue 801730  has been merged into this issue.

Comment 5 by ericrk@chromium.org, Jan 18 2018

Status: WontFix (was: Assigned)
This change was landed to address other perf regressions of https://chromium.googlesource.com/chromium/src/+/a3e4477c29d087d3708dbcb4dc5a90985c2b45e3

These new "regressions" just bring us back to the same levels we were at before landing https://chromium.googlesource.com/chromium/src/+/a3e4477c29d087d3708dbcb4dc5a90985c2b45e3

Sign in to add a comment