New issue
Advanced search Search tips

Issue 801698 link

Starred by 1 user
Status: Assigned
Owner:
dlkumar@google.com
Cc:
michaelbai@chromium.org
se...@chromium.org
rogerm@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Handle PROBABLY_FORM_SUBMITTED in AutofillManager

Project Member Reported by michaelbai@chromium.org, Jan 12 2018 
Aa to patch https://chromium-review.googlesource.com/c/chromium/src/+/821610, PROBABLY_FORM_SUBMITTED isn't handle in AutofillManager.

PROBABLY_FORM_SUBMITTED is fired when browser navigates to new page, requires to check whether the form exists in new page to know the submission succeeded or not. 

PROBABLY_FORM_SUBMITTED is just a guess, but works well in practice for login cases. We probably need to find the real cases for address and credit card before apply it in AutofillManager.

Comment 1 by rogerm@chromium.org, Aug 7

Owner: dlkumar@google.com
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/192f116fd51a4f62d6614a420260f72a73d6f89a

commit 192f116fd51a4f62d6614a420260f72a73d6f89a
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Sep 28 21:43:00 2018

[autofill] Throttle autofill uploads

This CL adds a pref which is used to track the form signatures
(modulo ~1000) for which uploads have been triggered and for which
events.

The pref is reset every 28 days.

PasswordManager use a different throttling mechanism; they opt out
of this one by passing nullptr for the pref service when they upload.

Bug: 860285,801698
Change-Id: I132408ae9fa48d2af1272913f16f21787dc30839
Reviewed-on: https://chromium-review.googlesource.com/1236413
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595223}
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/autofill_download_manager.h
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/proto/server.proto
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/test_autofill_clock.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/browser/test_autofill_clock.h
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/common/autofill_prefs.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/common/autofill_prefs.h
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/common/password_form.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/common/password_form.h
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/autofill/core/common/submission_source.h
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/password_manager/core/browser/votes_uploader.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/components/password_manager/core/browser/votes_uploader_unittest.cc
[modify] https://crrev.com/192f116fd51a4f62d6614a420260f72a73d6f89a/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment