Add tsmon metric to track how long it takes to audit each audited commit. |
||
Issue descriptionAs Robbie brought up during the brownbag, since the rules are applied serially to each commit, there exists the possibility, however unlikely, that a single commit takes longer to audit than the allotted timeout period for the auditor.
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/907d3fb07aad8d9d4ebc42f77645a32d84fe802c commit 907d3fb07aad8d9d4ebc42f77645a32d84fe802c Author: Roberto Carrillo <robertocn@google.com> Date: Sat Jan 27 01:38:58 2018 [cr-audit-commits] Track how long it takes to audit one commit. Since the rule are serially applied to each commit, we want to track this to reduce the risk that a commit persistently fails to be audited during the allotted timeout. R=stgao,iannucci Bug: 801693 Change-Id: I897f7f17773bb40fd6708810d834ff50ff14671c Reviewed-on: https://chromium-review.googlesource.com/865454 Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/907d3fb07aad8d9d4ebc42f77645a32d84fe802c/go/src/infra/appengine/cr-audit-commits/app/commit_auditor.go [modify] https://crrev.com/907d3fb07aad8d9d4ebc42f77645a32d84fe802c/go/src/infra/appengine/cr-audit-commits/app/model.go
,
Feb 10 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by robert...@chromium.org
, Jan 12 2018