New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801686 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 799516
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Flaky test (timeout): SecurityExploitBrowserTest.InvalidRequestId

Project Member Reported by nyquist@chromium.org, Jan 12 2018

Issue description

The SecurityExploitBrowserTest.InvalidRequestId seems to be quite flaky. After looking at logs, it seems to be timing out every so often.

This log from a linux bot seems relevant:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests__dbg__1_%2F69591%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout
from this build:
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20(dbg)(1)/69591
(it worked on retry)

[0112/072250.345407:ERROR:kill_posix.cc(84)] Unable to terminate process group 14723: No such process (3)
[ RUN      ] SecurityExploitBrowserTest.InvalidRequestId
Xlib:  extension "RANDR" missing on display ":99".
DevTools listening on ws://127.0.0.1:47779/devtools/browser/604e426d-5b2d-4627-8060-7219346e1bd2
Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf
[14819:14819:0112/072206.737395:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x7fdf72387acd base::debug::StackTrace::StackTrace()
#1 0x7fdf72385f0c base::debug::StackTrace::StackTrace()
#2 0x000001dd675e content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7fdf5df35cb0 <unknown>
#4 0x7fdf5dfefc5d __poll
#5 0x7fdf5d276fe4 <unknown>
#6 0x7fdf5d2770ec g_main_context_iteration
#7 0x7fdf724368af base::MessagePumpGlib::Run()
#8 0x7fdf724322c2 base::MessageLoop::Run()
#9 0x7fdf724e3430 base::RunLoop::Run()
#10 0x000001e5e3d7 content::RunThisRunLoop()
#11 0x000001e5fb8b content::MessageLoopRunner::Run()
#12 0x000001ddb5b1 content::RenderProcessHostWatcher::Wait()
#13 0x000001dc2b08 content::RenderProcessHostKillWaiter::Wait()
#14 0x000000e0f584 content::SecurityExploitBrowserTest::TryCreateDuplicateRequestIds()
#15 0x000000e09044 content::SecurityExploitBrowserTest_InvalidRequestId_Test::RunTestOnMainThread()
#16 0x000001dd62ba content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#17 0x0000008e325d _ZN4base8internal13FunctorTraitsIMN7content21CrossSiteTransferTestEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#18 0x0000008e31d4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content21CrossSiteTransferTestEFvvEJPS5_EEEvOT_DpOT0_
#19 0x0000008e3185 _ZN4base8internal7InvokerINS0_9BindStateIMN7content21CrossSiteTransferTestEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#20 0x000000b55cbc _ZN4base8internal7InvokerINS0_9BindStateIMNS_12MockCallbackINS_17RepeatingCallbackIFvvEEEEEFvvEJNS0_17UnretainedWrapperIS7_EEEEES5_E3RunEPNS0_13BindStateBaseE
#21 0x0000008a724d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#22 0x000001fac6d6 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#23 0x7fdf6dd2a1a4 content::BrowserMainLoop::PreMainMessageLoopRun()
#24 0x7fdf6cbea76d _ZN4base8internal13FunctorTraitsIMN7content14NetworkContextEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#25 0x7fdf6cbea6e4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content14NetworkContextEFvvEJPS5_EEEvOT_DpOT0_
#26 0x7fdf6cbea695 _ZN4base8internal7InvokerINS0_9BindStateIMN7content14NetworkContextEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#27 0x7fdf6cc0389c _ZN4base8internal7InvokerINS0_9BindStateIMN7content24ProxyResolverFactoryMojo3JobEFvvEJNS0_17UnretainedWrapperIS5_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#28 0x7fdf6cbb242d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#29 0x7fdf6e98c5bd content::StartupTaskRunner::RunAllTasksNow()
#30 0x7fdf6dd2572b content::BrowserMainLoop::CreateStartupTasks()
#31 0x7fdf6dd33118 content::BrowserMainRunnerImpl::Initialize()
#32 0x000001fab246 ShellBrowserMain()
#33 0x000001f01622 content::ShellMainDelegate::RunProcess()
#34 0x7fdf6f933efd content::RunNamedProcessTypeMain()
#35 0x7fdf6f936ab2 content::ContentMainRunnerImpl::Run()
#36 0x7fdf6f92df5d content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#37 0x7fdf689dba75 service_manager::Main()
#38 0x7fdf6f932da3 content::ContentMain()
#39 0x000001dd5eae content::BrowserTestBase::SetUp()
#40 0x000001dbb6c3 content::ContentBrowserTest::SetUp()
#41 0x00000136b46e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#42 0x000001361372 testing::internal::HandleExceptionsInMethodIfSupported<>()
#43 0x00000134bfe4 testing::Test::Run()
#44 0x00000134c9ad testing::TestInfo::Run()
#45 0x00000134d40c testing::TestCase::Run()
#46 0x00000135909c testing::internal::UnitTestImpl::RunAllTests()
#47 0x00000136b4fe testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#48 0x000001362952 testing::internal::HandleExceptionsInMethodIfSupported<>()
#49 0x000001358cae testing::UnitTest::Run()
#50 0x000001ec7ee1 RUN_ALL_TESTS()
#51 0x000001ec4f22 base::TestSuite::Run()
#52 0x000001dc6a09 content::ContentTestLauncherDelegate::RunTestSuite()
#53 0x000001e4cbef content::LaunchTests()
#54 0x000001dc6942 main
#55 0x7fdf5df20f45 __libc_start_main
#56 0x0000007cf02a _start
[1325/2256] SecurityExploitBrowserTest.InvalidRequestId (TIMED OUT)

I've also attached a screenshot of the flakiness dashboard in case the link stops working or doesn't show helpful information:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=SecurityExploitBrowserTest.InvalidRequestId

It seems to be flaky across all platforms.

In particular this seems to be happening a lot on the Android bot 'KitKat Phone Tester (rel)'. Example build failure:
https://ci.chromium.org/buildbot/chromium.android/KitKat%20Phone%20Tester%20(rel)/2273
 
flakiness-dashboard.png
378 KB View Download
Labels: Pri-2 Type-Bug

Comment 2 by creis@chromium.org, Jan 13 2018

Cc: creis@chromium.org mpear...@chromium.org nasko@chromium.org
Components: Blink>Internals
Owner: mmenke@chromium.org
Status: Assigned (was: Untriaged)
Thanks for filing!  Looks like it's been flaky for a while, including before lukasza@'s r527309.  It's timing out waiting for the renderer process to be killed.

The test was added in r372547, and mmenke, mpearson, and I reviewed it.  It's trying to do some URL loading which is meant to trigger a kill in ResourceDispatcherHostImpl::BeginRequest.

mmenke@: Do you think you could take a look to see if there's any steps in there which look flaky to you?  I suppose we could disable it for the flakiness, but we may never get back to it if we do.  :)

Tossing logs in might be one option.

Comment 3 by mmenke@chromium.org, Jan 13 2018

It's unlikely I'll get to it, given the number of things in my queue.  I'd tend to say that if we've lived with it failing this long, we can just not worry about it until the network service ships (At which point, this code will be gone, anyways).

Comment 4 by kbr@chromium.org, Jan 13 2018

Mergedinto: 799516
Status: Duplicate (was: Assigned)
I'm going to take the liberty of merging this into a bug filed about this same test last week. Will generalize the affected OSs on the other bug.

Sign in to add a comment