New issue
Advanced search Search tips

Issue 801679 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 863524
issue 863072



Sign in to add a comment

Swarming: do not register BotInfo in /handshake, only in /poll

Project Member Reported by vadimsh@chromium.org, Jan 12 2018

Issue description

Bots don't have custom bot config before they call /handshake, and thus they use only default bot config to configure dimensions, which often produces "wrong" results.

This is seen most clearly in Android bots. They report themselves as Ubuntu-16.04 right after restart: https://screenshot.googleplex.com/15thCB3COhH.png 

Since they initialize their android guts after the handshake, these wrong dimensions stay for quite a while (~1 min). Eventually the poll with correct dimensions.

This doesn't affect task reaping, since /poll always happens with correct dimensions, but it still has negative effects for anything that queries bots per dimensions (monitoring counters, botmap updater script, "N bots can run this task"). It also spoils BotTaskDimensions cache each time bots restart.

(You can see how botmap updater script detects this flapping between Ubuntu and Android e.g here https://chrome-internal.googlesource.com/infradata/hosts/+/70908d98e44107852b37c0a03fa1a849dcea54e3. In fact most of the changes to hostmap is this flapping).

I propose we do not write entites relatated to bot dimensions in /handshake and do it only in /poll.
 

Comment 1 by mar...@chromium.org, Jan 12 2018

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Yes this should have been done from the start.

Comment 2 by mar...@chromium.org, Jan 12 2018

Related: issue 786735 and issue 786734.
Yeah, but they require substantially more work...

Comment 4 by mar...@chromium.org, Jan 12 2018

Oh definitely, they are related, not blockers!
Summary: Swarming: do not register BotInfo in /handshake, only in /poll (was: Swarming bots report "wrong" dimension in /handshake)
Blocking: 863524
Blocking: 863072
Owner: mar...@chromium.org
Status: Assigned (was: Available)
This is really causing a fair amount of problems, this needs to be fixed.

Sign in to add a comment