New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801670 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Port LogForward() to NewRESTClient

Project Member Reported by robert...@chromium.org, Jan 12 2018

Issue description

Since the old gitiles.Client{} is deprecated and cr-audit-commits needs to move to the newer gitiles.NewRESTClient, we first need to make sure that the new client exposes the functionality that audit app needs.
 

Comment 1 by no...@chromium.org, Jan 12 2018

i've discussed this tandrii several times and we've concluded the LogForward() implementation matched Log(), i.e. you can get the same results by calling Log that pages through results:

  // old code
  commits, err := client.LogForward(c, "https://gitiles.example.com/repo", "deadbeef", "beefdead")

  // new code:
  req := LogRequest {
    Host: "gitiles.example.com",
    Project: "repo",
    Ancestor: "deadbeef",
    Treeish: "beefdead",
  }
  commits, err := PagingLog(c, client, req, 100)
  reverse(commits)

Roberto, could you confirm this meets your needs? If so, we can mark this as WontFix.
Status: WontFix (was: Untriaged)
I believe it does, thank you for checking.

Sign in to add a comment