New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801668 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

net/tools/get_server_time crashes

Reported by kcunning...@connectify.me, Jan 12 2018 
Chrome Version: master
OS: Ubuntu 16.04
Crash ID: 

URL (if applicable) where crash occurred:

Can you reproduce this crash? Yes

What steps will reproduce this crash (or if it's not reproducible,
what were you doing just before the crash)?
(1) Run net/tools/get_server_time

#0  0x00000000005db50d in base::CreateTaskRunnerWithTraits(base::TaskTraits const&) ()
#1  0x000000000047f500 in net::HostResolverImpl::HostResolverImpl(net::HostResolver::Options const&, net::NetLog*) ()
#2  0x000000000047e176 in net::HostResolver::CreateDefaultResolver(net::NetLog*) ()
#3  0x00000000005813d6 in net::URLRequestContextBuilder::Build() ()
#4  0x0000000000379455 in main ()

Crashes when attempting to create a TaskRunner. The program does not create a TaskScheduler at the start of the process.

*Please note that issues filed with no information filled in above
will be marked as WontFix*

Comment 1 by rdsmith@chromium.org, Jan 15 2018

Components: Internals>Network
Status: Available (was: Unconfirmed)
Confirmed @ p529176 on main trunk.  I used the invocation 

out/Default/get_server_time  --url=http://www.google.com

Having said that, I'm not sure how high a priority this is--this looks like a tool for developers working on Chrome, and the fact that it hasn't been reported before this argues to me that there aren't many developers using it :-}.  

@kcunnigham: Were you just playing around, or do you have a need for this to actually work?

Comment 2 by rdsmith@chromium.org, Jan 15 2018

Labels: -Restrict-View-EditIssue
Removing Restrict-View as I don't believe this can be a security vulnerability since it's not in actual Chromium code.

Comment 3 by kcunning...@connectify.me, Jan 15 2018 

Definitely not a high priority. I was just playing around with some of the code and wanted to notify the developers.

Comment 4 by rdsmith@chromium.org, Jan 15 2018 

Thanks!  Much appreciated.

Comment 5 by mmenke@chromium.org, Jan 16 2018 

Probably best to just remove the utility, as no one working on Chromium seems to have noticed this, indicating it's not being used.

Comment 6 by mmenke@chromium.org, Feb 28 2018

Owner: xunji...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcf110364bc61d5a39a3b54ca94be1d0da89702

commit cbcf110364bc61d5a39a3b54ca94be1d0da89702
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Mar 01 20:00:14 2018

Remove net/tools/get_server_time

This CL removes net/tools/get_server_time now that
//components/network_time_tracker is using a different mechanism
(x-cup-server-proof). This utility is no longer
relevant.

Bug:  801668 
Change-Id: I0bc75a9d21244a0c3bbe0ed50da2783e7169c61c
Reviewed-on: https://chromium-review.googlesource.com/943343
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540263}
[modify] https://crrev.com/cbcf110364bc61d5a39a3b54ca94be1d0da89702/BUILD.gn
[modify] https://crrev.com/cbcf110364bc61d5a39a3b54ca94be1d0da89702/net/BUILD.gn
[delete] https://crrev.com/38404656272b58169bb7c3e230fcc6ef38af6018/net/tools/get_server_time/get_server_time.cc
[modify] https://crrev.com/cbcf110364bc61d5a39a3b54ca94be1d0da89702/tools/determinism/deterministic_build_whitelist.pyl

Comment 8 by xunji...@chromium.org, Mar 1 2018

Status: Fixed (was: Assigned)
If you'd like to get it working, you can apply the changes in PatchSet #2: https://chromium-review.googlesource.com/c/chromium/src/+/943343/2/net/tools/get_server_time/get_server_time.cc 

We decided to remove it because this "get server time" mechanism is not used by anything in Chromium.
►

Sign in to add a comment