system_health.memory_desktop flaky failures on chromium.perf Win 10 Perf |
||
Issue descriptionsystem_health.memory_desktop seems to be more consistently failing as of build 1921 Link to builder: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%2010%20Perf/builds/1921 Stories don't seem to be consistently failing so not a candidate for disabling.
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/785486272fdd040ffc53214deaa8d30a293df6f2 commit 785486272fdd040ffc53214deaa8d30a293df6f2 Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Mon Jan 15 12:37:43 2018 [Telemetry] Fix bug when reading devtools port in desktop The previous code had a bug which forgot to initialize `lines` in the case where the devtools file is already present but with a size in bytes of zero. There was a small chance for this to happen, but it did often happen and raised a UnboundLocalError due to the variable not being defined. TBR=nednguyen@google.com Bug: chromium:801667 Change-Id: I5e0d8786946cdc8ff69b67cb1287b91f56aab475 Reviewed-on: https://chromium-review.googlesource.com/866735 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/785486272fdd040ffc53214deaa8d30a293df6f2/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
,
Jan 15 2018
This should be fixed when that CL rolls into the bots. |
||
►
Sign in to add a comment |
||
Comment 1 by perezju@chromium.org
, Jan 15 2018Ohh, the call stack is: _FindDevToolsPortAndTarget at c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\backends\chrome\desktop_browser_backend.py:244 if not lines: UnboundLocalError: local variable 'lines' referenced before assignment Sounds like an error I introduced recently during my refactor. Sorry about that, and thanks for catching Emily!