New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801666 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 795119



Sign in to add a comment

clean up old drag-to-move/resize code in exo

Project Member Reported by osh...@chromium.org, Jan 12 2018

Issue description

Clean up old code to drag to remove/resize code once 795119 is done.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52838b3466f0623b1ab288cdc5de2860d1684950

commit 52838b3466f0623b1ab288cdc5de2860d1684950
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Jun 28 04:59:24 2018

Use ash resizer instead of its own.

This also fixes touch to drag/resize.

* Use ash's resizer and removed unecessary code.
* added event location for gesture_target in WmToplevelWindowEventHandler.
  This is necessary to enable touch drag/resize.
* mark remote_shell_move as deprecated.

BUG= 801666 
TEST=updated unit test. tested manually with gtk3-demo.

Change-Id: I86b785937335bfe31392f42e7d590410576d73ee
Reviewed-on: https://chromium-review.googlesource.com/1112932
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571030}
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/ash/wm/toplevel_window_event_handler.h
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/ash/wm/wm_toplevel_window_event_handler.cc
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/ash/wm/wm_toplevel_window_event_handler.h
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/components/exo/client_controlled_shell_surface.h
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/components/exo/shell_surface.cc
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/components/exo/shell_surface.h
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/components/exo/shell_surface_base.cc
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/components/exo/shell_surface_base.h
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/components/exo/wayland/server.cc
[modify] https://crrev.com/52838b3466f0623b1ab288cdc5de2860d1684950/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Comment 2 by osh...@chromium.org, Jun 28 2018

Status: Fixed (was: Assigned)

Sign in to add a comment