New issue
Advanced search Search tips

Issue 801659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4%-77.4% regression in smoothness.tough_path_rendering_cases at 528042:528197

Project Member Reported by benhenry@google.com, Jan 12 2018

Issue description

Looks like it could be a revert of an improvement paired with a regression? The regression is 2x the improvement from a recent past.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 12 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=801659

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=dcdaf99df9a3b20070ced1b3d74a665889a960616ba24b5b49f697524311e622


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
win-high-dpi
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 12 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14de130f040000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 13 2018

Cc: zmo@chromium.org geoffl...@chromium.org
Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14de130f040000

Initialize the gpu_rasterization capability for the passthrough cmd decoder.
By geofflang@chromium.org ยท Tue Jan 09 23:36:32 2018
chromium @ 471d8d86874d2666ef7aa1ae563ba64aff15b6fb

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Components: Internals>GPU>Metrics
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54605398cbde33a08290af8a7457590602dfb0b4

commit 54605398cbde33a08290af8a7457590602dfb0b4
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Apr 23 19:37:59 2018

Implement the msaa_is_slow and avoid_stencil_buffers gpu capabilities.

These capabitilites were not implemented in the passthrough command decoder
which resulted in poor MSAA performace on Intel high DPI.

BUG= 801659 
BUG= 800133 
BUG= 800011 
BUG= 799951 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2e1f0f3b4b8267421646279b6d3154223f8199b0
Reviewed-on: https://chromium-review.googlesource.com/1024282
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552794}
[modify] https://crrev.com/54605398cbde33a08290af8a7457590602dfb0b4/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Status: Fixed (was: Assigned)

Sign in to add a comment