New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801639 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Deep Link splash screen disappears quickly

Project Member Reported by dbbrooks@chromium.org, Jan 12 2018

Issue description

Chrome Version:	65.0.3316.0
VrCore:	1.12.177372015	
Device: any Daydream supported device. E.g. Pixel
OS: Android N, O

Most of the time the "Running in Chrome" splash screen disappears in a jarring way. It appears then disappears very rapidly. But sometimes it lasts longer.

What steps will reproduce the problem?
(1) Create a Deep link in Daydream to https://webvr.info/samples/03-vr-presentation.html
(2) Enter VR in Daydream app and select the Deep Link
(3) Observe the "Running in Chrome" splash screen.

What is the expected result? The splash screen is shown for a standard amount of time.

What happens instead? The splash screen sometimes disappears immediately after it appears. It feels jarring.

 
Owner: bajones@chromium.org
Status: Assigned (was: Untriaged)
Components: -Internals>VR UI>Browser>VR
Labels: M-65 Pri-2 Type-Bug
Owner: ymalik@chromium.org
I just noticed the splash screen go by so fast the "Running in Chrome" message didn't even appear. Or it was delayed. I just saw a black screen before the presentation started. Chrome 65.0.3322.0.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1

commit 7fc0c9593c072895c1c01d63c890d5af4d6d2cb1
Author: Yash Malik <ymalik@google.com>
Date: Tue Jan 23 18:01:32 2018

VR: Show splash screen for a minimum duration

Before this CL, we would hide the splash screen as soon as we got the first
frame WebVR frame. Although TransientElement had a notion of "minimum duration",
it didn't really work because we stop drawing non-overalay 2D elements in
WebVR mode.

This CL fixes this by pausing WebVR VSyncs until the minimum duration for the
splash screen is passed.

Bug:  801639 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If2580a97e714a17de5445fba85ab0aa6b487964b
Reviewed-on: https://chromium-review.googlesource.com/879268
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531275}
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/elements/transient_element.cc
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/elements/transient_element.h
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/elements/transient_element_unittest.cc
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/model/web_vr_model.h
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/ui.cc
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/ui.h
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/7fc0c9593c072895c1c01d63c890d5af4d6d2cb1/chrome/browser/vr/ui_unittest.cc

Comment 5 by ymalik@chromium.org, Jan 24 2018

Labels: Merge-Request-65
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
verified this fix in 66.0.3331.0
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 26 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd

commit b46fa9c1be579ee49f88071b15ed7bc00f5b85cd
Author: Yash Malik <ymalik@google.com>
Date: Fri Jan 26 00:54:08 2018

VR: Show splash screen for a minimum duration

Before this CL, we would hide the splash screen as soon as we got the first
frame WebVR frame. Although TransientElement had a notion of "minimum duration",
it didn't really work because we stop drawing non-overalay 2D elements in
WebVR mode.

This CL fixes this by pausing WebVR VSyncs until the minimum duration for the
splash screen is passed.

TBR=ymalik@google.com

(cherry picked from commit 7fc0c9593c072895c1c01d63c890d5af4d6d2cb1)

Bug:  801639 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If2580a97e714a17de5445fba85ab0aa6b487964b
Reviewed-on: https://chromium-review.googlesource.com/879268
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531275}
Reviewed-on: https://chromium-review.googlesource.com/887804
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#103}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/elements/transient_element.cc
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/elements/transient_element.h
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/elements/transient_element_unittest.cc
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/model/web_vr_model.h
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/ui.cc
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/ui.h
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/b46fa9c1be579ee49f88071b15ed7bc00f5b85cd/chrome/browser/vr/ui_unittest.cc

Comment 9 by ymalik@chromium.org, Jan 28 2018

Status: Fixed (was: Assigned)
Labels: Test-Complete

Sign in to add a comment