New issue
Advanced search Search tips

Issue 801634 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR Omnibox: Keyboard disappears if user clicks in thin space between omnibox and first result

Project Member Reported by dbbrooks@chromium.org, Jan 12 2018

Issue description

Chrome Version: 65.0.3316.0
OS: Android N
VrCore: 1.12.177372015


What steps will reproduce the problem?
1. Enter VR
2. Click URL area in omnibox to switch to “omnibox text entry mode”
3. type some text
4. click in thin space between omnibox and first suggestion above it.

What is the expected result? nothing

What happens instead? keyboard disappears. See screenshot.

 
Screenshot_20180112-133245.png
757 KB View Download
Owner: ymalik@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd

commit fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd
Author: Yash Malik <ymalik@google.com>
Date: Thu Jan 18 17:46:36 2018

VR: Show keyboard when cancelling audio permission prompt

Also make the spacer in the suggestions layout and the back button
non-focusable so it doesn't steal focus from the omnibox and hide
the keyboard.

Bug:  801402 ,  801634 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia7b09b66e7f98ddc89ede4f67a4ad02544079553
Reviewed-on: https://chromium-review.googlesource.com/871515
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530189}
[modify] https://crrev.com/fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd/chrome/browser/vr/elements/button.cc
[modify] https://crrev.com/fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd/chrome/browser/vr/ui_scene_creator.cc

Comment 3 by ymalik@chromium.org, Jan 18 2018

Status: Fixed (was: Assigned)
Labels: M-65 Test-Manual
Status: Assigned (was: Fixed)
This still repros in build 66.0.3346.0 Canary build on a Pixel 2 Android 8.1.0

Comment 6 by ymalik@chromium.org, Feb 26 2018

Labels: -M-65 M-67

Comment 7 by ymalik@chromium.org, Apr 23 2018

Owner: cjgrant@chromium.org
Hi Chris, sending this your way :)
Status: Fixed (was: Assigned)
This is obsolete and no longer an issue.  An omnibox layout refactor CL inadvertently fixed this issue.

Sign in to add a comment