New issue
Advanced search Search tips

Issue 801622 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

network_3GModemControl fails in autoconnect scenario

Project Member Reported by benchan@chromium.org, Jan 12 2018

Issue description

shill now disables autoconnect on any cellular service before a user logs in (see b:70835725 and CL:851267), which causes network_3GModemControl to fail in the autoconnect scenario as the test expects the cellular service to be autoconnected by shill.


 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1133ab7ace7499056448157bc5601ce5ad0433bb

commit 1133ab7ace7499056448157bc5601ce5ad0433bb
Author: Ben Chan <benchan@chromium.org>
Date: Sat Jan 13 06:37:45 2018

cellular: fix autoconnect scenario in network_3GModemControl

Since CL:851267, shill disables autoconnect on any cellular service
before a user logs in. To properly test the autoconnect scenario in
network_3GModemControl, this CL modifies network_3GModemControl to run
the test under a user session.

BUG= chromium:801622 
CQ-DEPEND=CL:865274
TEST=Run network_3GModemControl on a DUT with a cellular modem.

Change-Id: I1c53b8e7b5b8430f8ebc6c35914ab567b0899b0f
Reviewed-on: https://chromium-review.googlesource.com/864623
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/1133ab7ace7499056448157bc5601ce5ad0433bb/client/site_tests/network_3GModemControl/network_3GModemControl.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/976e4b8b658d7f36f4cf5e1106a96105ff01cf14

commit 976e4b8b658d7f36f4cf5e1106a96105ff01cf14
Author: Ben Chan <benchan@chromium.org>
Date: Sat Jan 13 06:37:45 2018

autotest: move network_3GModemControl to autotest-chrome

network_3GModemControl now requires a Chrome user session to run the
test (CL:864623). This CL moves it from the autotest-tests-cellular
package to the autotest-chrome package.

BUG= chromium:801622 
CQ-DEPEND=CL:864623
TEST=Trybot runs.

Change-Id: I6ef001ec19212a3e07def7e703bb756070711ba6
Reviewed-on: https://chromium-review.googlesource.com/865274
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/976e4b8b658d7f36f4cf5e1106a96105ff01cf14/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
[modify] https://crrev.com/976e4b8b658d7f36f4cf5e1106a96105ff01cf14/chromeos-base/autotest-tests-cellular/autotest-tests-cellular-9999.ebuild

Status: Fixed (was: Started)
Labels: M-64 Merge-Request-64
The fix to this autotest was committed to R65, but not in R64.

Requesting merge to R64, so this autotest can pass in R64.
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 22 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: We are only 0 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b3164f3acda9026daa4ec1f5ce2ab1c2e9d94b7e

commit b3164f3acda9026daa4ec1f5ce2ab1c2e9d94b7e
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Jan 24 01:41:41 2018

autotest-chrome: block on old versions of cellular tests

With http://crosreview.com/865274, network_3GModemControl is part of
autotest-chrome. Set up a blocker to prevent collisions on incremental
builds.

BUG= chromium:801622 
TEST=incremental build_packages; see autotest-tests-cellular upgraded

Change-Id: Ibbae47ab511d87e7ffb559655de10ee018e2efa5
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/879962
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/b3164f3acda9026daa4ec1f5ce2ab1c2e9d94b7e/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Labels: -Merge-Review-64 Merge-Approved-64
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 24 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a20e74c3629e40cae1e9b29baf650733c10c82c4

commit a20e74c3629e40cae1e9b29baf650733c10c82c4
Author: Ben Chan <benchan@chromium.org>
Date: Wed Jan 24 08:04:34 2018

cellular: fix autoconnect scenario in network_3GModemControl

Since CL:851267, shill disables autoconnect on any cellular service
before a user logs in. To properly test the autoconnect scenario in
network_3GModemControl, this CL modifies network_3GModemControl to run
the test under a user session.

BUG= chromium:801622 
CQ-DEPEND=CL:865274
TEST=Run network_3GModemControl on a DUT with a cellular modem.

Change-Id: I1c53b8e7b5b8430f8ebc6c35914ab567b0899b0f
Reviewed-on: https://chromium-review.googlesource.com/864623
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
(cherry picked from commit 1133ab7ace7499056448157bc5601ce5ad0433bb)
Reviewed-on: https://chromium-review.googlesource.com/882953
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/a20e74c3629e40cae1e9b29baf650733c10c82c4/client/site_tests/network_3GModemControl/network_3GModemControl.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/93bd4cdcb04d11ba47484b4ab5026cb668b0481a

commit 93bd4cdcb04d11ba47484b4ab5026cb668b0481a
Author: Ben Chan <benchan@chromium.org>
Date: Wed Jan 24 08:04:35 2018

autotest: move network_3GModemControl to autotest-chrome

network_3GModemControl now requires a Chrome user session to run the
test (CL:864623). This CL moves it from the autotest-tests-cellular
package to the autotest-chrome package.

BUG= chromium:801622 
CQ-DEPEND=CL:864623
TEST=Trybot runs.

Change-Id: I6ef001ec19212a3e07def7e703bb756070711ba6
Reviewed-on: https://chromium-review.googlesource.com/865274
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
(cherry picked from commit 976e4b8b658d7f36f4cf5e1106a96105ff01cf14)
Reviewed-on: https://chromium-review.googlesource.com/882688
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/93bd4cdcb04d11ba47484b4ab5026cb668b0481a/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
[modify] https://crrev.com/93bd4cdcb04d11ba47484b4ab5026cb668b0481a/chromeos-base/autotest-tests-cellular/autotest-tests-cellular-9999.ebuild

Labels: -Merge-Approved-64 Merge-Merged

Sign in to add a comment