Support jumbo in components/viz |
|||
Issue descriptioncomponents/viz is the second slowest component to compile, and the slowest one, components/sync, already has jumbo support. When compiling chrome+content_shell+blink_tests components/viz needs 7.3 CPU minutes, or 0.9-1.8% of the compilation time so giving components/viz jumbo support has the potential to speed up a full build by about 1%.
,
Jan 16 2018
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6e227bde18b6cb0520c463edb5f95f3a520d739 commit e6e227bde18b6cb0520c463edb5f95f3a520d739 Author: Daniel Bratell <bratell@opera.com> Date: Tue Jul 17 18:12:24 2018 [jumbo] Merged two GetActiveTextureUnit functions In jumbo build experiments, two (identical but small) GetActiveTextureUnit() functions ended up in the same translation unit which caused the compiler to fail. This patch moves the useful function into a shared utility file. Bug: 801580 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id6f8f1002db18593150bec30f1e8b7092f464e13 Reviewed-on: https://chromium-review.googlesource.com/1136308 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#575721} [modify] https://crrev.com/e6e227bde18b6cb0520c463edb5f95f3a520d739/components/viz/service/display/display_resource_provider.cc
,
Sep 19
This landed last Thursday but I failed to reference this bug.
The commit message is:
Support jumbo builds in components/viz
Jumbo is a unity build system for Chromium. By combining many cc files
in the same translation unit, the compiler doesn't have to repeat all
the work triggered by shared header. This normally makes building 5-20
times faster.
The downside to jumbo is that code intended to be local to one cc file
suddenly becomes more exposed and might clash with other code.
Jumbo support in components/viz currently saves about 5 CPU minutes of effort,
about 1% of the total reference build effort.
Bug: viz bug
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7bff566b96b2caeac66aa8e6fb67495231206d51
Reviewed-on: https://chromium-review.googlesource.com/951791
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590954}
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jan 15 2018