New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801578 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 803843
issue 804292

Blocking:
issue 784319
issue 787834



Sign in to add a comment

New API to create a browser in Telemetry

Project Member Reported by perezju@chromium.org, Jan 12 2018

Issue description

In the context of  issue 784319 , we need a new API to create browsers in Telemetry.

This is in order to support use cases where setting up the environment (e.g. preparing a profile directory, or writing the command line file in Android) and actually launching the browser may need to be done independently of each other.

Instead of the older API:

- possible_browser.Create(finder_options)

The proposed new API will consist of:

- possible_browser.SetUpEnvironment(browser_options)
- possible_browser.Create()  # No longer receives any options
- possible_browser.CleanUpEnvironment()

Also, for convenience, a context-manager wrapper will be provided which takes care of doing all three steps when needed:

- possible_browser.BrowserSession(browser_options)
 
Blocking: 784319 787834
For my own records, these are locations I'm aware of where Telemetry browsers are being created, and will need to be updated.

catapult:
- telemetry/bin/run_snap_it_unittest
- telemetry/telemetry/page/shared_page_state.py
- telemetry/telemetry/internal/snap_page_util.py
- telemetry/telemetry/internal/backends/chrome/cros_test_case.py
- telemetry/telemetry/internal/browser/browser_unittest.py
- telemetry/telemetry/internal/browser/browser.py (docstring only)
- telemetry/telemetry/internal/browser/extension_unittest.py
- telemetry/telemetry/testing/browser_test_case.py
- telemetry/telemetry/testing/serially_executed_browser_test_case.py

chromium:
- components/proximity_auth/e2e_test/cros.py
- tools/bisect-manual-test.py
- tools/perf/page_sets/dual_browser_story.py
- tools/perf/profile_creators/profile_extender.py
- tools/perf/page_sets/pregenerated_profile_shared_state.py
- tools/perf/record_android_profile.py
- third_party/webgl/src/tools/conformance.py

cros:
- autotest/files/client/common_lib/cros/chrome.py

Also copying from achuith in issue 801214#2

> We set finder options and browser options through this wrapper in chromeos:
https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/common_lib/cros/chrome.py?l=123-124

> The easiest way to verify that you haven't broken anything is to run cros_run_vm_test from the simple chrome SDK shell. This runs a quick sanity test that invokes chrome.py. Let me know if you have any problems with this.

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/57768171c9012bd1559de47986d18837e4662504

commit 57768171c9012bd1559de47986d18837e4662504
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Tue Jan 16 17:50:09 2018

[Telemetry] New API to create browsers

This CL introduces thew new API methods to create a browser out of a
possible_browser. The old API still works.

This is needed to support use cases where setting up the browser
environment (preparing a profile directory, or writing a command line
file) needs to be separated from actually starting the browser.

TBR=achuith@chromium.org
Bug:  chromium:801578 
Change-Id: I0ae9aac2f5e44540b3b27e4c5b2777a301b54e60
Reviewed-on: https://chromium-review.googlesource.com/864862
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/57768171c9012bd1559de47986d18837e4662504/telemetry/telemetry/internal/browser/possible_browser.py
[modify] https://crrev.com/57768171c9012bd1559de47986d18837e4662504/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
[modify] https://crrev.com/57768171c9012bd1559de47986d18837e4662504/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py
[modify] https://crrev.com/57768171c9012bd1559de47986d18837e4662504/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
[modify] https://crrev.com/57768171c9012bd1559de47986d18837e4662504/telemetry/telemetry/internal/browser/browser_options.py
[modify] https://crrev.com/57768171c9012bd1559de47986d18837e4662504/telemetry/telemetry/internal/browser/browser_unittest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/2c47ed7f0c4141e61c0feccb26e21d286a2a93b6

commit 2c47ed7f0c4141e61c0feccb26e21d286a2a93b6
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Wed Jan 17 11:56:27 2018

[Telemetry] Migrate snap_page to new browser API

Switch to the new context managed BrowserSession.

Bug:  chromium:801578 
Change-Id: I77bc362182a1e7e5942df1edf42a08a9646e3b48
Reviewed-on: https://chromium-review.googlesource.com/867910
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/2c47ed7f0c4141e61c0feccb26e21d286a2a93b6/telemetry/telemetry/internal/snap_page_util.py
[modify] https://crrev.com/2c47ed7f0c4141e61c0feccb26e21d286a2a93b6/telemetry/bin/run_snap_it_unittest

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f1d0d2bec8962982de4dd66c6a1391ce529a3449

commit f1d0d2bec8962982de4dd66c6a1391ce529a3449
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Wed Jan 17 12:04:08 2018

[Telemetry] Migrate extension_unittest to new browser API

For simplicity, use a context manager to manage the lifetime of the
browser.

Bug:  chromium:801578 
Change-Id: I579d81139be2c376f311824b10d26b4d55534851
Reviewed-on: https://chromium-review.googlesource.com/867914
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/f1d0d2bec8962982de4dd66c6a1391ce529a3449/telemetry/telemetry/internal/browser/extension_unittest.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/9617d2e851c42ab94a89f9c2aa299eee0f507482

commit 9617d2e851c42ab94a89f9c2aa299eee0f507482
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Wed Jan 17 13:11:29 2018

[Telemetry] Migrate browser docstring and tests to new API

- Update the doctring on the Browser object.
- Update all tests in browser_unittests to use the new BrowserSession.
- Add a testCreateWithoutEnvironment still using the old API, to make
  sure we don't break the old flow while migration process is still
  ongoing.

Bug:  chromium:801578 
Change-Id: Id36d15a81842d3742a34707e0767949ca7e33587
Reviewed-on: https://chromium-review.googlesource.com/870211
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/9617d2e851c42ab94a89f9c2aa299eee0f507482/telemetry/telemetry/internal/browser/browser.py
[modify] https://crrev.com/9617d2e851c42ab94a89f9c2aa299eee0f507482/telemetry/telemetry/internal/browser/browser_unittest.py

Blockedon: 803104
Blockedon: -803104
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/739be847e9987e0d069a60dd114abcdcd2ec5df1

commit 739be847e9987e0d069a60dd114abcdcd2ec5df1
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Wed Jan 17 17:08:40 2018

[Telemetry] Migrate SeriallyExecutedBrowserTestCase to new API

Within Start-/StopBrowser we add, as appropriate, calls to
SetUp-/CleanUpEnvironment.

Bug:  chromium:801578 
Change-Id: Ie332e95c042d3d46c1ff9aa6909040d827b8ae22
Reviewed-on: https://chromium-review.googlesource.com/870873
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/739be847e9987e0d069a60dd114abcdcd2ec5df1/telemetry/telemetry/testing/serially_executed_browser_test_case.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/1e70b8208a77f9b1c918590b74462b8da9e7dbd0

commit 1e70b8208a77f9b1c918590b74462b8da9e7dbd0
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Jan 18 01:48:36 2018

Revert "[Telemetry] Migrate SeriallyExecutedBrowserTestCase to new API"

This reverts commit 739be847e9987e0d069a60dd114abcdcd2ec5df1.

Reason for revert: break catapult roll https://chromium-review.googlesource.com/c/chromium/src/+/871696

Original change's description:
> [Telemetry] Migrate SeriallyExecutedBrowserTestCase to new API
> 
> Within Start-/StopBrowser we add, as appropriate, calls to
> SetUp-/CleanUpEnvironment.
> 
> Bug:  chromium:801578 
> Change-Id: Ie332e95c042d3d46c1ff9aa6909040d827b8ae22
> Reviewed-on: https://chromium-review.googlesource.com/870873
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

TBR=perezju@chromium.org,nednguyen@google.com

Change-Id: Ia84f83a103c4f26d744ed48fda94d3b9d7c61091
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:801578 
Reviewed-on: https://chromium-review.googlesource.com/872291
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/1e70b8208a77f9b1c918590b74462b8da9e7dbd0/telemetry/telemetry/testing/serially_executed_browser_test_case.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e6f8963fbddd15613a73dda8bbc417896471bbda

commit e6f8963fbddd15613a73dda8bbc417896471bbda
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Thu Jan 18 12:01:17 2018

[Telemetry] Refactor startup tracing test

The testStartupTracing* tests need to create their own browser instance,
so they shouldn't reuse TabTestCase (or BrowserTestCase).

In the older implementation they closed the browser created for them by
the class without using it (thus preventing other tests in the class
from reusing it), and then went on to create a new one which wouldn't
be reusable.

The code is simpler (and the running time for tests probably faster) if
we just make this test responsible for managing the lifetime of its own
browser.

Also consolidate tests for all platforms in a single testStartupTracing
method.

Bug:  chromium:801578 
Change-Id: I59cc01994c091de8c4df8bb0656acb37bb4c50c6
Reviewed-on: https://chromium-review.googlesource.com/870773
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/e6f8963fbddd15613a73dda8bbc417896471bbda/telemetry/telemetry/core/tracing_controller_unittest.py

I will take:
- tools/perf/profile_creators/profile_extender.py
- tools/perf/page_sets/pregenerated_profile_shared_state.py
- tools/perf/record_android_profile.py
- third_party/webgl/src/tools/conformance.py
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/048be30b377e6e432574b6899771a120de5d3a62

commit 048be30b377e6e432574b6899771a120de5d3a62
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Thu Jan 18 16:24:46 2018

Reland "[Telemetry] Migrate SeriallyExecutedBrowserTestCase to new API"

Within Start-/StopBrowser we add, as appropriate, calls to
SetUp-/CleanUpEnvironment.

Bug:  chromium:801578 
Change-Id: Iae44a1c2879bf02218dd2fba4f2c914c877d3b5b
Reviewed-on: https://chromium-review.googlesource.com/873372
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/048be30b377e6e432574b6899771a120de5d3a62/telemetry/telemetry/testing/serially_executed_browser_test_case.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/16a2f81ffef09962f3727aa56f67a4a98b0b923e

commit 16a2f81ffef09962f3727aa56f67a4a98b0b923e
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Thu Jan 18 17:13:56 2018

[Telemetry] Migrate cros_test_case.CrOSTestCase to new browser API

Update the internal _CreateBrowser method to use the new BrowserSession
context manager.

No changes are required on the client (cros_unittest.py) since all
callers already used the context managed syntax to handle the browser's
life time.

Bug:  chromium:801578 
Change-Id: I88fc54728999ccbb07a2f43529a253f881174ca2
Reviewed-on: https://chromium-review.googlesource.com/870316
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/16a2f81ffef09962f3727aa56f67a4a98b0b923e/telemetry/telemetry/internal/backends/chrome/cros_test_case.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0294165dcff47518724a7a7f4030052393ab59f2

commit 0294165dcff47518724a7a7f4030052393ab59f2
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jan 19 02:22:27 2018

Temporarily skip a GPU unittest that depends on a Catapult roll.

BUG= 801578 
TBR=nednguyen@google.com, perezju@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2087aef497af6211d0445fa7bc4a20fff73d5f80
Reviewed-on: https://chromium-review.googlesource.com/875329
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530396}
[modify] https://crrev.com/0294165dcff47518724a7a7f4030052393ab59f2/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/51d9354bb0d49f49769263b88a832e94bd92a19f

commit 51d9354bb0d49f49769263b88a832e94bd92a19f
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Fri Jan 19 11:30:41 2018

Fix Fakes for telemetry_gpu_unittests to pass.

Needed after https://chromium-review.googlesource.com/873372 .

TBR=nednguyen@google.com,kbr@chromium.org
BUG= chromium:801578 

Change-Id: I758b8591b494e440b9bb9cd3d25c3d5fc45f5f70
Reviewed-on: https://chromium-review.googlesource.com/874477
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/51d9354bb0d49f49769263b88a832e94bd92a19f/telemetry/telemetry/testing/fakes/__init__.py
[modify] https://crrev.com/51d9354bb0d49f49769263b88a832e94bd92a19f/telemetry/telemetry/page/shared_page_state_unittest.py

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db246834025692b4cea01d5614564b2a7cbd61e5

commit db246834025692b4cea01d5614564b2a7cbd61e5
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri Jan 19 12:54:03 2018

Roll src/third_party/catapult/ b4706e732..51d9354bb (9 commits)

https://chromium.googlesource.com/catapult.git/+log/b4706e73204b..51d9354bb0d4

$ git log b4706e732..51d9354bb --date=short --no-merges --format='%ad %ae %s'
2018-01-19 perezju Fix Fakes for telemetry_gpu_unittests to pass.
2018-01-18 kbr Use vpython's wheels for the cv2 and numpy libraries.
2018-01-17 dtu [pinpoint] Shorten display name for patches.
2018-01-18 simonhatch Dashboard - Remove bisect fyi bot code.
2018-01-18 eakuefner [Dashboard] Generate old-style rows for histogram uploads
2018-01-18 charliea Log wmic exit code when it fails
2018-01-18 achuith [oobe]: Use --oobe-skip-to-login instead of Oobe.skipToLoginForTesting.
2018-01-17 perezju [Telemetry] Migrate cros_test_case.CrOSTestCase to new browser API
2018-01-18 perezju Reland "[Telemetry] Migrate SeriallyExecutedBrowserTestCase to new API"

Created with:
  roll-dep src/third_party/catapult
BUG= 801578 , 776804 , 753870 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I0836e5381460acc83837bce9ed5e752e233c0344
Reviewed-on: https://chromium-review.googlesource.com/875904
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530493}
[modify] https://crrev.com/db246834025692b4cea01d5614564b2a7cbd61e5/DEPS

Cc: kbr@chromium.org
+kbr FYI - catapult autoroller is unblocked now.
Blockedon: 803843
Project Member

Comment 22 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/3318544c51d46d3165d7fb9929da58bb2049574b

commit 3318544c51d46d3165d7fb9929da58bb2049574b
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Fri Jan 19 15:09:21 2018

[Telemetry] Migrate browser_test_case to new API

- Make sure the class sets up the browser environment during setUpClass,
  and cleans it up on tearDownClass. A single browser instance is still
  shared across all tests within the same class.

- Remove the reliance on a global browser object.

Bug:  chromium:801578 
Change-Id: I083bcfebd9d6d684c3cea168f08e805b59d64016
Reviewed-on: https://chromium-review.googlesource.com/870592
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/3318544c51d46d3165d7fb9929da58bb2049574b/telemetry/telemetry/testing/run_tests.py
[modify] https://crrev.com/3318544c51d46d3165d7fb9929da58bb2049574b/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
[modify] https://crrev.com/3318544c51d46d3165d7fb9929da58bb2049574b/telemetry/telemetry/testing/browser_test_case.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c6ac2d7d713ce5123ecfcf913ab806d77ed1622

commit 9c6ac2d7d713ce5123ecfcf913ab806d77ed1622
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Jan 19 15:37:16 2018

Remove pregenerated_*profile_shared_state [dead code]

Bug:  801578 
Change-Id: I49a729163b098184dd5ef4dbecac1dfaa6f6586d
Reviewed-on: https://chromium-review.googlesource.com/875909
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#530513}
[delete] https://crrev.com/1d8b1158b1d3a12858bfaa9c49064522f4d3df02/tools/perf/page_sets/pregenerated_large_profile_shared_state.py
[delete] https://crrev.com/1d8b1158b1d3a12858bfaa9c49064522f4d3df02/tools/perf/page_sets/pregenerated_profile_shared_state.py

Project Member

Comment 24 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd6477f81346f79f9ebd595098c4b6f84fca8004

commit cd6477f81346f79f9ebd595098c4b6f84fca8004
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Jan 19 15:55:48 2018

Remove profile_creator since they are not used anywhere

There are two entries points to profile_generator:
1) ./tools/perf/generate_profile --> this script is currently not runnable due
to a bug at https://cs.chromium.org/chromium/src/tools/perf/generate_profile?rcl=6afb508ae3bfe9594cfcc2ff2e44325f329f7707&l=9. The fact that no one discovers this for a long time
mean no one is using this
2) ExtensionProfileSharedState in tools/perf/page_sets/extension_profile_shared_state.py.
This shared state is not referenced by any benchmark/page_set

Given (1) & (2), it's clear that tools/perf/profile_creators/ are dead code.
Since they are using browser API extensively which we are wanting to refactor
(see attached bug), it's better to just remove these dead code. They are not
providing any value while slowing us down.

Bug:  801578 
Change-Id: Ic3122656bc3e18211ca10a068a110e4ff95a4630
Reviewed-on: https://chromium-review.googlesource.com/875908
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#530521}
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/generate_profile
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/page_sets/extension_profile_shared_state.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/__init__.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/cookie_profile_extender.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/cookie_profile_extender_unittest.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/extension_profile_extender.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/extension_profile_extender_unittest.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/extension_set.csv
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/fast_navigation_profile_extender.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/fast_navigation_profile_extender_unittest.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/large_profile_extender.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/profile_extender.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/profile_generator.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/profile_generator_unittest.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/profile_safe_url_generator.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/profile_safe_url_list.json
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/profile_safe_url_list.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/small_profile_extender.py
[delete] https://crrev.com/8b70a41f454b84509a014ff03f9e3fe09587ed97/tools/perf/profile_creators/update_remote_extensions.py

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67375348451891b00f531498403a4fdedb6a87f2

commit 67375348451891b00f531498403a4fdedb6a87f2
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Jan 19 16:23:30 2018

Remove record_android_profile [deadcode/obsolete tool]

This script is deemed for removal because
1) It has been broken for long time --> no one has been using this
2) This relies on profiler which we are deprecating (see https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/uAYGe9sLDJQ)

Bug:  801578 
Change-Id: I48bd20942f2213b844a70e13ea97d33115ce3412
Reviewed-on: https://chromium-review.googlesource.com/875910
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#530530}
[delete] https://crrev.com/0f2a785127eeda2c9bdc2d52458d7f0481c2eb13/tools/perf/record_android_profile.py

Project Member

Comment 26 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4422cf34694d80d6db49d0da7beecb50975f082

commit e4422cf34694d80d6db49d0da7beecb50975f082
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Fri Jan 19 18:06:03 2018

[tools/perf] Migrate MultiBrowserSharedState to new browser API

- Add the necessary calls to SetUp-/CleanUpEnvironment.
- Also be more explicit to distinguish finder_ vs browser_options

Bug:  801578 
Change-Id: I689bf0fdfb1bdf5fe1b1b8e9e3ca8403edbce6bf
Reviewed-on: https://chromium-review.googlesource.com/876426
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#530561}
[modify] https://crrev.com/e4422cf34694d80d6db49d0da7beecb50975f082/tools/perf/page_sets/dual_browser_story.py

Project Member

Comment 27 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2922c9017fcd63c0a738fff449731b05f9f66419

commit 2922c9017fcd63c0a738fff449731b05f9f66419
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jan 19 21:06:40 2018

Re-enable a GPU unittest and update it for the new browser creation API.

BUG= 801578 
TBR=nednguyen@google.com, perezju@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0e5f31cb6912dcd1bc5da54108b66639beda546a
Reviewed-on: https://chromium-review.googlesource.com/876653
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530609}
[modify] https://crrev.com/2922c9017fcd63c0a738fff449731b05f9f66419/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py

New update. As of today, I believe only the following references remain:

catapult:
- telemetry/telemetry/page/shared_page_state.py

chromium:
- components/proximity_auth/e2e_test/cros.py
- tools/bisect-manual-test.py

cros:
- autotest/files/client/common_lib/cros/chrome.py


I'll proceed with shared_page_state.py, and filed  issue 804292  for cros related ones.
Project Member

Comment 29 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/cbc1ddc6abfaebb90c655d169772d23059bde4e5

commit cbc1ddc6abfaebb90c655d169772d23059bde4e5
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Mon Jan 22 14:45:35 2018

Migrate shared_page_state to new browser API

- Add explicit calls to SetUp-/CleanUpEnvironment.
- For each page, copy only the browser_options rather than the full
  finder_options (but see crbug.com/801513).

Bug:  chromium:801578 
Change-Id: Id2569616e06dd6c1813fdc20d7611b82870adbfe
Reviewed-on: https://chromium-review.googlesource.com/878368
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/cbc1ddc6abfaebb90c655d169772d23059bde4e5/telemetry/telemetry/internal/browser/browser_options.py
[modify] https://crrev.com/cbc1ddc6abfaebb90c655d169772d23059bde4e5/telemetry/telemetry/page/shared_page_state.py

Blockedon: 804292
Blockedon: 804863
Project Member

Comment 32 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5983e37f9c214ac0c248738ffc0c5cd2b82a3490

commit 5983e37f9c214ac0c248738ffc0c5cd2b82a3490
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Mon Jan 29 09:37:57 2018

[Telemetry refactor] Migrate proximity_auth client to new browser API

- Add explicit calls to SetUp-/CleanUpEnvironment.

TBR=tengs@chromium.org

Bug:  804292 , 801578 
Change-Id: I54d0925b308867020ed69b4330abd529beb61d77
Reviewed-on: https://chromium-review.googlesource.com/881142
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532372}
[modify] https://crrev.com/5983e37f9c214ac0c248738ffc0c5cd2b82a3490/components/proximity_auth/e2e_test/cros.py

Blockedon: -804863
Project Member

Comment 34 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/9ce4426b187bc7fdeca5e13e3632502f0189d275

commit 9ce4426b187bc7fdeca5e13e3632502f0189d275
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Tue Jan 30 14:40:10 2018

[Telemetry] Remove support for old browser creation API

We believe all clients of the old API have been updated at this point.
If this change breaks your test do follow up on the linked bug to
figure out the best course of action.

Bug:  chromium:801578 
Change-Id: I4159abfebec202534bceca8c79c0deb0d928cc46
Reviewed-on: https://chromium-review.googlesource.com/878801
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/9ce4426b187bc7fdeca5e13e3632502f0189d275/telemetry/telemetry/internal/browser/possible_browser.py
[modify] https://crrev.com/9ce4426b187bc7fdeca5e13e3632502f0189d275/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
[modify] https://crrev.com/9ce4426b187bc7fdeca5e13e3632502f0189d275/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py
[modify] https://crrev.com/9ce4426b187bc7fdeca5e13e3632502f0189d275/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
[modify] https://crrev.com/9ce4426b187bc7fdeca5e13e3632502f0189d275/telemetry/telemetry/testing/fakes/__init__.py
[modify] https://crrev.com/9ce4426b187bc7fdeca5e13e3632502f0189d275/telemetry/telemetry/internal/app/possible_app.py
[modify] https://crrev.com/9ce4426b187bc7fdeca5e13e3632502f0189d275/telemetry/telemetry/internal/browser/browser_unittest.py

Status: Fixed (was: Started)
This work is now completed.
🎉🎉🎉

Sign in to add a comment