New issue
Advanced search Search tips

Issue 801562 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Slight changes to layout test images due to Skia changes.

Project Member Reported by bsalo...@google.com, Jan 12 2018

Issue description

The images are trivially different
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8be78f5c56cde242e42a598cf80afb933abfa68e

commit 8be78f5c56cde242e42a598cf80afb933abfa68e
Author: Brian Salomon <bsalomon@google.com>
Date: Fri Jan 12 15:28:46 2018

Mark layout tests for rebaseline to unblock skia roll

NOTRY=true

Bug:  801562 
Change-Id: Ie2687efe4a6aba241e12350c7aa3cc5b858db37f
Reviewed-on: https://chromium-review.googlesource.com/864402
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528948}
[modify] https://crrev.com/8be78f5c56cde242e42a598cf80afb933abfa68e/third_party/WebKit/LayoutTests/TestExpectations

Components: Internals>Skia
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e08752ee86d8ba8b03dfb00cd69ef6770846cc32

commit e08752ee86d8ba8b03dfb00cd69ef6770846cc32
Author: Brian Salomon <bsalomon@google.com>
Date: Tue Jan 16 19:02:19 2018

Rebaseline tests after change to Skia image rendering

Bug:  801562 
Change-Id: I86d94607c2d49526d06566dc3a31435ae23edf45
Reviewed-on: https://chromium-review.googlesource.com/865174
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529479}
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/1170e81211a15649e0381ea9a83552ff815f907f/third_party/WebKit/LayoutTests/images/pixelated-composited-expected.html
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/images/pixelated-composited-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/images/pixelated-composited-expected.txt
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-simple-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-sizing-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-tiled-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/paint-subrect-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-simple-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-sizing-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/paint-subrect-expected.png
[modify] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png
[delete] https://crrev.com/1170e81211a15649e0381ea9a83552ff815f907f/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png
[delete] https://crrev.com/1170e81211a15649e0381ea9a83552ff815f907f/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-canvas-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-image-expected.png
[add] https://crrev.com/e08752ee86d8ba8b03dfb00cd69ef6770846cc32/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-svg-image-expected.png
[delete] https://crrev.com/1170e81211a15649e0381ea9a83552ff815f907f/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png

Comment 4 by cnardi@chromium.org, May 15 2018

Status: Fixed (was: Untriaged)
Marking this as Fixed as it doesn't appear that any lines in TestExpectations still refer to this bug.

Sign in to add a comment