New issue
Advanced search Search tips

Issue 801546 link

Starred by 1 user
Status: Duplicate
Merged: issue 796127
Owner:
peria@chromium.org
Closed: Jan 2018
Cc:
yukishiino@chromium.org
jgruber@chromium.org
cbruni@chromium.org
peria@chromium.org
b...@b6n.ch
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocked on:
issue 789964


Sign in to add a comment

1.3%-369.2% regression in v8.browsing_desktop at 528576:528600

Project Member Reported by jgruber@chromium.org, Jan 12 2018 
V8 regression range contains only https://chromium-review.googlesource.com/860679:

03e9d41 Reland: Reimplement Object.entries/values as CSA to optimize performance. by Taketoshi Aono
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 12 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=801546

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=7f8b71cb78dc7bef9d147ef71fb30c4614ed96ae86d160971314c6ec493247a9


Bot(s) for this bug's original alert(s):

chromium-rel-win10

Comment 3 by jgruber@chromium.org, Jan 12 2018

Cc: b...@b6n.ch cbruni@chromium.org
Regressions appear to be in old space:

https://chromeperf.appspot.com/report?sid=6b7f669d3f7ed2e0d54b0eed6d0f4b824e3e56d6cd2439ae2d5ce47e416dddf9&start_rev=526211&end_rev=528900

Note that this is both allocated_objects_size and effective_size.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jan 12 2018

Cc: peria@chromium.org yukishiino@chromium.org
Owner: peria@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1481a1df040000

Automatically add data dependency on v8_context_snapshot.bin
By peria@chromium.org · Thu Jan 11 09:27:36 2018
chromium @ 2ee0de571572f625c344e6af12030d2c5ee31483

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 7 by jgruber@chromium.org, Jan 12 2018

Cc: -yukishiino@chromium.org -peria@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Bisect seems wrong, kicked off two more.

Comment 8 by b...@b6n.ch, Jan 12 2018 

Is this my bug?
>> 03e9d41 Reland: Reimplement Object.entries/values as CSA to optimize performance. by Taketoshi Aono

Comment 9 by jgruber@chromium.org, Jan 12 2018 

That's my suspicion, but I wanted to wait for bisects to confirm.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jan 12 2018

Cc: peria@chromium.org yukishiino@chromium.org
Owner: peria@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/119f1ea7040000

Automatically add data dependency on v8_context_snapshot.bin
By peria@chromium.org · Thu Jan 11 09:27:36 2018
chromium @ 2ee0de571572f625c344e6af12030d2c5ee31483

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 11 by b...@b6n.ch, Jan 12 2018 

OK.
I wish it's not mine.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jan 12 2018 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12cf69af040000

Automatically add data dependency on v8_context_snapshot.bin
By peria@chromium.org · Thu Jan 11 09:27:36 2018
chromium @ 2ee0de571572f625c344e6af12030d2c5ee31483

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 13 by peria@chromium.org, Jan 15 2018

Blockedon: 789964
Labels: OS-Linux OS-Mac OS-Windows

Comment 14 by peria@chromium.org, Jan 15 2018

Mergedinto: 796127
Status: Duplicate (was: Assigned)
►

Sign in to add a comment