New issue
Advanced search Search tips

Issue 801533 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Faiure for gesture-tapHighlight-form-input-text.html on WebKit Linux Trusty (dbg)

Project Member Reported by fhorschig@chromium.org, Jan 12 2018

Issue description

There are 2 failures within the last three build of https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/8706
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/8708


Example log:
02:17:45.305 22997 worker/6 compositing/gestures/gesture-tapHighlight-form-input-text-expected.html output stderr lines:
02:17:45.305 22997   
02:17:45.305 22997   DevTools listening on ws://127.0.0.1:49215/devtools/browser/ab2a4beb-f097-4da7-ba1b-3f1c715cc271
02:17:45.305 22997   Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf
02:17:45.305 22997   [29156:29156:0112/021740.380422:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
02:17:45.654 22997 "/b/s/w/ir/out/Debug/image_diff --diff /b/s/w/itCzZoIY/tmpeXxw0f/actual.png /b/s/w/itCzZoIY/tmpeXxw0f/expected.png /b/s/w/itCzZoIY/tmpeXxw0f/diff.png" took 0.35s
02:17:46.010 22997 "/b/s/w/ir/out/Debug/image_diff --diff /b/s/w/itCzZoIY/tmpMbZFY_/actual.png /b/s/w/itCzZoIY/tmpMbZFY_/expected.png /b/s/w/itCzZoIY/tmpMbZFY_/diff.png" took 0.35s
02:17:46.038 22865 [560/3262] virtual/spv175/compositing/gestures/gesture-tapHighlight-form-input-text.html failed unexpectedly (reference mismatch)
02:17:46.011 22997 worker/6 virtual/spv175/compositing/gestures/gesture-tapHighlight-form-input-text.html failed:
02:17:46.011 22997 worker/6  reference mismatch
02:17:46.011 22997 worker/6 killing secondary driver
02:17:46.011 22997 killed pid 29028


+paint-dev@: Can anyone here help investigating and triaging?
 
Labels: -Pri-1 -Sheriff-Chromium Pri-3
Mark the test flaky with https://crrev.com/c/864143.
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ac650c3062a8b54ed09d03e2c2c3c1f6792b734

commit 8ac650c3062a8b54ed09d03e2c2c3c1f6792b734
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Jan 12 16:45:06 2018

Mark gesture-tapHighlight-form-input-text.html flaky on Linux

This test flaked in 2 out of the last 3 builds. Mark it flaky for
Linux bots only.

TBR=paint-dev@chromium.org

Bug:  801533 
Change-Id: Ied3dcd4aec67a3b442d98526d774c7dabc41e7bc
Reviewed-on: https://chromium-review.googlesource.com/864143
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528971}
[modify] https://crrev.com/8ac650c3062a8b54ed09d03e2c2c3c1f6792b734/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6f8aa8c8ab9bc85d51f0d6c9cf437a3d517188a

commit a6f8aa8c8ab9bc85d51f0d6c9cf437a3d517188a
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jan 12 19:58:09 2018

[PE] Deflake compositing/gestures/gesture-tapHighlight-form-input-text.html

When the test failed, one of the test result and the expected result
had a black triangle at the bottom-left corner of the input and the
other didn't have. This means that the states of the input were different
and the native theme painted differently. The root cause was that the
test uses setTimeout() which doesn't garantee timely result.

I would not bother to change logic of the old test. Just add
-webkit-appearance: none to avoid different painting in different states.

Bug:  801533 
Change-Id: Ifff1478c56c31ed99efeccc79405d9a65f982d1f
Reviewed-on: https://chromium-review.googlesource.com/864822
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529034}
[modify] https://crrev.com/a6f8aa8c8ab9bc85d51f0d6c9cf437a3d517188a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a6f8aa8c8ab9bc85d51f0d6c9cf437a3d517188a/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-form-input-text-expected.html
[modify] https://crrev.com/a6f8aa8c8ab9bc85d51f0d6c9cf437a3d517188a/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-form-input-text.html

Status: Fixed (was: Assigned)
Summary: Faiure for gesture-tapHighlight-form-input-text.html on WebKit Linux Trusty (dbg) (was: Faiure for gesture-tapHighlight-form-input-text-expected.html on WebKit Linux Trusty (dbg))

Sign in to add a comment