New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801522 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression : Arrow pointer is seen instead of Hand pointer on hovering mouse pointer on 'Pause'/'Play' and 'Volume' icons for video in General information page of FilesApp

Project Member Reported by mmanchala@chromium.org, Jan 12 2018

Issue description

Chrome Version: 64.0.3282.87/10176.47.0 beta channel  Daisy, Candy & Reks
OS: Chrome

What steps will reproduce the problem?
1)Sign in to user ->Now go to above URL -> download any Video
(2)Now go to Files App  -> Select downloaded video -> Right Click and select 'Get info' option or click on 'Space' Key
(3)Now in General information page hover mouse pointer on 'Pause'/'Play' and 'Volume' icons of video and observe Arrow pointer is seen instead of Hand pointer(as icon is clickable) and observe no ripple effect is seen while clicking
(Please refer Video)

Note : 
1.In Files App select video and open with Video player -> Now hover mouse pointer on 'Pause'/'Play' and 'Volume' icons  and observe Hand pointer is seen (Please refer 'Expected_HandPointer' video)
2.Issue is seen on M-63 stable (63.0.3239.140/10032.86.0)and also on latest M-65

Expected: Hand pointer should be seen on hovering mouse pointer on 'Pause'/'Play' and 'Volume' icons for video in General information page 
Actual: Instead Arrow pointer is seen

This is Non-Regression Issue seen from M-62

@fukino : Please confirm the Issue
 
Actual_Arrowpointer.webm
3.0 MB View Download
Expected_HandPointer.webm
3.3 MB View Download
Labels: -M-64 M-65
Labels: -M-65 M-66
Labels: Inhouse-HYD-Reported
Cc: fukino@chromium.org
Owner: ----
Status: Available (was: Assigned)

Comment 5 by sashab@chromium.org, Feb 16 2018

Labels: CrOS-FilesApp

Comment 6 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp
Labels: M-69
Labels: -M-66
Labels: -Pri-2 -M-69 CrOSFilesFeature-QuickView Pri-3
Labels: Files-Fixit-2018
Owner: lucmult@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c48422d79696901578dd987aee50ee8dbe87e2e

commit 4c48422d79696901578dd987aee50ee8dbe87e2e
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 20 10:03:48 2018

Quick view: allow tab to audio and video controls

Change quick view for audios and videos to allow to use tab to focus
the audio and video HTML5 tag's controls, e.g.: play, slider and
volume.

Add a blue outline for focused elements inside audio and video HTML5
tags, as part of the accessibility to make visually clear what control
is focused.

Change audio to not show the download button since it's already in the
file system and downloading doesn't make sense in that context.

Change video to not show picture-in-picture since it doesn't work for
quick-view.

Bug: 627701,  801522 ,  848216 
Change-Id: Ie46159bc90d2948bbac98d69acaf8b53e62d5e58
Reviewed-on: https://chromium-review.googlesource.com/c/1341777
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609653}
[modify] https://crrev.com/4c48422d79696901578dd987aee50ee8dbe87e2e/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[modify] https://crrev.com/4c48422d79696901578dd987aee50ee8dbe87e2e/ui/file_manager/file_manager/foreground/elements/files_safe_audio_webview_content.css
[modify] https://crrev.com/4c48422d79696901578dd987aee50ee8dbe87e2e/ui/file_manager/file_manager/foreground/elements/files_safe_audio_webview_content.html
[modify] https://crrev.com/4c48422d79696901578dd987aee50ee8dbe87e2e/ui/file_manager/file_manager/foreground/elements/files_safe_media.js
[modify] https://crrev.com/4c48422d79696901578dd987aee50ee8dbe87e2e/ui/file_manager/file_manager/foreground/elements/files_safe_video_webview_content.css
[modify] https://crrev.com/4c48422d79696901578dd987aee50ee8dbe87e2e/ui/file_manager/file_manager/foreground/elements/files_safe_video_webview_content.html
[modify] https://crrev.com/4c48422d79696901578dd987aee50ee8dbe87e2e/ui/file_manager/file_manager/main.html

Status: Fixed (was: Assigned)

Sign in to add a comment