New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801502 link

Starred by 1 user
Status: Verified
Owner:
calamity@chromium.org
Closed: Feb 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Separator line doesn't appear properly after dragging any bookmarked url.

Reported by vku...@etouch.net, Jan 12 2018 
Chrome Version:65.0.3319.0 (Official Build) Revision f3766ff295fe4f687e4c79aa91afc04fbd7690f6-refs/heads/master@{#528844} (32/64-bit)
OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS).

What steps will reproduce the problem?
(1)Launch chrome and bookmark any 2 webpages.
(2)Navigate to chrome://bookmarks/ drag any bookmarked url and observe the separator line.

Actual: Separator line doesn't appear properly after dragging any bookmarked url.

Expected: Separator line should be properly seen after dragging any bookmarked url.

This is a regression issue broken in 'M65' and will soon provide bisect info.
Good build: 65.0.3316.0 (Revision: 527862).
Bad build: 65.0.3317.0 (Revision: 528119).
Actual_Bookmark.png
69.7 KB View Download
Expected_Bookmark.png
56.6 KB View Download

Comment 1 by vku...@etouch.net, Jan 12 2018

Labels: hasbisect-per-revision
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 527884 (known good), but no later than 527885 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/0ee74566b29f0984a1fc59b8c2e90a9d02d38839..07131e1caad858f9037fadc83a45a1894170d095

Suspecting: https://chromium.googlesource.com/chromium/src/+/07131e1caad858f9037fadc83a45a1894170d095
@calamity: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by ranjitkan@chromium.org, Jan 12 2018

Labels: RegressedIn-65 Target-65 FoundIn-65
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22581325a92a6af97051810e398e51209dff4e5f

commit 22581325a92a6af97051810e398e51209dff4e5f
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Jan 24 03:48:10 2018

[MD Bookmarks] Fix overflow issues.

This CL fixes an issue where drag indicators were truncated, and where
the empty bookmark list help text was wrapping.

Bug:  801502 ,  801488 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1d5c7d72c926eb6b067f6270afa4e706f3313e21
Reviewed-on: https://chromium-review.googlesource.com/877982
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531419}
[modify] https://crrev.com/22581325a92a6af97051810e398e51209dff4e5f/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/22581325a92a6af97051810e398e51209dff4e5f/chrome/browser/resources/md_bookmarks/list.html

Comment 4 by vku...@etouch.net, Jan 25 2018

Labels: TE-Verified-66.0.3331.0 TE-Verified-M66
Update : 
Verified this issue on Windows (7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.13.3) & Linux (14.04 LTS) OS with build #66.0.3331.0(Official Build) and the issue is fixed.  Kindly review an attached screen cast.

Thank you!
Actual_Bookmark.mp4
415 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 29 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57363270aa8edfc87dec1bbdcdc1ef44347aa29e

commit 57363270aa8edfc87dec1bbdcdc1ef44347aa29e
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Jan 29 04:24:55 2018

[MD Bookmarks] Fix overflow issues.

This CL fixes an issue where drag indicators were truncated, and where
the empty bookmark list help text was wrapping.

Bug:  801502 ,  801488 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1d5c7d72c926eb6b067f6270afa4e706f3313e21
Reviewed-on: https://chromium-review.googlesource.com/877982
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531419}(cherry picked from commit 22581325a92a6af97051810e398e51209dff4e5f)
Reviewed-on: https://chromium-review.googlesource.com/890839
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#131}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/57363270aa8edfc87dec1bbdcdc1ef44347aa29e/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/57363270aa8edfc87dec1bbdcdc1ef44347aa29e/chrome/browser/resources/md_bookmarks/list.html

Comment 6 by vku...@etouch.net, Jan 30 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3325.31
Update : 
Verified this issue on Windows (7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.13.3) & Linux (14.04 LTS) OS with build #65.0.3325.31(Official Build) and the issue is fixed.  Kindly review an attached screen cast.

Thank you!
Actual_Result.mp4
263 KB View Download

Comment 7 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported

Comment 8 by calamity@chromium.org, Feb 7 2018

Status: Verified (was: Assigned)
►

Sign in to add a comment