Regression: Unnecessary second chrome://settings tab opens when navigated through Incognito Window.
Reported by
aiman.an...@etouch.net,
Jan 12 2018
|
|||||||||
Issue descriptionChrome Version: 65.0.3319.0 (Official Build) Revision f3766ff295fe4f687e4c79aa91afc04fbd7690f6-refs/heads/master@{#528844} (32/64-bit) OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS). What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://settings. 2. Go to Incognito Window and navigate to chrome://settings. 3. Observe. Actual: Unnecessary second chrome://settings tab opens when navigated through Incognito Window. Expected: Unnecessary second chrome://settings tab should not open when navigated through Incognito Window. This is a regression issue, broken in M-65 series, Using the per-revision bisect providing the bisect results, Good Build:65.0.3312.0(Revision:527164) Bad Build:65.0.3313.0(Revision:527467) You are probably looking for a change made after 527378 (known good), but no later than 527379 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/309c9cc01e455c17539b9b31b09ed43a4ef3297b..c8f9ef323c67d6207df5ec0383503653a41ee113 Suspect: https://chromium.googlesource.com/chromium/src/+/c8f9ef323c67d6207df5ec0383503653a41ee113 krb@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: This issue is also seen on M65 Dev(build #65.0.3315.3) and M65 Canary (build #65.0.3319.0)
,
Jan 12 2018
Peter, What's happening is that, since the existing chrome://settings is in a different anonymity level, we ignore it while searching. Then we obviously open a new one. This is the new behavior that we want, right? Otherwise, I could trivially ignore the anonymity issue for SINGLETON_TAB.
,
Jan 18 2018
pkasting@ Gentle ping! This issue is marked as RB-Stable for M65, could you please respond for comment #2? Thanks!
,
Jan 18 2018
Hi BK, We're working on a fix in https://chromium-review.googlesource.com/c/chromium/src/+/867932
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc51d227d7879a44b0b5fabba7be1b58db1f1375 commit bc51d227d7879a44b0b5fabba7be1b58db1f1375 Author: Kevin Bailey <krb@chromium.org> Date: Tue Jan 23 00:58:54 2018 [omnibox navigation] Allow incognito switching for singletons We tried aligning the behaviors of disposition (old) SINGLETON_TAB and (new) SWITCH_TO_TAB. But the former supports e.g. opening chrome://settings from incognito mode, which requires searching across anonymity boundaries (if we don't want to open a duplicate). This change allows the former disposition to search across anonymity levels. Bug: 801494 Change-Id: I37d96e1de6f5f7c997858ac296a2756ae69769da Reviewed-on: https://chromium-review.googlesource.com/867932 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531098} [modify] https://crrev.com/bc51d227d7879a44b0b5fabba7be1b58db1f1375/chrome/browser/ui/browser_navigator.cc [modify] https://crrev.com/bc51d227d7879a44b0b5fabba7be1b58db1f1375/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/bc51d227d7879a44b0b5fabba7be1b58db1f1375/chrome/browser/ui/browser_navigator_browsertest.h
,
Jan 23 2018
,
Jan 23 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 23 2018
How is this change looking in canary? If it looks good, pls request a merge to M65.
,
Jan 23 2018
Verified the fix on latest Chrome canary i.e., 66.0.3329.1 on Windows, Mac and Linux.
,
Jan 23 2018
Approving merge to M65 branch 3325 based on comment #9. Please merge ASAP. Thank you.
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/738fb8f0a3f4c5b0c3eb991ee4cdc41382e0c6da commit 738fb8f0a3f4c5b0c3eb991ee4cdc41382e0c6da Author: Kevin Bailey <krb@chromium.org> Date: Tue Jan 23 19:13:42 2018 Merging bugfix to M65 per request in crbug/801494 [omnibox navigation] Allow incognito switching for singletons We tried aligning the behaviors of disposition (old) SINGLETON_TAB and (new) SWITCH_TO_TAB. But the former supports e.g. opening chrome://settings from incognito mode, which requires searching across anonymity boundaries (if we don't want to open a duplicate). This change allows the former disposition to search across anonymity levels. TBR=krb@chromium.org (cherry picked from commit bc51d227d7879a44b0b5fabba7be1b58db1f1375) Bug: 801494 Change-Id: I37d96e1de6f5f7c997858ac296a2756ae69769da Reviewed-on: https://chromium-review.googlesource.com/867932 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531098} Reviewed-on: https://chromium-review.googlesource.com/881823 Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#35} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/738fb8f0a3f4c5b0c3eb991ee4cdc41382e0c6da/chrome/browser/ui/browser_navigator.cc [modify] https://crrev.com/738fb8f0a3f4c5b0c3eb991ee4cdc41382e0c6da/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/738fb8f0a3f4c5b0c3eb991ee4cdc41382e0c6da/chrome/browser/ui/browser_navigator_browsertest.h
,
Feb 2 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ranjitkan@chromium.org
, Jan 12 2018