New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801488 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Text on bookmark page is seen chopped after resizing browser window.

Reported by db...@etouch.net, Jan 12 2018

Issue description

Chrome Version: 65.0.3319.0 Revision f3766ff295fe4f687e4c79aa91afc04fbd7690f6-refs/heads/master@{#528844}(32/64 bit)
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://bookmarks page.
(2) Resize the browser window and observe text.

Actual: Text on bookmark page is seen chopped after resizing browser.

Expected: Text on bookmark page should not chop after resizing browser.

This is regression issue, broken in ‘M 65’ and below is bisect info :

Good build: 65.0.3316.0 (Revision: 527862).
Bad build: 65.0.3317.0 (Revision: 528119).

Using the per-revision bisect providing the bisect results

You are probably looking for a change made after 527884 (known good), but no later than 527885 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/0ee74566b29f0984a1fc59b8c2e90a9d02d38839..07131e1caad858f9037fadc83a45a1894170d095

Suspect : https://chromium.googlesource.com/chromium/src/+/07131e1caad858f9037fadc83a45a1894170d095

@calamity- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is not seen on Mac(10.12.6,10.13.1,10.13.3) and Linux(14.04 LTS) OS.
 
Actual_Bookmarks.mp4
286 KB View Download
Expected_Bookmarks.mp4
377 KB View Download
Labels: RegressedIn-65 Target-65 FoundIn-65
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22581325a92a6af97051810e398e51209dff4e5f

commit 22581325a92a6af97051810e398e51209dff4e5f
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Jan 24 03:48:10 2018

[MD Bookmarks] Fix overflow issues.

This CL fixes an issue where drag indicators were truncated, and where
the empty bookmark list help text was wrapping.

Bug:  801502 ,  801488 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1d5c7d72c926eb6b067f6270afa4e706f3313e21
Reviewed-on: https://chromium-review.googlesource.com/877982
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531419}
[modify] https://crrev.com/22581325a92a6af97051810e398e51209dff4e5f/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/22581325a92a6af97051810e398e51209dff4e5f/chrome/browser/resources/md_bookmarks/list.html

Labels: Merge-Request-65 OS-Chrome OS-Linux OS-Mac

Comment 4 by db...@etouch.net, Jan 25 2018

Labels: TE-Verified-66.0.3331.0 TE-Verified-M66
Just to Update:

Rechecked above issue using latest Canary Build #66.0.3331.0 on Windows (7,8,8.1,10) and it seems to be fixed and working as intended.

Kindly review attached screencast.



Actual_Fix.mp4
346 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 26 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Jan 26 2018

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 29 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57363270aa8edfc87dec1bbdcdc1ef44347aa29e

commit 57363270aa8edfc87dec1bbdcdc1ef44347aa29e
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Jan 29 04:24:55 2018

[MD Bookmarks] Fix overflow issues.

This CL fixes an issue where drag indicators were truncated, and where
the empty bookmark list help text was wrapping.

Bug:  801502 ,  801488 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1d5c7d72c926eb6b067f6270afa4e706f3313e21
Reviewed-on: https://chromium-review.googlesource.com/877982
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531419}(cherry picked from commit 22581325a92a6af97051810e398e51209dff4e5f)
Reviewed-on: https://chromium-review.googlesource.com/890839
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#131}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/57363270aa8edfc87dec1bbdcdc1ef44347aa29e/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/57363270aa8edfc87dec1bbdcdc1ef44347aa29e/chrome/browser/resources/md_bookmarks/list.html

Comment 8 by db...@etouch.net, Jan 30 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3325.31
Just to Update:

Rechecked above issue using latest Dev Build #65.0.3325.31 on Windows (7,8,8.1,10) and it seems to be fixed and working as intended.

Kindly review attached screencast.
Fix_Bookmarks.mp4
307 KB View Download
Labels: ET-MUM-Reported
Status: Verified (was: Assigned)

Sign in to add a comment