New issue
Advanced search Search tips

Issue 801478 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

Run the layout tests under site-per-process on Linux debug

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 12 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fhorschig@google.com


Currently, the WebKit LayoutTests are failing reliably on chromium.linux/Linux Tests (dbg)(1).
The log indicates that chrome wasn't built correctly - otherwise content_shell would be available.

e.g. Log in this build:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/69578

[...]
19:57:39.873 29832 Checking build ...
19:57:39.874 29832 Unable to find test driver
19:57:39.874 29832     at /b/s/w/ir/out/Release/content_shell
19:57:39.874 29832 For complete Linux build requirements, please see:
19:57:39.874 29832 
19:57:39.875 29832     https://chromium.googlesource.com/chromium/src/+/master/docs/linux_build_instructions.md
19:57:39.875 29832 Build check failed
[...]

Other builds:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/69579
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/69580
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/69581
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/69582

Failure name: site_per_process_webkit_layout_tests failing on chromium.linux/Linux Tests (dbg)(1)

Builders failed on: 
- Linux Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29

 
Cc: dpranke@chromium.org jbudorick@chromium.org
+dpranke, jbudorick

https://chromium-review.googlesource.com/c/chromium/src/+/863163 seems to be the guilty CL.

Looking at the public logs, the bot is extracting things into out/Debug but site_per_process_webkit_layout_tests is trying to run content_shell from out/Release.
Components: Infra>Client>Chrome
Labels: -Pri-1 -Sheriff-Chromium Pri-3
Thanks a lot! So it's related to  issue 786554 . Reverting that CL for now.
Owner: jbudorick@chromium.org
Status: Started (was: Available)
Relanding a fixed version in https://chromium-review.googlesource.com/c/chromium/src/+/864622
Summary: Run the layout tests under site-per-process on Linux debug (was: Webkit LayoutTests unable to find/build the content_shell on chromium.linux/Linux Tests (dbg)(1))
I'm reverting #4 both because site-per-process layout tests have been problematic and because of possible load concerns.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fae58f0b01a3c5dba51a17ba68c6b65bb1ab681

commit 5fae58f0b01a3c5dba51a17ba68c6b65bb1ab681
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Jan 17 17:33:43 2018

Revert "Enable {site_per_process_,}webkit_layout_tests on chromium.linux:Linux Tests (dbg)(1)."

This reverts commit 906757f0b18f19bfe517d9b78cb8e36d760e1401.

Reason for revert: Failing frequently & imposing nontrivial load on the linux pool.

Original change's description:
> Enable {site_per_process_,}webkit_layout_tests on chromium.linux:Linux Tests (dbg)(1).
> 
> Bug: 801478
> Change-Id: Ibf9251d0f5a9d301154c3fa0d76aa2d136618498
> Reviewed-on: https://chromium-review.googlesource.com/864622
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529042}

TBR=dpranke@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 801478
Change-Id: I7ae54209b64869ffcf3f03efe59f3e9b1ab26b87
Reviewed-on: https://chromium-review.googlesource.com/868493
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529789}
[modify] https://crrev.com/5fae58f0b01a3c5dba51a17ba68c6b65bb1ab681/testing/buildbot/chromium.android.json
[modify] https://crrev.com/5fae58f0b01a3c5dba51a17ba68c6b65bb1ab681/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/5fae58f0b01a3c5dba51a17ba68c6b65bb1ab681/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/5fae58f0b01a3c5dba51a17ba68c6b65bb1ab681/testing/buildbot/generate_buildbot_json_unittest.py
[modify] https://crrev.com/5fae58f0b01a3c5dba51a17ba68c6b65bb1ab681/testing/buildbot/test_suite_exceptions.pyl

Sign in to add a comment