Related issue: crbug.com/786332
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7d8259df9b28da303535314e5094963c7a59e5a commit c7d8259df9b28da303535314e5094963c7a59e5a Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Jan 15 08:55:53 2018 Remove WebScheduler::LoadingTaskRunner() In ResourceLoader.cpp, WebScheduler::LoadingTaskRunner() is used to make sure all the posted tasks are executed even after the frame is gone, but now it is assured posted tasks are executed correctly before the task runner is destroyed, LoadingTaskRunner() is no longer needed. This is part of efforts to replace thread-local task runners with other appropriate per-frame task runners in the renderer. Bug: 801476 Change-Id: If0a0ee06694cf6a5d7d4447824d4e236cb8dd85d Reviewed-on: https://chromium-review.googlesource.com/863844 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#529229} [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskControllerTest.cpp [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.cpp [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/core/scheduler/VirtualTimeTest.cpp [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/platform/loader/fetch/RawResourceTest.cpp [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/Source/platform/scheduler/test/renderer_scheduler_test_support.cc [modify] https://crrev.com/c7d8259df9b28da303535314e5094963c7a59e5a/third_party/WebKit/public/platform/scheduler/test/renderer_scheduler_test_support.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab2cec296d8740329b36e5cd2ea626e8e7abc6f0 commit ab2cec296d8740329b36e5cd2ea626e8e7abc6f0 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Jan 16 12:03:07 2018 Remove ResourceDispatcher::thread_task_runner_ usage at StartAsync |ResourceDispatcher::thread_task_runner_| is the only one user of |RenderScheduler::LoadingTaskRunner()|, and this CL is one of steps to remove RenderScheduler::LoadingTaskRunner(). This is part of efforts to replace thread-local task runners with other appropriate per-frame task runners in the renderer. Bug: 801476 Change-Id: I1895141615379e9e9878f041324b9a8c2ab0e98f Reviewed-on: https://chromium-review.googlesource.com/866620 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#529404} [modify] https://crrev.com/ab2cec296d8740329b36e5cd2ea626e8e7abc6f0/content/renderer/loader/resource_dispatcher.cc [modify] https://crrev.com/ab2cec296d8740329b36e5cd2ea626e8e7abc6f0/content/renderer/loader/resource_dispatcher.h [modify] https://crrev.com/ab2cec296d8740329b36e5cd2ea626e8e7abc6f0/content/renderer/loader/resource_dispatcher_unittest.cc [modify] https://crrev.com/ab2cec296d8740329b36e5cd2ea626e8e7abc6f0/content/renderer/loader/sync_load_context.cc [modify] https://crrev.com/ab2cec296d8740329b36e5cd2ea626e8e7abc6f0/content/renderer/loader/sync_load_context.h [modify] https://crrev.com/ab2cec296d8740329b36e5cd2ea626e8e7abc6f0/content/renderer/loader/url_loader_client_impl_unittest.cc [modify] https://crrev.com/ab2cec296d8740329b36e5cd2ea626e8e7abc6f0/content/renderer/loader/url_response_body_consumer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d6642b04a6a000c30331ae92232df7cc8e8d476 commit 5d6642b04a6a000c30331ae92232df7cc8e8d476 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Jan 18 07:36:29 2018 Remove |thread_task_runner_| usage in ResourceDispatcher::RemovePendingRequest This is part of efforts to replace non-per-frame task runners with other appropriate per-frame task runners in the renderer. Bug: 801476 Change-Id: I12ef9e71a6b0fc3ff418a05f0a65da86f1dd8ab1 Reviewed-on: https://chromium-review.googlesource.com/870010 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#530085} [modify] https://crrev.com/5d6642b04a6a000c30331ae92232df7cc8e8d476/content/renderer/loader/resource_dispatcher.cc [modify] https://crrev.com/5d6642b04a6a000c30331ae92232df7cc8e8d476/content/renderer/loader/resource_dispatcher.h [modify] https://crrev.com/5d6642b04a6a000c30331ae92232df7cc8e8d476/content/renderer/loader/sync_load_context.cc [modify] https://crrev.com/5d6642b04a6a000c30331ae92232df7cc8e8d476/content/renderer/loader/sync_load_context.h [modify] https://crrev.com/5d6642b04a6a000c30331ae92232df7cc8e8d476/content/renderer/loader/test_request_peer.cc [modify] https://crrev.com/5d6642b04a6a000c30331ae92232df7cc8e8d476/content/renderer/loader/url_loader_client_impl.cc [modify] https://crrev.com/5d6642b04a6a000c30331ae92232df7cc8e8d476/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/5d6642b04a6a000c30331ae92232df7cc8e8d476/content/renderer/loader/web_url_loader_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1711b5278c88f89c7332a14bb65109e3c95dbaca commit 1711b5278c88f89c7332a14bb65109e3c95dbaca Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Jan 19 10:29:20 2018 Remove RendererScheduler::LoadingTaskRunner() There was only one usage of RendererScheduler::LoadingTaskRunner() and now it was removed (https://chromium-review.googlesource.com/c/chromium/src/+/866620 and https://chromium-review.googlesource.com/c/chromium/src/+/870010). This CL removes RendererScheduler::LoadingTaskRunner(). This is part of efforts to replace thread-local task runners with other appropriate per-frame task runners in the renderer. Bug: 801476 Change-Id: If0ca8962f2367688f87619a10463c2b7475d6b35 Reviewed-on: https://chromium-review.googlesource.com/868110 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#530473} [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/loader/resource_dispatcher.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/loader/resource_dispatcher.h [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/loader/resource_dispatcher_unittest.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/loader/sync_load_context.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/loader/url_loader_client_impl_unittest.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/loader/url_response_body_consumer_unittest.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/loader/web_url_loader_impl_unittest.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/render_thread_impl.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/service_worker/service_worker_fetch_context_impl.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/service_worker/service_worker_fetch_context_impl.h [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/content/renderer/service_worker/worker_fetch_context_impl.h [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/third_party/WebKit/Source/platform/scheduler/test/fake_renderer_scheduler.cc [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/third_party/WebKit/public/platform/WebWorkerFetchContext.h [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h [modify] https://crrev.com/1711b5278c88f89c7332a14bb65109e3c95dbaca/third_party/WebKit/public/platform/scheduler/test/fake_renderer_scheduler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a53a02d89c934a04638c6520337c574f0d12b85 commit 1a53a02d89c934a04638c6520337c574f0d12b85 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Jan 19 13:05:34 2018 Remove RendererSchedulerImpl::LoadingTaskQueue This is part of efforts to replace thread-local task runners with other appropriate per-frame task runners in the renderer. Bug: 801476 Change-Id: I744b7e72ae3f6bbeacaf0dbda6eb32affb7a3c05 Reviewed-on: https://chromium-review.googlesource.com/875582 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530496} [modify] https://crrev.com/1a53a02d89c934a04638c6520337c574f0d12b85/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.cc [modify] https://crrev.com/1a53a02d89c934a04638c6520337c574f0d12b85/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.h [modify] https://crrev.com/1a53a02d89c934a04638c6520337c574f0d12b85/third_party/WebKit/Source/platform/scheduler/renderer/queueing_time_estimator.cc [modify] https://crrev.com/1a53a02d89c934a04638c6520337c574f0d12b85/third_party/WebKit/Source/platform/scheduler/renderer/queueing_time_estimator_unittest.cc [modify] https://crrev.com/1a53a02d89c934a04638c6520337c574f0d12b85/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc [modify] https://crrev.com/1a53a02d89c934a04638c6520337c574f0d12b85/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/1a53a02d89c934a04638c6520337c574f0d12b85/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h [modify] https://crrev.com/1a53a02d89c934a04638c6520337c574f0d12b85/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Jan 15 2018