Enrolled devices cannot update over cellular |
||||||||||||
Issue descriptionSee crbug.com/698877 for more details, but in a nutshell, if there's no "allowed_connection_types_for_update" attribute in the policy proto, then we should probably *remove* the kAllowedConnectionTypesForUpdate field in device settings rather than setting it to an empty list.
,
Jan 16 2018
,
Jan 16 2018
antrim@ this feature is shipping in M64 for Q1. Can you please share any updates on this investigation?
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b80d12bed59b5fc98d9ef73afe9f53bf6a5b9816 commit b80d12bed59b5fc98d9ef73afe9f53bf6a5b9816 Author: Denis Kuznetsov <antrim@google.com> Date: Thu Jan 18 13:29:48 2018 Fix update allowed networks for enrolled devices. When no allowed_connection_types_for_update is set do not set kAllowedConnectionTypesForUpdate to empty list. Bug: 801469 Change-Id: Ib60386f2832f6c3912c532b089cd33e65be32cde Reviewed-on: https://chromium-review.googlesource.com/868021 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#530130} [modify] https://crrev.com/b80d12bed59b5fc98d9ef73afe9f53bf6a5b9816/chrome/browser/chromeos/settings/device_settings_provider.cc [modify] https://crrev.com/b80d12bed59b5fc98d9ef73afe9f53bf6a5b9816/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
,
Jan 18 2018
Please, note that the fix is merged into M65. M64 is already at stable cut date.
,
Jan 18 2018
If this only impacts cellular devices (few users) and it appears to be a straight forward change, we can probably still put this into 64 if we can verify on a canary build.
,
Jan 19 2018
dsunkara@ can you please validate this bug on a canary build and confirm that it works here?
,
Jan 19 2018
,
Jan 19 2018
+kathrelkeld to review this bug and verify if possible.
,
Jan 19 2018
,
Jan 20 2018
verified on M-65 (65 - 10323.0.0 - 65.0.3325.0). There is no visible change to the policy. Before this CL "DeviceUpdateAllowedConnectionTypes" Policy Value is "Empty" and status is "Not Set" and with CL the entries/values remains same. However, functionality is implemented. With CL on canary, system is able to check for updates over cellular. There is no setting to control this in cPanel yet. On UI (as attached), message is yet to be modified to include auto updates over cellular. I see that auto update request is being processed with these changes. [0119/161945:INFO:common_service.cc(79)] Attempt update: app_version="" omaha_url="" flags=0x0 interactive=yes [0119/161945:INFO:update_attempter.cc(768)] Forced update check requested. [0119/161945:INFO:update_attempter.cc(1538)] Non-official build; allowing any update source. [0119/161945:INFO:update_manager-inl.h(52)] ChromeOSPolicy::UpdateCheckAllowed: START [0119/161945:INFO:chromeos_policy.cc(280)] Forced update signaled (interactive), allowing update check. [0119/161945:INFO:update_manager-inl.h(74)] ChromeOSPolicy::UpdateCheckAllowed: END [0119/161945:INFO:update_attempter.cc(842)] Running interactive update. [0119/161945:INFO:update_attempter.cc(196)] Last reported daily metrics 1h18m51.315072s ago. [0119/161945:INFO:update_attempter.cc(312)] Device policies/settings present [0119/161945:INFO:update_attempter.cc(463)] Scattering disabled since scatter factor is set to 0 [0119/161945:INFO:update_attempter.cc(341)] Forcibly disabling use of p2p for downloading since this update attempt is interactive. [0119/161945:INFO:payload_state.cc(534)] Current download source: Unknown [0119/161945:INFO:update_attempter.cc(1483)] Ensuring that p2p is running. [0119/161945:INFO:update_attempter.cc(1489)] Performing p2p housekeeping. [0119/161945:INFO:update_attempter.cc(1495)] Done performing p2p housekeeping. [0119/161945:INFO:omaha_request_params.cc(66)] Initializing parameters for this update attempt [0119/161945:INFO:omaha_request_params.cc(77)] Running from channel stable-channel [0119/161945:INFO:update_attempter.cc(391)] No target channel mandated by policy. [0119/161945:INFO:update_attempter.cc(410)] target_version_prefix = , scatter_factor_in_seconds = 0s [0119/161945:INFO:update_attempter.cc(415)] Wall Clock Based Wait Enabled = 0, Update Check Count Wait Enabled = 0, Waiting Period = 0s [0119/161945:INFO:update_attempter.cc(422)] Use p2p For Downloading = 0, Use p2p For Sharing = 1 [0119/161945:INFO:update_attempter.cc(440)] To help ensure updates work, this update check we are ignoring the proxy settings and using direct connections. [0119/161945:INFO:update_attempter.cc(1149)] Already updated boot flags. Skipping. [0119/161945:INFO:update_attempter.cc(1298)] Scheduling an action processor start. [0119/161945:INFO:action_processor.cc(46)] ActionProcessor: starting OmahaRequestAction [0119/161945:INFO:omaha_request_action.cc(680)] Posting an Omaha request to https://tools.google.com/service/update2 [0119/161945:INFO:omaha_request_action.cc(681)] Request: <?xml version="1.0" encoding="UTF-8"?> <request protocol="3.0" version="ChromeOSUpdateEngine-0.1.0.0" updaterversion="ChromeOSUpdateEngine-0.1.0.0" installsource="ondemandupdate" ismachine="1"> <os version="Indy" platform="Chrome OS" sp="10323.0.0_x86_64"></os> <app appid="{5A3AB642-2A67-470A-8F37-37E737A53CFC}" version="10323.0.0" track="stable-channel" lang="en-US" board="coral" hardware_class="ASTRONAUT C3C-A3E-A3K-J6L-Q8F" delta_okay="true" fw_version="" ec_version="" installdate="4032" > <updatecheck targetversionprefix=""></updatecheck> </app> </request> [0119/161945:INFO:libcurl_http_fetcher.cc(146)] Starting/Resuming transfer [0119/161945:INFO:libcurl_http_fetcher.cc(165)] Using proxy: no [0119/161945:INFO:libcurl_http_fetcher.cc(286)] Not setting http(s) curl options because we are running a dev/test image [0119/161945:INFO:libcurl_http_fetcher.cc(433)] HTTP response code: 200 [0119/161945:INFO:libcurl_http_fetcher.cc(509)] Transfer completed (200), 269 bytes downloaded [0119/161945:INFO:omaha_request_action.cc(940)] Omaha request response: <?xml version="1.0" encoding="UTF-8"?><response protocol="3.0" server="prod"><daystart elapsed_days="4036" elapsed_seconds="58786"/><app appid="{5A3AB642-2A67-470A-8F37-37E737A53CFC}" cohort="" cohortname="" status="ok"><updatecheck status="noupdate"/></app></response> [0119/161945:INFO:omaha_request_action.cc(813)] No update. [0119/161945:INFO:metrics.cc(142)] Sending 1 for metric UpdateEngine.Check.Result (enum) [0119/161945:INFO:metrics.cc(165)] Sending 12m23.162695s for metric UpdateEngine.Check.TimeSinceLastCheckMinutes [0119/161945:INFO:metrics.cc(181)] Sending 12m23.161797s for metric UpdateEngine.Check.TimeSinceLastCheckUptimeMinutes [0119/161945:INFO:action_processor.cc(116)] ActionProcessor: finished OmahaRequestAction with code ErrorCode::kSuccess [0119/161945:INFO:action_processor.cc(143)] ActionProcessor: starting OmahaResponseHandlerAction [0119/161945:INFO:omaha_response_handler_action.cc(56)] There are no updates. Aborting. [0119/161945:INFO:action_processor.cc(116)] ActionProcessor: finished OmahaResponseHandlerAction with code ErrorCode::kError [0119/161945:INFO:action_processor.cc(121)] ActionProcessor: Aborting processing due to failure. [0119/161945:INFO:update_attempter.cc(873)] Processing Done. [0119/161945:INFO:update_attempter.cc(947)] No update. [0119/161945:INFO:update_manager-inl.h(52)] ChromeOSPolicy::UpdateCheckAllowed: START [0119/161945:INFO:chromeos_policy.cc(294)] Unofficial build, blocking periodic update checks. [0119/161945:INFO:update_manager-inl.h(74)] ChromeOSPolicy::UpdateCheckAllowed: END
,
Jan 22 2018
Thanks for confirming dsunkara@. antrim@ can we please merge this to M64 as Bernie suggested above? abodenha@, weidongg@ Now that auto updates are allowed over cellular should we remove/modify the string that says autoupdates are allowed over ethernet and wifi only?
,
Jan 22 2018
Approved for 64. Re comment 12, this is only approving https://chromium-review.googlesource.com/#/c/chromium/src/+/868021/ no string changes in 64 at this point.
,
Jan 22 2018
thanks Bernie. antrim@ please merge to M64 soonest possible.
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99fee4b3ffadf05e87ff2ababee9af6530b6b678 commit 99fee4b3ffadf05e87ff2ababee9af6530b6b678 Author: Denis Kuznetsov <antrim@google.com> Date: Mon Jan 22 21:07:52 2018 Fix update allowed networks for enrolled devices. When no allowed_connection_types_for_update is set do not set kAllowedConnectionTypesForUpdate to empty list. TBR: antrim@chromium.org Bug: 801469 Change-Id: Ib60386f2832f6c3912c532b089cd33e65be32cde Reviewed-on: https://chromium-review.googlesource.com/868021 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530130} Reviewed-on: https://chromium-review.googlesource.com/878862 Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#571} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/99fee4b3ffadf05e87ff2ababee9af6530b6b678/chrome/browser/chromeos/settings/device_settings_provider.cc [modify] https://crrev.com/99fee4b3ffadf05e87ff2ababee9af6530b6b678/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
,
Jan 25 2018
,
Feb 5 2018
,
Feb 9 2018
Verified this defect on Chrome OS-10176.69.0, 64.0.3282.157, DUT - Link. Autoupdates request is successful over cellular network, logs snapshot below. However, 1)The download is not successful due to this defect crbug.com/796692. 2) UI still shows updates are not possible over mobile network, screenshot attached. Logs snapshot: 0209/122031:INFO:action_processor.cc(116)] ActionProcessor: finished OmahaRequestAction with code ErrorCode::kSuccess [0209/122031:INFO:action_processor.cc(143)] ActionProcessor: starting DownloadAction [0209/122031:INFO:install_plan.cc(71)] InstallPlan: new_update, payload type: full, source_slot: A, target_slot: B, url: http://dl.google.com/chromeos/link/10323.21.0/dev-channel/chromeos_10323.21.0_link_dev-channel_full_mp-v5.bin-656f6706ae7fcbc80d94afb156bc7ed0.signed, payload size: 540794125, payload hash: hLb0LtxLDR+9BmKhyNvuz5wVP9DZBpia/7YDZW6J/pY=, metadata size: 35627, metadata signature: z0yYMYLr8pFgPUpotkGSEWIS1MANYLK3x8xN3+qyaYoqV9mGeTIeJmSWyjc/Js58zWwYRNXEMAxZEl+x7n3cpsbzB0vxx6RM8AXZiD6UTVF5eyHVrKWIVFc71rbdE47pYla3r6EuRAC1o29k0/iRoevyKjJY5al7krUhHibC5HnmFr2AGmJfwbF7RYISlBV9EAebmGAzyjOQ1st731v0n/wUblCTjM69Bpt1I+Er+nnesGUXrysYuXwY8DKQnEGt9kH8vk+IPuzVjGAXiM0cD4mSCD4dP20MCi3WnjC2rbgXoJ1jQxos7zwQy6DAdwv7uq0UdMf5cMYSdMAS1U7TDQ==, hash_checks_mandatory: true, powerwash_required: false [0209/122031:INFO:download_action.cc(181)] Marking new slot as unbootable [0209/122031:INFO:boot_control_chromeos.cc(174)] Marking slot B unbootable [0209/122031:INFO:download_action.cc(209)] p2p file id: cros_update_size_540794125_hash_aExiMEx0eExEUis5Qm1LaHlOdnV6NXdWUDlEWkJwaWEvN1lEWlc2Si9wWT0= [0209/122031:INFO:multi_range_http_fetcher.cc(45)] starting first transfer [0209/122031:INFO:multi_range_http_fetcher.cc(74)] starting transfer of range 0+? [0209/122031:INFO:libcurl_http_fetcher.cc(146)] Starting/Resuming transfer [0209/122031:INFO:libcurl_http_fetcher.cc(165)] Using proxy: no [0209/122031:INFO:libcurl_http_fetcher.cc(296)] Setting up curl options for HTTP [0209/122031:INFO:download_action.cc(117)] Writing payload contents to /var/cache/p2p/cros_update_size_540794125_hash_aExiMEx0eExEUis5Qm1LaHlOdnV6NXdWUDlEWkJwaWEvN1lEWlc2Si9wWT0=.cros_au.p2p.tmp [0209/122031:INFO:delta_performer.cc(217)] Completed 0/? operations, 2394/540794125 bytes downloaded (0%), overall progress 0% [0209/122031:INFO:delta_performer.cc(565)] Manifest size in payload matches expected value from Omaha [0209/122031:INFO:delta_performer.cc(1462)] Verifying metadata hash signature using public key: /usr/share/update_engine/update-payload-key.p[0209/122218:INFO:libcurl_http_fetcher.cc(433)] HTTP response code: 200 [0209/122218:INFO:libcurl_http_fetcher.cc(490)] Transfer interrupted after downloading 1464768 of 540794125 bytes. 539329357 bytes remaining after 1 attempt(s) [0209/122218:INFO:libcurl_http_fetcher.cc(502)] Restarting transfer to download the remaining bytes [0209/122238:INFO:libcurl_http_fetcher.cc(146)] Starting/Resuming transfer [0209/122238:INFO:libcurl_http_fetcher.cc(165)] Using proxy: no [0209/122238:INFO:libcurl_http_fetcher.cc(296)] Setting up curl options for HTTP [0209/122408:INFO:libcurl_http_fetcher.cc(433)] HTTP response code: 206 [0209/122408:INFO:libcurl_http_fetcher.cc(490)] Transfer interrupted after downloading 1464768 of 540794125 bytes. 539329357 bytes remaining after 2 attempt(s) [0209/122408:INFO:libcurl_http_fetcher.cc(502)] Restarting transfer to download the remaining bytes [0209/122428:INFO:libcurl_http_fetcher.cc(146)] Starting/Resuming transfer [0209/122428:INFO:libcurl_http_fetcher.cc(165)] Using proxy: no [0209/122428:INFO:libcurl_http_fetcher.cc(296)] Setting up curl options for HTTP [0209/122558:INFO:libcurl_http_fetcher.cc(433)] HTTP response code: 206 [0209/122558:INFO:libcurl_http_fetcher.cc(490)] Transfer interrupted after downloading 1464768 of 540794125 bytes. 539329357 bytes remaining after 3 attempt(s) [0209/122558:INFO:libcurl_http_fetcher.cc(502)] Restarting transfer to download the remaining bytes [0209/122618:INFO:libcurl_http_fetcher.cc(146)] Starting/Resuming transfer [0209/122618:INFO:libcurl_http_fetcher.cc(165)] Using proxy: no [0209/122618:INFO:libcurl_http_fetcher.cc(296)] Setting up curl options for HTTP
,
Mar 2 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by atwilson@chromium.org
, Jan 12 2018