New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801457 link

Starred by 1 user
Status: Started
Owner:
█ tasak@chromium.org
Last visit > 30 days ago
Cc:
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

Add blink instance counter to chrome ukm memory.

Project Member Reported by tasak@google.com, Jan 12 2018 
To understand renderer memory usage, we need to add blink instance counters (reported by memory-infra) to chrome ukm log.

i.e.
- number of documents,
- number of frames,
- number of layout objects, and
- number of nodes
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c3ca7e826c6ecbc0a2b548111290f1f56478f03

commit 3c3ca7e826c6ecbc0a2b548111290f1f56478f03
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Mon Feb 05 12:50:01 2018

Add blink instance counters to Memory_Experimental ukm.

UKM Review: https://docs.google.com/document/d/1unr--8eYTTxkbrQNu_fezKWSazv5OWrNoohPpH9Xfto/edit?usp=sharing
Bug:801457

Change-Id: I9bb54b3a3ecddad19c46a729c66365406a6d08ff
Reviewed-on: https://chromium-review.googlesource.com/808445
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#534372}
[modify] https://crrev.com/3c3ca7e826c6ecbc0a2b548111290f1f56478f03/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/3c3ca7e826c6ecbc0a2b548111290f1f56478f03/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/3c3ca7e826c6ecbc0a2b548111290f1f56478f03/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/3c3ca7e826c6ecbc0a2b548111290f1f56478f03/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/3c3ca7e826c6ecbc0a2b548111290f1f56478f03/services/resource_coordinator/public/cpp/memory_instrumentation/global_memory_dump.cc
[modify] https://crrev.com/3c3ca7e826c6ecbc0a2b548111290f1f56478f03/services/resource_coordinator/public/cpp/memory_instrumentation/global_memory_dump.h
[modify] https://crrev.com/3c3ca7e826c6ecbc0a2b548111290f1f56478f03/tools/metrics/ukm/ukm.xml

Comment 2 by yitingc@chromium.org, Feb 9 2018 

Approved by privacy.

Comment 3 by holte@chromium.org, Apr 25 2018

Components: -Internals>Metrics>UKM
Labels: Hotlist-Metrics
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b2f1a5d42e392f387387623cbe6f03ccf38f656

commit 5b2f1a5d42e392f387387623cbe6f03ccf38f656
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Wed May 23 18:39:39 2018

Add number of ad subframes and number of detached ScriptStates to memory-infra and Memory_Experimental UKM.

To estimate how effectively OOM intervention works, we would like to see how many frames are ad-related and how many scriptstates are detached.

Bug: 801457
Change-Id: I48989451c8d4f503a060b21d87c9ddafdc35ebda
Reviewed-on: https://chromium-review.googlesource.com/1068554
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561175}
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-monitor-expected.txt
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics-expected.txt
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-push-metrics-expected.txt
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/third_party/blink/renderer/platform/bindings/script_state.cc
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/third_party/blink/renderer/platform/instance_counters.h
[modify] https://crrev.com/5b2f1a5d42e392f387387623cbe6f03ccf38f656/tools/metrics/ukm/ukm.xml

Comment 5 by tasak@google.com, Jul 20 

I would like to add more blink instance counters to Memory_Experimental UKM:
- number of ad subframes,
- number of detached script states,
- number of cross-origin subframes

Comment 6 by benhenry@chromium.org, Aug 2

Owner: tasak@chromium.org
►

Sign in to add a comment