New issue
Advanced search Search tips

Issue 801447 link

Starred by 1 user
Status: Fixed
Owner:
martis@chromium.org
Closed: Mar 2018
Cc:
yyushkina@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Clean up translate 2016q2 UI

Project Member Reported by napper@chromium.org, Jan 12 2018 
The translate 2016q2 UI is not launching and needs to be removed. See https://bugs.chromium.org/p/chromium/issues/detail?id=607170
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb60cc353806567bddfe27c2356445bebf98d9ad

commit fb60cc353806567bddfe27c2356445bebf98d9ad
Author: Michael Martis <martis@chromium.org>
Date: Thu Jan 18 05:28:50 2018

Clean up code from the concluded 2016Q2 translate UI experiment.

Bug:  801447 
Change-Id: Ia8e3beb735c4780b7e847f539bbb64c51745824e
Reviewed-on: https://chromium-review.googlesource.com/863224
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530060}
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/chrome/browser/about_flags.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/chrome/browser/ui/views/translate/translate_bubble_view.h
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/components/translate/core/browser/translate_prefs.h
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/components/translate/core/browser/translate_prefs_unittest.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/components/translate/core/browser/translate_ui_delegate.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/components/translate/core/browser/translate_ui_delegate_unittest.cc
[modify] https://crrev.com/fb60cc353806567bddfe27c2356445bebf98d9ad/testing/variations/fieldtrial_testing_config.json

Comment 2 by yyushkina@chromium.org, Mar 7 2018 

Michael - can I mark this as fixed?

Comment 3 by martis@chromium.org, Mar 7 2018 

Yep

Comment 4 by yyushkina@chromium.org, Mar 7 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment