New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801441 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

InputMethodControllerTest should inherit EditingTestBase

Project Member Reported by xiaoche...@chromium.org, Jan 12 2018

Issue description

InputMethodControllerTest performs a lot of selection manipulation and inspection, which can be much simplified with EditingTestBase's SelectionSample tools.
 
Owner: rlanday@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15af5c52502c2921a759b9a72dea76aa70bac14d

commit 15af5c52502c2921a759b9a72dea76aa70bac14d
Author: Ryan Landay <rlanday@chromium.org>
Date: Tue Jan 23 20:26:45 2018

Fix bug composing text with IME immediately after non-editable element

When an IME tries to set a composition immediately after a non-editable element
inside an editable region, it's possible for the selection base to get stuck
inside the non-editable region, in which case the attempt to replace the
selection fails. The fix is to pass the kCanSkipOverEditingBoundary flag when we
call MostForwardCaretPosition() on the selection base so we can find the actual
editable region.

Bug:  790777 , 801441 
Change-Id: I1014901742671f6fbb153c7117eaa1b271a265f7
Reviewed-on: https://chromium-review.googlesource.com/879839
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531330}
[modify] https://crrev.com/15af5c52502c2921a759b9a72dea76aa70bac14d/third_party/WebKit/Source/core/editing/ime/InputMethodController.cpp
[modify] https://crrev.com/15af5c52502c2921a759b9a72dea76aa70bac14d/third_party/WebKit/Source/core/editing/ime/InputMethodControllerTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment