InputMethodControllerTest should inherit EditingTestBase |
||
Issue descriptionInputMethodControllerTest performs a lot of selection manipulation and inspection, which can be much simplified with EditingTestBase's SelectionSample tools.
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15af5c52502c2921a759b9a72dea76aa70bac14d commit 15af5c52502c2921a759b9a72dea76aa70bac14d Author: Ryan Landay <rlanday@chromium.org> Date: Tue Jan 23 20:26:45 2018 Fix bug composing text with IME immediately after non-editable element When an IME tries to set a composition immediately after a non-editable element inside an editable region, it's possible for the selection base to get stuck inside the non-editable region, in which case the attempt to replace the selection fails. The fix is to pass the kCanSkipOverEditingBoundary flag when we call MostForwardCaretPosition() on the selection base so we can find the actual editable region. Bug: 790777 , 801441 Change-Id: I1014901742671f6fbb153c7117eaa1b271a265f7 Reviewed-on: https://chromium-review.googlesource.com/879839 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531330} [modify] https://crrev.com/15af5c52502c2921a759b9a72dea76aa70bac14d/third_party/WebKit/Source/core/editing/ime/InputMethodController.cpp [modify] https://crrev.com/15af5c52502c2921a759b9a72dea76aa70bac14d/third_party/WebKit/Source/core/editing/ime/InputMethodControllerTest.cpp
,
Jan 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rlanday@chromium.org
, Jan 23 2018Status: Started (was: Available)