New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801440 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
hiroh@chromium.org
█ pho...@chromium.org
█ jrbarnette@chromium.org
diand...@chromium.org
ahass...@chromium.org
hidehiko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

risk_report CL-Scanner client makes ReportStage fail

Project Member Reported by phobbs@google.com, Jan 12 2018 
19:49:59: ERROR: Traceback (most recent call last):
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/generic_stages.py", line 701, in Run
    self.PerformStage()
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/report_stages.py", line 1050, in PerformStage
    logging.PrintBuildbotStepText(risk_report.CLRiskText(build_id))
  File "/b/c/cbuild/repository/chromite/lib/risk_report.py", line 41, in CLRiskText
    top_risky = _TopRisky(risks)
  File "/b/c/cbuild/repository/chromite/lib/risk_report.py", line 71, in _TopRisky
    cl: risk for cl, risk in risks.iteritems()
  File "/b/c/cbuild/repository/chromite/lib/risk_report.py", line 72, in <dictcomp>
    if risk >= risks[top_key] * _CLOSE_TO_TOP_RATIO
TypeError: unsupported operand type(s) for *: 'dict' and 'float'

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/aba05030e1517b1845977f7d95254af0a0f9aac7

commit aba05030e1517b1845977f7d95254af0a0f9aac7
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Jan 12 11:27:22 2018

risk_report: Fix usage of CL-Scanner

CL-Scanner's API returns the CL risks as a dict under the "cls" key, e.g.

{
  "cls": {
    "832848": 0.0078341188169961957,
    "837702": 0.0062051953251566136
  }
}

Fix risk_report's usage of the API, and add a fallback for when the API returns nothing.

TEST=unit tests
BUG= chromium:801440 

Change-Id: Ib9448d12c3cfbfe4d58dff2e84b337221e64ad31
Reviewed-on: https://chromium-review.googlesource.com/863125
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/aba05030e1517b1845977f7d95254af0a0f9aac7/lib/risk_report.py

Comment 2 by pho...@chromium.org, Jan 12 2018

Cc: hiroh@chromium.org diand...@chromium.org ahass...@chromium.org pho...@chromium.org jrbarnette@chromium.org hidehiko@chromium.org
 Issue 801486  has been merged into this issue.

Comment 3 by pho...@chromium.org, Jan 12 2018

Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment