New issue
Advanced search Search tips

Issue 801426 link

Starred by 12 users
Status: Fixed
Owner:
caseq@chromium.org
Closed: Sep 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

DevTools: Network.continueInterceptedRequest doesn't work when security error occurs

Project Member Reported by lushnikov@chromium.org, Jan 12 2018 
Step-by-step:
1. Enable request interception in devtools protocol and enable security domain
  Security.enable()
  Network.enable()
  Network.setRequestInterception()

2. Navigate to a page with self-signed certificates
  page.navigate(<url>)

3. Respond to protocol events:
   - continue interception: Network.continueInterceptedRequest()
   - proceed with security error: Security.handleCertificateError()

4. Notice that navigation never completes and page is not loaded. Request is not continued.

Downstream pptr bug: https://github.com/GoogleChrome/puppeteer/issues/1159

Comment 1 by kman...@gmail.com, Feb 17 2018 

Any ETA on this at all? Thanks.

Comment 2 by mich...@searchviu.com, Feb 21 2018 

Yes ETA would be great / also if there is something we can do to speed up fixing this bug... Thanks!

Comment 3 by josh.har...@gmail.com, Feb 28 2018 

As a workaround for this issue we had to wrap our puppeteer tests in a XVFB so we could run headless:false. This way the cert errors are accepted. We would like to remove the XVFB wrapper because Chromium intermittenly fails to open. When running headless:true, Chromium is near perfectly consistent.

Comment 4 by mazah...@gmail.com, Mar 14 2018 

Is there any progress on this issue or any timeline when it can be fixed?

Comment 5 by da...@detectify.com, Jun 8 2018 

This bug is not limited to Mac, happens on Linux as well. 
Chrome version: Google Chrome 67.0.3396.79
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h

Comment 9 by lushnikov@chromium.org, Sep 3

Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 25 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 29 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 33 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 34 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 35 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 36 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 37 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 38 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 39 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 40 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 41 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 42 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 43 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 44 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 45 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 46 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 47 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 48 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 49 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 50 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 51 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 52 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 53 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 54 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 55 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 56 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 57 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 58 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 59 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 60 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 61 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 62 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 63 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 64 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 65 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 66 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 67 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 68 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 69 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 70 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 71 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 72 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 73 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 74 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 75 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 76 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h

Comment 77 by m...@louisroche.net, Sep 4 

Why do we receive 70 times the same email for the same commit?
Project Member

Comment 78 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 79 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
Project Member

Comment 80 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814

commit c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Mon Sep 03 18:03:16 2018

DevTools: teach request interception to work with Security.setIgnoreCertificateErrors

This is becoming very painful bug for puppeteer given that Chromium 70
distrusted symantec certificates. It already works with NetworkService
codepath; this patch adds the missing logic for non-network-service
world.

R=caseq, dgozman

Bug:  801426 
Change-Id: I5f9d88aa3e6c859626486965b9b1801a4728a8e0
Reviewed-on: https://chromium-review.googlesource.com/1202662
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588420}
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[modify] https://crrev.com/c23b4fda5db59a29b3da3d6a6a7f6f3720bb1814/content/browser/devtools/protocol/devtools_protocol_test_support.h
►

Sign in to add a comment