New issue
Advanced search Search tips

Issue 801423 link

Starred by 3 users
Status: Assigned
Owner:
vadimsh@chromium.org
Cc:
most...@vewd.com
vadimsh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement CIPD backend in Go

Project Member Reported by vadimsh@chromium.org, Jan 12 2018 
Two primary reasons:
 * Migrate to pRPC before Cloud Endpoints are shutdown.
 * Enable sharing of code between the client and the backend.
Showing comments 49 - 148 of 148 Older ›
Project Member

Comment 49 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/20bade514acebeaf51b0828d55ce10d375de6e9d

commit 20bade514acebeaf51b0828d55ce10d375de6e9d
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 07 21:43:56 2018

[cipd] Add a function to parse packageACL key.

Will be needed for VisitMetadata implementation.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I97a2d1b03d8205eab9464d3f3f0776bb8cccaa67
Reviewed-on: https://chromium-review.googlesource.com/1091465
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/20bade514acebeaf51b0828d55ce10d375de6e9d/cipd/appengine/impl/metadata/legacy.go
[modify] https://crrev.com/20bade514acebeaf51b0828d55ce10d375de6e9d/cipd/appengine/impl/metadata/legacy_test.go
Project Member

Comment 50 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3ca6ca6a6f087acaee68946b6dfb5dbb046bdc14

commit 3ca6ca6a6f087acaee68946b6dfb5dbb046bdc14
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 08 21:49:24 2018

[cipd] Add metadata graph structure for legacy metadata.

It will be used by VisitMetadata implementation. It is a tree where each node
may have packageACL entries attached to it, that are later converted to
api.PrefixMetadata during the traversal.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I9a33ca9902a11c56cb3dc1b59888340d4375a8db
Reviewed-on: https://chromium-review.googlesource.com/1092037
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/3ca6ca6a6f087acaee68946b6dfb5dbb046bdc14/cipd/appengine/impl/metadata/legacy.go
[modify] https://crrev.com/3ca6ca6a6f087acaee68946b6dfb5dbb046bdc14/cipd/appengine/impl/metadata/legacy_test.go
Project Member

Comment 51 by bugdroid1@chromium.org, Jun 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c182c2a90415a5d7f3c969e4849f8ed4d88b4815

commit c182c2a90415a5d7f3c969e4849f8ed4d88b4815
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Sat Jun 09 03:12:53 2018

[cipd] Add a function to list packageACL entities by prefix.

Will be used by VisitMetadata implementation.

Also fix micro nit in ListPackages implementation (which uses similar query).

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: Ib09bce12e70b33e2a111e0143ecf819697537a1c
Reviewed-on: https://chromium-review.googlesource.com/1093744
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/c182c2a90415a5d7f3c969e4849f8ed4d88b4815/cipd/appengine/impl/metadata/legacy.go
[modify] https://crrev.com/c182c2a90415a5d7f3c969e4849f8ed4d88b4815/cipd/appengine/impl/metadata/legacy_test.go
[modify] https://crrev.com/c182c2a90415a5d7f3c969e4849f8ed4d88b4815/cipd/appengine/impl/model/package.go
Project Member

Comment 54 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/72c46f07554d63dd34e3c0ba683ee1b753584a37

commit 72c46f07554d63dd34e3c0ba683ee1b753584a37
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 11 23:28:04 2018

[cipd] Add HidePackage/UnhidePackage RPCs.

They just flip 'Hidden' flag on the package entity.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I9a6ce6d90391943457c2d19287a96f2b50722296
Reviewed-on: https://chromium-review.googlesource.com/1094321
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/72c46f07554d63dd34e3c0ba683ee1b753584a37/cipd/api/cipd/v1/pb.discovery.go
[modify] https://crrev.com/72c46f07554d63dd34e3c0ba683ee1b753584a37/cipd/api/cipd/v1/repo.pb.go
[modify] https://crrev.com/72c46f07554d63dd34e3c0ba683ee1b753584a37/cipd/api/cipd/v1/repo.proto
[modify] https://crrev.com/72c46f07554d63dd34e3c0ba683ee1b753584a37/cipd/appengine/impl/model/package.go
[modify] https://crrev.com/72c46f07554d63dd34e3c0ba683ee1b753584a37/cipd/appengine/impl/model/package_test.go
[modify] https://crrev.com/72c46f07554d63dd34e3c0ba683ee1b753584a37/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/72c46f07554d63dd34e3c0ba683ee1b753584a37/cipd/appengine/impl/repo/repo_test.go
[modify] https://crrev.com/72c46f07554d63dd34e3c0ba683ee1b753584a37/cipd/client/cipd/prpc_remote_test.go
Project Member

Comment 57 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/689860fcb84ee73323a983c5dca45746da69633c

commit 689860fcb84ee73323a983c5dca45746da69633c
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 12 20:42:52 2018

[cipd] Add model.CheckInstanceReady function.

It verifies the instance exists and all pending processors (if any) have
succeeded. Such instances can be used as a target for refs and tags.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I42aa2ee3c87beedfa1ce4ef703414adcbdb5a6a6
Reviewed-on: https://chromium-review.googlesource.com/1097604
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/689860fcb84ee73323a983c5dca45746da69633c/cipd/appengine/impl/model/instance.go
[modify] https://crrev.com/689860fcb84ee73323a983c5dca45746da69633c/cipd/appengine/impl/model/instance_test.go
Project Member

Comment 58 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/6bbc9bfc9f4c78a13ab5e4b5b7d62b474142fb9b

commit 6bbc9bfc9f4c78a13ab5e4b5b7d62b474142fb9b
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 12 21:06:02 2018

[cipd] Implement VisitMetadata for legacy metadata entities.

This concludes ListPrefix(...) RPC implementation.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I8b3193a3a83b50569dcf25236c1c476c5c6475c5
Reviewed-on: https://chromium-review.googlesource.com/1093886
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/6bbc9bfc9f4c78a13ab5e4b5b7d62b474142fb9b/cipd/appengine/impl/metadata/legacy.go
[modify] https://crrev.com/6bbc9bfc9f4c78a13ab5e4b5b7d62b474142fb9b/cipd/appengine/impl/metadata/legacy_test.go
Project Member

Comment 59 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/300383845e6328f0e543f449cd3a710e2d1ed349

commit 300383845e6328f0e543f449cd3a710e2d1ed349
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 13 17:40:37 2018

[cipd] Add model helpers for refs: SetRef, GetRef, DeleteRef.

They are just thin wrappers over datastore.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I142f1d4e14df4284f44aa6c79aa821b4ed9cde15
Reviewed-on: https://chromium-review.googlesource.com/1098521
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[add] https://crrev.com/300383845e6328f0e543f449cd3a710e2d1ed349/cipd/appengine/impl/model/ref.go
[add] https://crrev.com/300383845e6328f0e543f449cd3a710e2d1ed349/cipd/appengine/impl/model/ref_test.go
Project Member

Comment 60 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/faab685b8a6efebb13d654b5756f66012b282ee0

commit faab685b8a6efebb13d654b5756f66012b282ee0
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 13 23:18:59 2018

[cipd] Implement CreateRef and DeleteRef RPCs.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: If886c31f4b23dcbe8df6d270e273dc464fbeac43
Reviewed-on: https://chromium-review.googlesource.com/1100101
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/faab685b8a6efebb13d654b5756f66012b282ee0/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/faab685b8a6efebb13d654b5756f66012b282ee0/cipd/appengine/impl/repo/repo_test.go
Project Member

Comment 64 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/6aa5709723d62023634bdf21ac7d2ac1527384bf

commit 6aa5709723d62023634bdf21ac7d2ac1527384bf
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 14 18:34:40 2018

[cipd] Implement datastore helpers for attaching and detaching tags.

They are slightly paranoid, since we assume SHA1 collisions are possible these
days. SHA1 is used internally for all existing tags and changing it is
non-trivial (will require changing all existing InstanceTag entities).

The mitigation in this CL should be sufficient though to not worry about
collisions.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: Ie55dfb92080647d407ee1115124299293b3ac588
Reviewed-on: https://chromium-review.googlesource.com/1100541
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/6aa5709723d62023634bdf21ac7d2ac1527384bf/cipd/appengine/impl/model/tag.go
[add] https://crrev.com/6aa5709723d62023634bdf21ac7d2ac1527384bf/cipd/appengine/impl/model/tag_test.go
Project Member

Comment 65 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c1cc4016a12f915361fad9fee0bf0994e8a3100e

commit c1cc4016a12f915361fad9fee0bf0994e8a3100e
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 14 22:32:29 2018

[cipd] Use proto messages to represent tags.

This will be useful later when implementing unique tags, since this allows to
non-ambiguously attach attributes to tags without inventing any new weird
syntax.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I857978d42f9e3b8059e1c4d8c138d3f7afc62f76
Reviewed-on: https://chromium-review.googlesource.com/1101645
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/c1cc4016a12f915361fad9fee0bf0994e8a3100e/cipd/api/cipd/v1/pb.discovery.go
[modify] https://crrev.com/c1cc4016a12f915361fad9fee0bf0994e8a3100e/cipd/api/cipd/v1/repo.pb.go
[modify] https://crrev.com/c1cc4016a12f915361fad9fee0bf0994e8a3100e/cipd/api/cipd/v1/repo.proto
[modify] https://crrev.com/c1cc4016a12f915361fad9fee0bf0994e8a3100e/cipd/appengine/impl/model/tag.go
[modify] https://crrev.com/c1cc4016a12f915361fad9fee0bf0994e8a3100e/cipd/appengine/impl/model/tag_test.go
[modify] https://crrev.com/c1cc4016a12f915361fad9fee0bf0994e8a3100e/cipd/common/common.go
[modify] https://crrev.com/c1cc4016a12f915361fad9fee0bf0994e8a3100e/cipd/common/common_test.go
Project Member

Comment 66 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/8ab72831e59aaa448b9aba4598a56b9a2d282334

commit 8ab72831e59aaa448b9aba4598a56b9a2d282334
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 14 23:32:40 2018

[cipd] Implement AttachTags/DetachTags RPCs.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I6b27e249cd814ac184896a00c8adae1a0c0587c6
Reviewed-on: https://chromium-review.googlesource.com/1101967
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/8ab72831e59aaa448b9aba4598a56b9a2d282334/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/8ab72831e59aaa448b9aba4598a56b9a2d282334/cipd/appengine/impl/repo/repo_test.go
Project Member

Comment 68 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/a0e77e06f4d3ed7b5479dc2004065aa648f6b17d

commit a0e77e06f4d3ed7b5479dc2004065aa648f6b17d
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 15 02:40:39 2018

[cipd] Implement ResolveVersion RPC.

It takes a version string and resolves it into a concrete package instance.

A version string can be any of:
  * A string-encoded instance ID, e.g. "abcdef....".
  * A ref name, e.g. "latest".
  * A tag, e.g. "version:1.10.3".

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I930a2eed0284c2d28e770a5e651ccb94f5a89046
Reviewed-on: https://chromium-review.googlesource.com/1102131
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/a0e77e06f4d3ed7b5479dc2004065aa648f6b17d/cipd/api/cipd/v1/pb.discovery.go
[modify] https://crrev.com/a0e77e06f4d3ed7b5479dc2004065aa648f6b17d/cipd/api/cipd/v1/repo.pb.go
[modify] https://crrev.com/a0e77e06f4d3ed7b5479dc2004065aa648f6b17d/cipd/api/cipd/v1/repo.proto
[modify] https://crrev.com/a0e77e06f4d3ed7b5479dc2004065aa648f6b17d/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/a0e77e06f4d3ed7b5479dc2004065aa648f6b17d/cipd/appengine/impl/repo/repo_test.go
[modify] https://crrev.com/a0e77e06f4d3ed7b5479dc2004065aa648f6b17d/cipd/client/cipd/prpc_remote_test.go
Project Member

Comment 70 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/35ea3b2c9767224076c459a538ee0187492eb1a9

commit 35ea3b2c9767224076c459a538ee0187492eb1a9
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 15 04:40:49 2018

[cipd] Add ListInstanceRefs helper function.

It returns refs pointing to an instance. Will be used in implementation of
DescribeInstance RPC.

Rename ListRefs to ListPackageRefs for consistency.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I854dbca861df36b2970c9173a4171d7a9e673055
Reviewed-on: https://chromium-review.googlesource.com/1102181
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/35ea3b2c9767224076c459a538ee0187492eb1a9/cipd/appengine/impl/model/ref.go
[modify] https://crrev.com/35ea3b2c9767224076c459a538ee0187492eb1a9/cipd/appengine/impl/model/ref_test.go
[modify] https://crrev.com/35ea3b2c9767224076c459a538ee0187492eb1a9/cipd/appengine/impl/repo/repo.go
Project Member

Comment 71 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/9604ffc305fc7f3430a02baee5500d8c3dbba449

commit 9604ffc305fc7f3430a02baee5500d8c3dbba449
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 15 17:43:29 2018

[cipd] Add ListInstanceTags helper function.

It returns tags attached to an instance, sorted in a particular way. Will be
used in implementation of DescribeInstance RPC.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I7127243e993574c7b22b14fb44905c980b7008e6
Reviewed-on: https://chromium-review.googlesource.com/1102184
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/9604ffc305fc7f3430a02baee5500d8c3dbba449/cipd/appengine/impl/model/tag.go
[modify] https://crrev.com/9604ffc305fc7f3430a02baee5500d8c3dbba449/cipd/appengine/impl/model/tag_test.go
Project Member

Comment 72 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/8caf16ec2456c7a43416774ebd3ea09685c1f9d9

commit 8caf16ec2456c7a43416774ebd3ea09685c1f9d9
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 15 17:50:00 2018

[cipd] Add definition of DescribeInstance RPC.

It returns a list of tags and refs associated with the instance, as well as
state of all processors.

In absence of field masks, we use simple 'describe_<X>' request fields to allow
partial responses.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I0e00d5cc5307edffe8e8286c7de014614e6eb01d
Reviewed-on: https://chromium-review.googlesource.com/1102051
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/8caf16ec2456c7a43416774ebd3ea09685c1f9d9/cipd/api/cipd/v1/pb.discovery.go
[modify] https://crrev.com/8caf16ec2456c7a43416774ebd3ea09685c1f9d9/cipd/api/cipd/v1/repo.pb.go
[modify] https://crrev.com/8caf16ec2456c7a43416774ebd3ea09685c1f9d9/cipd/api/cipd/v1/repo.proto
[modify] https://crrev.com/8caf16ec2456c7a43416774ebd3ea09685c1f9d9/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/8caf16ec2456c7a43416774ebd3ea09685c1f9d9/cipd/appengine/impl/repo/repo_test.go
[modify] https://crrev.com/8caf16ec2456c7a43416774ebd3ea09685c1f9d9/cipd/client/cipd/prpc_remote_test.go
Project Member

Comment 76 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c7128ecba305255befd2615797fb7d2ccf86c4ca

commit c7128ecba305255befd2615797fb7d2ccf86c4ca
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 18 16:19:32 2018

[cipd] Boilerplate for SearchInstances RPC.

It will be used to query for instances with all given tags attached to them
(used by 'cipd search <pkg> -tag ...' command).

Unlike Python version, Go version will NOT support search by tags globally
across all packages:
  1. It is not really used as far as I can tell.
  2. It actually makes little sense considering that CIPD packages are managed
     by multiple different teams with different practices. What we really want
     is searching by tag in packages under some prefix. This may be implemented
     later.

Another difference over Python version is some support for searching for
multiple attached tags at once ("tag1:key1" AND "tag2:key2"). Python version
supported only one tag. The implementation is inefficient though when searching
for two or more tags at once. It is still better than implementing same
inefficient algorithm on the client side (as was observed in the wild).

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: Ib3ea44ccf564283eaf11ad631b35491932b2b491
Reviewed-on: https://chromium-review.googlesource.com/1103670
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/api/cipd/v1/pb.discovery.go
[modify] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/api/cipd/v1/repo.pb.go
[modify] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/api/cipd/v1/repo.proto
[add] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/appengine/impl/model/query.go
[add] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/appengine/impl/model/query_test.go
[modify] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/appengine/impl/repo/repo_test.go
[modify] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/client/cipd/prpc_remote_test.go
Project Member

Comment 77 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/8acab14f36eb0e48a8521720d30f77deae4a9339

commit 8acab14f36eb0e48a8521720d30f77deae4a9339
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 18 22:34:12 2018

[cipd] Implement SearchInstances RPC.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: Id459d049918653e4a4aabaf3d15c06f4ca37517d
Reviewed-on: https://chromium-review.googlesource.com/1103673
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/8acab14f36eb0e48a8521720d30f77deae4a9339/cipd/appengine/impl/model/instance.go
[modify] https://crrev.com/8acab14f36eb0e48a8521720d30f77deae4a9339/cipd/appengine/impl/model/instance_test.go
[delete] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/appengine/impl/model/query.go
[delete] https://crrev.com/c7128ecba305255befd2615797fb7d2ccf86c4ca/cipd/appengine/impl/model/query_test.go
[add] https://crrev.com/8acab14f36eb0e48a8521720d30f77deae4a9339/cipd/appengine/impl/model/search.go
[add] https://crrev.com/8acab14f36eb0e48a8521720d30f77deae4a9339/cipd/appengine/impl/model/search_test.go
[modify] https://crrev.com/8acab14f36eb0e48a8521720d30f77deae4a9339/cipd/appengine/impl/model/tag.go
[modify] https://crrev.com/8acab14f36eb0e48a8521720d30f77deae4a9339/cipd/appengine/impl/repo/repo_test.go
Project Member

Comment 79 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/7d3cc7da77302db18ffe8cab02526149dd62848c

commit 7d3cc7da77302db18ffe8cab02526149dd62848c
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 19 19:26:41 2018

[cipd] Implement legacy variant of ResolveVersion RPC.

I.e. GET /_ah/api/repo/v1/instance/resolve?package_name=...&version=...

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I70d2158d71890ce79087a17675cc902997be524d
Reviewed-on: https://chromium-review.googlesource.com/1105605
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/7d3cc7da77302db18ffe8cab02526149dd62848c/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/7d3cc7da77302db18ffe8cab02526149dd62848c/cipd/appengine/impl/repo/repo_test.go
Project Member

Comment 80 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/172b8d1bbbd1eced2fb0666c6ad272dec3812d06

commit 172b8d1bbbd1eced2fb0666c6ad272dec3812d06
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 19 19:33:01 2018

[cipd] Implement legacy variant of DescribeInstance+GetInstanceURL RPC.

I.e. GET /_ah/api/repo/v1/instance?package_name=...&instance_id=...

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: Ia7757af5a06e7d57001650d8a35b081baef542d8
Reviewed-on: https://chromium-review.googlesource.com/1105613
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/172b8d1bbbd1eced2fb0666c6ad272dec3812d06/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/172b8d1bbbd1eced2fb0666c6ad272dec3812d06/cipd/appengine/impl/repo/repo_test.go
Project Member

Comment 81 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/5798be65fe5e0700b1d0cfb6839e527b8892f781

commit 5798be65fe5e0700b1d0cfb6839e527b8892f781
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 19 19:45:11 2018

[cipd] Remove 'pkg-delete' subcommand.

Package deletion is no longer supported in v2 backend. Packages should be hidden
instead or just left alone unreferenced.

Deleting packages generally is a bad idea, considering it breaks historical pins
and introduces a possibility for tag overrides (e.g. delete a package, make a
new one with the same name, attach same tags, which now point to different
content).

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I12bc48d7088c92314b987e6a503263f0a7c0e6c5
Reviewed-on: https://chromium-review.googlesource.com/1106713
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/5798be65fe5e0700b1d0cfb6839e527b8892f781/cipd/client/cipd/client.go
[modify] https://crrev.com/5798be65fe5e0700b1d0cfb6839e527b8892f781/cipd/client/cipd/prpc_remote.go
[modify] https://crrev.com/5798be65fe5e0700b1d0cfb6839e527b8892f781/cipd/client/cipd/remote.go
[modify] https://crrev.com/5798be65fe5e0700b1d0cfb6839e527b8892f781/cipd/client/cipd/remote_test.go
[modify] https://crrev.com/5798be65fe5e0700b1d0cfb6839e527b8892f781/cipd/client/cli/main.go
Project Member

Comment 83 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/44ec31d1076c4f57e848afd199a8cf9f0ab30af5

commit 44ec31d1076c4f57e848afd199a8cf9f0ab30af5
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 19 22:18:18 2018

[cipd] Implement legacy variant of /client endpoint.

It returns information about a CIPD client package as well as a signed URL to
the client binary in Google Storage.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I26288cda7f1c1a085a33e87f16e85b6a9d124af5
Reviewed-on: https://chromium-review.googlesource.com/1105622
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/44ec31d1076c4f57e848afd199a8cf9f0ab30af5/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/44ec31d1076c4f57e848afd199a8cf9f0ab30af5/cipd/appengine/impl/repo/repo_test.go
Project Member

Comment 85 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/9d976d05b3cc16011d1dd293842ff13402df37a4

commit 9d976d05b3cc16011d1dd293842ff13402df37a4
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 20 22:15:30 2018

[cipd] Remove COUNTER_WRITER ACL support from the client.

Forgot do to it in CL 1106716 that removed the counters feature.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I95841a67b7c1fa882d7bc794ff4d6beca6b9cb33
Reviewed-on: https://chromium-review.googlesource.com/1108961
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/9d976d05b3cc16011d1dd293842ff13402df37a4/cipd/client/cipd/client.go
[modify] https://crrev.com/9d976d05b3cc16011d1dd293842ff13402df37a4/cipd/client/cli/main.go
Project Member

Comment 86 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/f745148873cfee4a3d1215c34ce35a64bd8f34df

commit f745148873cfee4a3d1215c34ce35a64bd8f34df
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 20 22:18:59 2018

[cipd] Implement 'acl-check' subcommand using v2 API.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: Ice8b99ba9f3e7b0115d4f2b6f956f2c32de10f14
Reviewed-on: https://chromium-review.googlesource.com/1109019
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/f745148873cfee4a3d1215c34ce35a64bd8f34df/cipd/client/cipd/prpc_remote.go
[modify] https://crrev.com/f745148873cfee4a3d1215c34ce35a64bd8f34df/cipd/client/cipd/prpc_remote_test.go
Project Member

Comment 87 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/d3a7c3c86b9ff5ae5748bbdac4f2f7df35e0afae

commit d3a7c3c86b9ff5ae5748bbdac4f2f7df35e0afae
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 20 22:45:29 2018

[cipd] Implement 'ls' subcommand using v2 API.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I89b8eb4dc472285e1bab3ea9709ed6d32923fcdf
Reviewed-on: https://chromium-review.googlesource.com/1109026
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/d3a7c3c86b9ff5ae5748bbdac4f2f7df35e0afae/cipd/client/cipd/prpc_remote.go
[modify] https://crrev.com/d3a7c3c86b9ff5ae5748bbdac4f2f7df35e0afae/cipd/client/cipd/prpc_remote_test.go
Project Member

Comment 88 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/dc552c127c24e88767107fcce3467b16d493b717

commit dc552c127c24e88767107fcce3467b16d493b717
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 20 23:33:39 2018

[cipd] Move a bunch of function from appengine/* to common/*.

These functions are useful on the client too:
  * ValidateObjectRef, ObjectRefToInstanceID, InstanceIDToObjectRef
  * NewHash, ValidateHashAlgo

This will also simplify switching to SHA256 later.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: If896df717bb255817d800902117c8a1163722dcb
Reviewed-on: https://chromium-review.googlesource.com/1109298
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/appengine/impl/cas/cas.go
[modify] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/appengine/impl/model/instance.go
[modify] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/appengine/impl/model/instance_test.go
[modify] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/appengine/impl/model/ref.go
[modify] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/appengine/impl/repo/processing/client_extractor.go
[modify] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/appengine/impl/repo/repo_test.go
[rename] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/common/hash.go
[rename] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/common/hash_test.go
[add] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/common/iid.go
[add] https://crrev.com/dc552c127c24e88767107fcce3467b16d493b717/cipd/common/iid_test.go
Project Member

Comment 89 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c3ba083fe593a630ebd871ed741c33d399ae2803

commit c3ba083fe593a630ebd871ed741c33d399ae2803
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 21 00:08:29 2018

[cipd] Implement 'resolve' subcommand using v2 API.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I47c711366948f325c9dd7f96f2213a0475b00aa2
Reviewed-on: https://chromium-review.googlesource.com/1109207
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/c3ba083fe593a630ebd871ed741c33d399ae2803/cipd/client/cipd/prpc_remote.go
[modify] https://crrev.com/c3ba083fe593a630ebd871ed741c33d399ae2803/cipd/client/cipd/prpc_remote_test.go
Project Member

Comment 90 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/4255bf7c190d38576bef44a672d5330c9a3cd733

commit 4255bf7c190d38576bef44a672d5330c9a3cd733
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 21 20:15:24 2018

[cipd] Implement 'pkg-fetch' and 'ensure' subcommands using v2 API.

This also splits remote.fetchInstance into remote.fetchInstanceInfo and
remote.fetchInstanceURL, since in v2 these are different RPCs.

Note that there's no cases when remote.fetchInstanceInfo and
remote.fetchInstanceURL are called together, i.e. v1's remote.fetchInstance
always returns some ignored information. That's the reason it was split into
two RPCs in v2.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: Icbbf5f70b5b4bb9736871dc0d9fbbbbf251bb50a
Reviewed-on: https://chromium-review.googlesource.com/1109305
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/4255bf7c190d38576bef44a672d5330c9a3cd733/cipd/client/cipd/client.go
[modify] https://crrev.com/4255bf7c190d38576bef44a672d5330c9a3cd733/cipd/client/cipd/prpc_remote.go
[modify] https://crrev.com/4255bf7c190d38576bef44a672d5330c9a3cd733/cipd/client/cipd/prpc_remote_test.go
[modify] https://crrev.com/4255bf7c190d38576bef44a672d5330c9a3cd733/cipd/client/cipd/remote.go
[modify] https://crrev.com/4255bf7c190d38576bef44a672d5330c9a3cd733/cipd/client/cipd/remote_test.go
Project Member

Comment 93 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/055b0724946badfecdeecd8c14bdf4894c808cfc

commit 055b0724946badfecdeecd8c14bdf4894c808cfc
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 22 01:27:43 2018

[cipd] Refactor 'cipd describe' implementation in preparation for v2.

In v1, 'cipd describe' does 3 parallel backend calls. In v2 it is a single call.
So for v1 we move the parallelism into v1-specific remote.go.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I6b4c24e74f63a1b976b52d32d9172ad863cfd8e8
Reviewed-on: https://chromium-review.googlesource.com/1111330
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/055b0724946badfecdeecd8c14bdf4894c808cfc/cipd/client/cipd/client.go
[modify] https://crrev.com/055b0724946badfecdeecd8c14bdf4894c808cfc/cipd/client/cipd/client_test.go
[modify] https://crrev.com/055b0724946badfecdeecd8c14bdf4894c808cfc/cipd/client/cipd/prpc_remote.go
[modify] https://crrev.com/055b0724946badfecdeecd8c14bdf4894c808cfc/cipd/client/cipd/remote.go
[modify] https://crrev.com/055b0724946badfecdeecd8c14bdf4894c808cfc/cipd/client/cipd/remote_test.go
[modify] https://crrev.com/055b0724946badfecdeecd8c14bdf4894c808cfc/cipd/client/cipd/verify.go
[modify] https://crrev.com/055b0724946badfecdeecd8c14bdf4894c808cfc/cipd/client/cli/main.go
Project Member

Comment 94 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/145c22e3734ef944f1ad018f5ac1323709938745

commit 145c22e3734ef944f1ad018f5ac1323709938745
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 22 18:54:05 2018

[cipd] Return fully populated Ref proto in DescribeInstance response.

Saving on response size is not worth the inconsistency it adds.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: If001f743ebe2b401300de9ccd8c79bfcbf323c1b
Reviewed-on: https://chromium-review.googlesource.com/1111381
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/145c22e3734ef944f1ad018f5ac1323709938745/cipd/appengine/impl/repo/repo.go
[modify] https://crrev.com/145c22e3734ef944f1ad018f5ac1323709938745/cipd/appengine/impl/repo/repo_test.go
Project Member

Comment 95 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/d50e9a567f792e1f1e7f1e34040dc882c4d31922

commit d50e9a567f792e1f1e7f1e34040dc882c4d31922
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 22 19:11:55 2018

[cipd] Implement 'describe' subcommand using v2 API.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: Id4addd6c9164f2f4b34b3c138452a208bf5439f6
Reviewed-on: https://chromium-review.googlesource.com/1111462
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/d50e9a567f792e1f1e7f1e34040dc882c4d31922/cipd/client/cipd/prpc_remote.go
[modify] https://crrev.com/d50e9a567f792e1f1e7f1e34040dc882c4d31922/cipd/client/cipd/prpc_remote_test.go
Project Member

Comment 98 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c6981a5fd41895a3ac4f4c6f804636678d9d4ac9

commit c6981a5fd41895a3ac4f4c6f804636678d9d4ac9
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Sat Jun 23 00:17:45 2018

[cipd] Unify errors handling in pRPC remote implementation.

All expected errors are logged once by the caller (usually CLI), and they do not
have scary looking gRPC framing.

Also bump number of retries to 10, to match v1 logic.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I14e3e8da0db249d924a4a3f16276e5eea4464246
Reviewed-on: https://chromium-review.googlesource.com/1112709
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/c6981a5fd41895a3ac4f4c6f804636678d9d4ac9/cipd/client/cipd/prpc_remote.go
Project Member

Comment 99 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/550cea2b9ab6435ff75afff819ae6fca2e14e99e

commit 550cea2b9ab6435ff75afff819ae6fca2e14e99e
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Sat Jun 23 01:36:50 2018

Roll infra/go/src/go.chromium.org/luci a061fdadc..1a9d1f74b (23 commits)

https://chromium.googlesource.com/infra/luci/luci-go/+log/a061fdadc087..1a9d1f74b2dc

$ git log a061fdadc..1a9d1f74b --date=short --no-merges --format='%ad %ae %s'
2018-06-23 vadimsh [cipd] Register ${platform}, ${os} and ${arch} vars in pkg-build by default.
2018-06-23 vadimsh [cipd] Unify errors handling in pRPC remote implementation.
2018-06-22 vadimsh [cipd] Implement 'selfupdate' command using v2 API.
2018-06-22 vadimsh [cipd] Implement 'set-ref' and 'set-tag' using v2 API.
2018-06-22 vadimsh [cipd] Implement 'describe' subcommand using v2 API.
2018-06-22 vadimsh [cipd] Return fully populated Ref proto in DescribeInstance response.
2018-06-22 vadimsh [cipd] Refactor 'cipd describe' implementation in preparation for v2.
2018-06-21 vadimsh [cipd] Implement 'search' subcommand using v2 API.
2018-06-21 nodir [buildbucket] Document importance of role enum tag numbers
2018-06-21 vadimsh [cipd] Implement 'instances' subcommand using v2 API.
2018-06-21 vadimsh [cipd] Implement 'pkg-fetch' and 'ensure' subcommands using v2 API.
2018-06-21 vadimsh [cipd] Implement 'resolve' subcommand using v2 API.
2018-06-20 vadimsh [cipd] Move a bunch of function from appengine/* to common/*.
2018-06-20 tandrii Update expected LoginURL returned by GAE.
2018-06-20 tandrii [scheduler] fix Makefile to also upload static.
2018-06-20 vadimsh [cipd] Implement 'ls' subcommand using v2 API.
2018-06-20 vadimsh [cipd] Implement 'acl-check' subcommand using v2 API.
2018-06-20 vadimsh [cipd] Remove COUNTER_WRITER ACL support from the client.
2018-06-20 tandrii [scheduler] do not confuse reader of debug logs.
2018-06-20 vadimsh [cipd] Add DescribeClient RPC.
2018-06-19 vadimsh [cipd] Implement legacy variant of /client endpoint.
2018-06-19 mknyszek [luci_notify] Refactor Builder update to be less fragile
2018-06-19 tandrii Del 32 bit builder from cq.

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I9a1195e50b909888d4828b588a64fe761622802e
Reviewed-on: https://chromium-review.googlesource.com/1112858
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/550cea2b9ab6435ff75afff819ae6fca2e14e99e/DEPS
Project Member

Comment 100 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/507b95792ee0bf0c65e8c9685c087199d2587c45

commit 507b95792ee0bf0c65e8c9685c087199d2587c45
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Sat Jun 23 01:56:31 2018

[vpython] Make user agent string more useful by including CIPD version number.

It now includes version of CIPD client vpython embeds. Will be useful to verify
all v1 CIPD clients are gone before turning off v1 backend.

R=tandrii@chromium.org, iannucci@chromium.org
BUG=801423

Change-Id: Id4f46ea719a908f7e8f12448139b6f4a1da69de9
Reviewed-on: https://chromium-review.googlesource.com/1112864
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/507b95792ee0bf0c65e8c9685c087199d2587c45/go/src/infra/tools/vpython/main.go
Project Member

Comment 101 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/6cd4a52d68eed12f2840f595bc53bffcce404ed0

commit 6cd4a52d68eed12f2840f595bc53bffcce404ed0
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 25 17:55:11 2018

[cipd] Reply with HTTP 405 on unsupported legacy endpoints.

The error message surfaces in legacy clients as:

"""
Error: unexpected reply (HTTP 405):
This version of CIPD client is no longer supported, please upgrade.
"""

They'll see it whenever they use something other than 'ensure', 'selfupdate',
or 'install'.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: Id95f7ca8e7147be23dce7c962bf088b2dc5b25e8
Reviewed-on: https://chromium-review.googlesource.com/1112875
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/6cd4a52d68eed12f2840f595bc53bffcce404ed0/cipd/appengine/impl/repo/repo.go
Project Member

Comment 102 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/4b589a2ca7a2ada9de440d50ce7e069807ac50c5

commit 4b589a2ca7a2ada9de440d50ce7e069807ac50c5
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 25 20:13:26 2018
Project Member

Comment 103 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/936ca733475ba8723e31d8ce9fbdbbe578ac97d4

commit 936ca733475ba8723e31d8ce9fbdbbe578ac97d4
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 25 20:14:26 2018
Project Member

Comment 104 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/21d997ebd0f89a863a97a1a08fe3fcdab15fcaab

commit 21d997ebd0f89a863a97a1a08fe3fcdab15fcaab
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 25 20:23:54 2018
Project Member

Comment 105 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/a02505f564d2c8aa60e779669208af89affa58ec

commit a02505f564d2c8aa60e779669208af89affa58ec
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 25 23:48:15 2018

[cipd] Update cipd client and vpython 4d19637ec -> 550cea2b9.

New versions understand CIPD_PROTOCOL=v2.

R=tandrii@chromium.org
BUG=801423

Change-Id: I6ca28638393957a9965a0ded7ed49c15b3a8f5b0
Reviewed-on: https://chromium-review.googlesource.com/1114296
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/a02505f564d2c8aa60e779669208af89affa58ec/cipd_client_version
[modify] https://crrev.com/a02505f564d2c8aa60e779669208af89affa58ec/cipd_manifest.txt
Project Member

Comment 106 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/0ca49d8ebec9e147bfcb44b702a02524f2adda88

commit 0ca49d8ebec9e147bfcb44b702a02524f2adda88
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jun 25 23:53:34 2018
Project Member

Comment 107 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c3a8a6d00139528feaf74f2011ca69e14c23f7cc

commit c3a8a6d00139528feaf74f2011ca69e14c23f7cc
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 00:04:38 2018

[cipd] Disable ndb memcache to allow Go backend to run side-by-side.

Python's ndb and Go's dscache are not compatible with each other: an entity
written by Python side may be read as stale from Go and vice versa.

Disable the caching completely for the duration of v1 => v2 transition, when
both Python and Go backends run concurrently on top of same data.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: If65321215186146b60eb4dcedec8bba0f888f74e
Reviewed-on: https://chromium-review.googlesource.com/1114304
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/c3a8a6d00139528feaf74f2011ca69e14c23f7cc/appengine/chrome_infra_packages/cipd/impl.py
Project Member

Comment 108 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/a67a449cb3b9fbd1a82a86c20da89577a099b42b

commit a67a449cb3b9fbd1a82a86c20da89577a099b42b
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 00:04:36 2018
Project Member

Comment 109 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/802c0858f8b701ba5e67e4a8188de346ff9ca711

commit 802c0858f8b701ba5e67e4a8188de346ff9ca711
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 26 02:37:05 2018

Roll src/third_party/depot_tools d91a468aa50d..4c50badb2927 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d91a468aa50d..4c50badb2927


git log d91a468aa50d..4c50badb2927 --date=short --no-merges --format='%ad %ae %s'
2018-06-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-25 vadimsh@chromium.org [cipd] Update cipd client and vpython 4d19637ec -> 550cea2b9.
2018-06-25 tandrii@chromium.org Reland of "Wipe out shallow checkout support from bot_update."


Created with:
  gclient setdep -r src/third_party/depot_tools@4c50badb2927

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:801423, chromium:855137 
TBR=agable@chromium.org

Change-Id: I7aed0e8eeb410cdc42f0468278104037dd9edbf3
Reviewed-on: https://chromium-review.googlesource.com/1114049
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570305}
[modify] https://crrev.com/802c0858f8b701ba5e67e4a8188de346ff9ca711/DEPS
Project Member

Comment 110 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/333db54570a89c15ad8da08696be059fc5ece41a

commit 333db54570a89c15ad8da08696be059fc5ece41a
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 18:16:57 2018
Project Member

Comment 111 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f426aba29d918434207f7054c6a9a7a4afd68161

commit f426aba29d918434207f7054c6a9a7a4afd68161
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 18:22:53 2018

[cipd] Update cipd and vpython to aacec5af4d.

New versions understand CIPD_PROTOCOL=v2.

R=tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I6d172f3a5dc42cf6643179cf230f368f0ff287be
Reviewed-on: https://chromium-review.googlesource.com/1114277
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/f426aba29d918434207f7054c6a9a7a4afd68161/scripts/slave/cipd_bootstrap_v2.py
Project Member

Comment 112 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/c767cf3c1d32692ec84342310cf72a4cda9f4353

commit c767cf3c1d32692ec84342310cf72a4cda9f4353
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 18:46:47 2018
Project Member

Comment 113 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/83a57e01cd02356704fb43f08cc4fa49060795df

commit 83a57e01cd02356704fb43f08cc4fa49060795df
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 18:49:46 2018

[cipd] Bump cipd and vpython 550cea2b9a -> aacec5af4d.

2018-06-26 vadimsh [cipd] Do not barf on -pkg-var when using -in.
2018-06-26 vadimsh [cipd] Fix and improve output of ensure-file-verify.
2018-06-26 vadimsh [cipd] Fix hanging in 'ensure-file-verify' if the ensure file is broken.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: Ic48753e30f2412f214ebfb73bb7693e5834cdbf7
Reviewed-on: https://chromium-review.googlesource.com/1115464
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/83a57e01cd02356704fb43f08cc4fa49060795df/cipd_client_version
[modify] https://crrev.com/83a57e01cd02356704fb43f08cc4fa49060795df/cipd_manifest.txt
Project Member

Comment 114 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8e221d16ca66686140a7ea7beb33d7299d1a9f9c

commit 8e221d16ca66686140a7ea7beb33d7299d1a9f9c
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 18:50:13 2018

[cipd] Update vpython embedded into isolated tasks ad60019cb -> aacec5af4.

The new version understand CIPD_PROTOCOL=v2.

R=iannucci@chromium.org, tandrii@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: Ic0580f940d6320ee9a8a7d89305052caeb7b00da
Reviewed-on: https://chromium-review.googlesource.com/1115461
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/8e221d16ca66686140a7ea7beb33d7299d1a9f9c/scripts/slave/recipe_modules/swarming/api.py
Project Member

Comment 115 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/66cca2d2ca01c08fd863754e01f1efdb22bd6ae4

commit 66cca2d2ca01c08fd863754e01f1efdb22bd6ae4
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 19:25:44 2018

[cipd] Disable memcache for PackageACL entities too.

Was forgotten in https://chromium-review.googlesource.com/1114304

TBR=nodir@chromium.org
BUG=801423

Change-Id: Ic1276122cb008d15d982ed01e33528158f2e25ee
Reviewed-on: https://chromium-review.googlesource.com/1115476
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/66cca2d2ca01c08fd863754e01f1efdb22bd6ae4/appengine/chrome_infra_packages/cipd/acl.py
Project Member

Comment 116 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b307c193a1f4b8a40f3bfb0764d0f93711114a6

commit 6b307c193a1f4b8a40f3bfb0764d0f93711114a6
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 26 20:15:13 2018

Roll src/third_party/depot_tools 4c50badb2927..83a57e01cd02 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c50badb2927..83a57e01cd02


git log 4c50badb2927..83a57e01cd02 --date=short --no-merges --format='%ad %ae %s'
2018-06-26 vadimsh@chromium.org [cipd] Bump cipd and vpython 550cea2b9a -> aacec5af4d.


Created with:
  gclient setdep -r src/third_party/depot_tools@83a57e01cd02

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:801423
TBR=agable@chromium.org

Change-Id: I19e4e9e67519ac0217a06c3305e230a26028f1e0
Reviewed-on: https://chromium-review.googlesource.com/1115404
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570509}
[modify] https://crrev.com/6b307c193a1f4b8a40f3bfb0764d0f93711114a6/DEPS
Project Member

Comment 117 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/7179a1b0855e9d037fa1bacf1d5b41b0b8897184

commit 7179a1b0855e9d037fa1bacf1d5b41b0b8897184
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 21:08:07 2018
Project Member

Comment 118 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97df77586eeeafd014df746b58240aa61b00d0ba

commit 97df77586eeeafd014df746b58240aa61b00d0ba
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jun 26 22:38:18 2018

Bump vpython pin ad60019cb66 -> aacec5af4d5.

The new version understands CIPD_PROTOCOL=v2 env var which will be used to verify
the new protocol works for everything before it becomes default.

R=iannucci@chromium.org, dpranke@chromium.org, bsheedy@chromium.org
BUG=801423

Change-Id: Ic169831f427d0d718c15dde8481d689e71776a68
Reviewed-on: https://chromium-review.googlesource.com/1115468
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570562}
[modify] https://crrev.com/97df77586eeeafd014df746b58240aa61b00d0ba/chrome/test/vr/auto_bisect.py
[modify] https://crrev.com/97df77586eeeafd014df746b58240aa61b00d0ba/tools/mb/mb.py
Project Member

Comment 119 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/281dd00c56aa04ca94a4dcfbfb50e0842fc0839e

commit 281dd00c56aa04ca94a4dcfbfb50e0842fc0839e
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 27 21:00:44 2018
Project Member

Comment 120 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/8a4c808613839e717254e3b5b02ccb035adc8f73

commit 8a4c808613839e717254e3b5b02ccb035adc8f73
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 27 21:41:46 2018
Project Member

Comment 121 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/47ba71d58fe5871f34721df77acd7c156344ebe5

commit 47ba71d58fe5871f34721df77acd7c156344ebe5
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 27 22:52:26 2018

[cipd] Add 'deploy_prod' makefile rule for deploying Go backend to prod.

It's just a copy of deploy_staging. Note that as long as we run both Python and
Go backends side-by-side, our deployment is quite weird and it's not supported
by gae.py tool.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I7fc7f7616d1043eed5cd5748b75eab7b71be0444
Reviewed-on: https://chromium-review.googlesource.com/1115771
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/47ba71d58fe5871f34721df77acd7c156344ebe5/cipd/appengine/Makefile
Project Member

Comment 122 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/92bc649c82608af3791bf7ce68817b74e8bdb263

commit 92bc649c82608af3791bf7ce68817b74e8bdb263
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jun 27 22:57:46 2018

[cipd] Add dispatch rule for /auth/pubsub/authdb:push.

It is required to route PubSub pushes from chrome-infra-auth to the Go module
that understands them.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I4a6b1e04e0f001c875ce373b879ff7aff746887a
Reviewed-on: https://chromium-review.googlesource.com/1117765
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/92bc649c82608af3791bf7ce68817b74e8bdb263/cipd/appengine/Makefile
[modify] https://crrev.com/92bc649c82608af3791bf7ce68817b74e8bdb263/cipd/appengine/dispatch.yaml
Project Member

Comment 123 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/10551ee3cc66561ffedfd1c4f1a0f968214be432

commit 10551ee3cc66561ffedfd1c4f1a0f968214be432
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 28 00:33:46 2018

[cipd] Use pRPC protocol by default, bump the client version to 2.0.0.

CIPD_PROTOCOL=v1 can still be used to temporarily switch back to v1.

R=iannucci@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I86d5e54f6dc9dc2c08d681e1cda0418d83f2700b
Reviewed-on: https://chromium-review.googlesource.com/1117851
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/10551ee3cc66561ffedfd1c4f1a0f968214be432/cipd/client/cipd/client.go
[modify] https://crrev.com/10551ee3cc66561ffedfd1c4f1a0f968214be432/cipd/client/cipd/client_test.go
Project Member

Comment 124 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b9c4670197dcefd8762d6e509302acd3efc6e303

commit b9c4670197dcefd8762d6e509302acd3efc6e303
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 28 02:09:31 2018

Roll infra/go/src/go.chromium.org/luci/ e38782665..10551ee3c (7 commits)

https://chromium.googlesource.com/infra/luci/luci-go/+log/e3878266592d..10551ee3cc66

$ git log e38782665..10551ee3c --date=short --no-merges --format='%ad %ae %s'
2018-06-28 vadimsh [cipd] Use pRPC protocol by default, bump the client version to 2.0.0.
2018-06-27 vadimsh [cipd] Add dispatch rule for /auth/pubsub/authdb:push.
2018-06-27 vadimsh [cipd] Add 'deploy_prod' makefile rule for deploying Go backend to prod.
2018-06-27 tandrii Better name for ExcludeAncestorsOf in gitiles.Log.
2018-06-27 vadimsh [scheduler] Improve RPC deadline handling.
2018-06-26 hinoka Add link to plain-text viewer
2018-06-26 hinoka [logdog] Redirect unauthenticated request to plain-text to login page

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

R=iannucci@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I66fb2d214dc89a1a046e66644b419c8bb4ba71dd
Reviewed-on: https://chromium-review.googlesource.com/1117867
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/b9c4670197dcefd8762d6e509302acd3efc6e303/go/src/infra/appengine/cr-audit-commits/app/auditor_test.go
[modify] https://crrev.com/b9c4670197dcefd8762d6e509302acd3efc6e303/go/src/infra/appengine/cr-audit-commits/app/auditor.go
[modify] https://crrev.com/b9c4670197dcefd8762d6e509302acd3efc6e303/DEPS
Project Member

Comment 125 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/70240928e16211ece82657bef527e54e4ec322a3

commit 70240928e16211ece82657bef527e54e4ec322a3
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 28 22:47:53 2018

[cipd] Bump cipd and vpython to versions that use v2 protocol by default.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I28331e8b6210cbd972cc687fa71a234e75da4b95
Reviewed-on: https://chromium-review.googlesource.com/1119374
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/70240928e16211ece82657bef527e54e4ec322a3/cipd_client_version
[modify] https://crrev.com/70240928e16211ece82657bef527e54e4ec322a3/cipd_manifest.txt
Project Member

Comment 126 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/4e8cd6081d2622e2214b4bbd0cdf5e2ba5406635

commit 4e8cd6081d2622e2214b4bbd0cdf5e2ba5406635
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 28 22:52:11 2018
Project Member

Comment 127 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9723afc2823dc669a4781ef12fb0a93d3450b02d

commit 9723afc2823dc669a4781ef12fb0a93d3450b02d
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 28 23:04:53 2018

[cipd] Bump cipd and vpython to versions that use v2 protocol by default.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I167f4b3af24b59af2a7e0f152c7a6ea87011d87c
Reviewed-on: https://chromium-review.googlesource.com/1119377
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/9723afc2823dc669a4781ef12fb0a93d3450b02d/scripts/slave/cipd_bootstrap_v2.py
[modify] https://crrev.com/9723afc2823dc669a4781ef12fb0a93d3450b02d/scripts/slave/recipe_modules/swarming/api.py
Project Member

Comment 128 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/68d6a49b4ff9135a68c299ed5e3ab1186819e4c9

commit 68d6a49b4ff9135a68c299ed5e3ab1186819e4c9
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jun 28 23:09:21 2018
Project Member

Comment 129 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/5c7d3505abceb16997ab57885b0a12e73dfe1735

commit 5c7d3505abceb16997ab57885b0a12e73dfe1735
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 29 00:06:06 2018
Project Member

Comment 130 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df79e9180a9ad7f645ce062644f2434dd165033a

commit df79e9180a9ad7f645ce062644f2434dd165033a
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 29 00:30:55 2018

Roll src/third_party/depot_tools b3853afe341f..ae1f03388f7a (5 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3853afe341f..ae1f03388f7a


git log b3853afe341f..ae1f03388f7a --date=short --no-merges --format='%ad %ae %s'
2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-28 vadimsh@chromium.org [cipd] Bump cipd and vpython to versions that use v2 protocol by default.
2018-06-28 jbudorick@chromium.org gclient: escape cipd variables when flattening DEPS.
2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-28 ehmaldonado@chromium.org gclient: Don't include CIPD package name in hierarchy.


Created with:
  gclient setdep -r src/third_party/depot_tools@ae1f03388f7a

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:801423,chromium:None
TBR=agable@chromium.org

Change-Id: I7b9f1d0635aeb8fec52b5bc1541c10001489df04
Reviewed-on: https://chromium-review.googlesource.com/1119329
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571340}
[modify] https://crrev.com/df79e9180a9ad7f645ce062644f2434dd165033a/DEPS
Project Member

Comment 131 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3c82c1c25a3317349e9426e10b58e30cef5a4d0a

commit 3c82c1c25a3317349e9426e10b58e30cef5a4d0a
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 29 21:16:36 2018

cipd: Bump cipd client version to the one that supports v2 protocol.

The version currently pinned is from 2015. It is very old and soon many of its
subcommands will stop working (since the backend is changing). Only
'cipd ensure' will continue working (to support old branches).

R=ayatane@chromium.org, dgarrett@chromium.org
BUG=chromium:801423

Change-Id: I1f5c4c319941ee5063582817979fc5e53ed0af96
Reviewed-on: https://chromium-review.googlesource.com/1119535
Commit-Ready: Vadim Shtayura <vadimsh@chromium.org>
Tested-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/3c82c1c25a3317349e9426e10b58e30cef5a4d0a/lib/cipd.py
Project Member

Comment 132 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/525be26fdc4ad98beff2cf284524c140f765f54d

commit 525be26fdc4ad98beff2cf284524c140f765f54d
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 29 22:39:39 2018

Roll src/third_party/chromite f028e346c07f..1bf75a651fe5 (3 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f028e346c07f..1bf75a651fe5


git log f028e346c07f..1bf75a651fe5 --date=short --no-merges --format='%ad %ae %s'
2018-06-29 xixuan@chromium.org report_stage: Add abortSkylabHWTestStage.
2018-06-29 derat@chromium.org chromeos_config: Update attribute expression for TastVMTest.
2018-06-29 vadimsh@chromium.org cipd: Bump cipd client version to the one that supports v2 protocol.


Created with:
  gclient setdep -r src/third_party/chromite@1bf75a651fe5

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:845314 , chromium:853545 ,chromium:801423
TBR=chrome-os-gardeners@chromium.org

Change-Id: I132c3b105686a4bcf8573121cdad6e7ba6246b59
Reviewed-on: https://chromium-review.googlesource.com/1121217
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571685}
[modify] https://crrev.com/525be26fdc4ad98beff2cf284524c140f765f54d/DEPS
Project Member

Comment 133 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9db2ec0a8d7d5ed95540fe3af7c5f5d711d5410

commit a9db2ec0a8d7d5ed95540fe3af7c5f5d711d5410
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jun 29 23:08:44 2018

Bump vpython pin aacec5af4d5 -> b9c4670197d.

It is same code as in https://chromium-review.googlesource.com/1115468 except
v2 CIPD protocol is now used by default (since it has been confirmed to work
correctly).

R=dpranke@chromium.org
TBR=bsheedy@chromium.org
BUG=801423

Change-Id: I92b39b3e8d564873571d9a65a7d3e922680d8f6f
Reviewed-on: https://chromium-review.googlesource.com/1119394
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571698}
[modify] https://crrev.com/a9db2ec0a8d7d5ed95540fe3af7c5f5d711d5410/chrome/test/vr/auto_bisect.py
[modify] https://crrev.com/a9db2ec0a8d7d5ed95540fe3af7c5f5d711d5410/tools/mb/mb.py
Project Member

Comment 134 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0e976559431e84f553409d66d5f73389cafe93e6

commit 0e976559431e84f553409d66d5f73389cafe93e6
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jul 02 22:39:06 2018

[cipd] Make v2 backend default.

Also adjust instance classes to match Python backend. Once this CL is deployed,
v1 backend is gone.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I325d48f9c9637a5bb074a6eb206a4fdf825bac5c
Reviewed-on: https://chromium-review.googlesource.com/1121248
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[delete] https://crrev.com/5b17173af178ca303d55afa3c6b36317ad439ccb/cipd/appengine/Makefile
[modify] https://crrev.com/0e976559431e84f553409d66d5f73389cafe93e6/cipd/appengine/backend/module-backend.yaml
[modify] https://crrev.com/0e976559431e84f553409d66d5f73389cafe93e6/cipd/appengine/dispatch.yaml
[modify] https://crrev.com/0e976559431e84f553409d66d5f73389cafe93e6/cipd/appengine/frontend/app.yaml
[modify] https://crrev.com/0e976559431e84f553409d66d5f73389cafe93e6/cipd/appengine/frontend/cron.yaml
[modify] https://crrev.com/0e976559431e84f553409d66d5f73389cafe93e6/cipd/appengine/frontend/index.yaml
[modify] https://crrev.com/0e976559431e84f553409d66d5f73389cafe93e6/cipd/appengine/frontend/main.go
[delete] https://crrev.com/5b17173af178ca303d55afa3c6b36317ad439ccb/cipd/appengine/frontend/module-frontend.yaml
[delete] https://crrev.com/5b17173af178ca303d55afa3c6b36317ad439ccb/cipd/appengine/frontend/phony.py
[modify] https://crrev.com/0e976559431e84f553409d66d5f73389cafe93e6/cipd/appengine/frontend/queue.yaml
[modify] https://crrev.com/0e976559431e84f553409d66d5f73389cafe93e6/cipd/appengine/impl/repo/repo.go
Project Member

Comment 135 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/21390025589f542bba79f231471a082c05d4bb46

commit 21390025589f542bba79f231471a082c05d4bb46
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jul 02 22:42:26 2018

[cipd] Boileplate for minimal bootstrap based UI.

Mostly copied from Scheduler.

R=nodir@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: I9e343c6af202003ca6520854201927b0a148f4f6
Reviewed-on: https://chromium-review.googlesource.com/1116244
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/frontend/main.go
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/frontend/templates/includes/base.html
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/frontend/templates/pages/error.html
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/frontend/templates/pages/index.html
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/bootstrap/css/bootstrap.min.css
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/bootstrap/fonts/glyphicons-halflings-regular.eot
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/bootstrap/fonts/glyphicons-halflings-regular.svg
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/bootstrap/fonts/glyphicons-halflings-regular.ttf
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/bootstrap/fonts/glyphicons-halflings-regular.woff
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/bootstrap/fonts/glyphicons-halflings-regular.woff2
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/bootstrap/js/bootstrap.min.js
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/jquery/jquery.min.js
[modify] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/static/module-static.yaml
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/ui/common.go
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/ui/errors.go
[add] https://crrev.com/21390025589f542bba79f231471a082c05d4bb46/cipd/appengine/ui/prefix.go
Project Member

Comment 136 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a7759c5f0f821504cebbdc1d092ad9f87428971a

commit a7759c5f0f821504cebbdc1d092ad9f87428971a
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jul 02 23:16:56 2018

[cipd] Remove the python version of the backend.

The backend is now implemented in Go and lives in:
https://chromium.googlesource.com/infra/luci/luci-go/+/master/cipd/appengine/

R=tandrii@chromium.org
BUG=801423

Change-Id: I6c4d115ffd64e9521c89c246e710ee091048c128
Reviewed-on: https://chromium-review.googlesource.com/1123643
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/html/cipd-mixin.html
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/app.yaml
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/test/admin_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/processing.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/html/test/index.html
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/acl.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cas/impl.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/test/acl_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cron.yaml
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/test/__init__.py
[modify] https://crrev.com/a7759c5f0f821504cebbdc1d092ad9f87428971a/doc/deployment.md
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/Makefile
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/apps.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/.gitignore
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/images/favicon.ico
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cas/test/common.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/appengine_config.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/index.yaml
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/admin.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/test/client_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/test/reader_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/OWNERS
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/client.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/README.md
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/html/test/cipd-breadcrumb-test.html
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/test/api_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/api.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/__init__.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/tools/run_tests.sh
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/main.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cas/__init__.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/wct.conf.js
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/html/index.html
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/images/ic_folder_black_24px.svg
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/components
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cloudstorage
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/handlers.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/test/impl_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/.coveragerc
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/html/cipd-breadcrumb.html
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cas/api.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/test/handlers_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/.expect_tests.cfg
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/html/cipd-pkg-view.html
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/gae_ts_mon
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/html/cipd-app.html
[modify] https://crrev.com/a7759c5f0f821504cebbdc1d092ad9f87428971a/PRESUBMIT.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/config.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/reader.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/.expect_tests_pretest.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cas/test/impl_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/html/cipd-dir-view.html
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/queue.yaml
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/tools/gae
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/impl.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cas/test/api_test.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/bower_components
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cipd/test/__init__.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/module-backend.yaml
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/images/ic_insert_drive_file_black_24px.svg
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/static/images/logo.png
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/cas/test/__init__.py
[delete] https://crrev.com/af2c1c0d4b78ec11e738ab39f934d2761a1395d5/appengine/chrome_infra_packages/testing_utils
Project Member

Comment 138 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/b3cc2efabbf3510843fc8669d38dc4df6bda7887

commit b3cc2efabbf3510843fc8669d38dc4df6bda7887
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jul 06 22:34:15 2018

[cipd] Remove v1 implementation of 'remote' interface.

Unfortunately, tests for cipd.Client were mocking v1 HTTP calls directly, so
these tests are now also gone. They'll be readded later after the refactoring
turmoil has settled.

R=tandrii@chromium.org
BUG=801423

Change-Id: Ic38394d4e8614b267af5b6d87505e30c42398ae3
Reviewed-on: https://chromium-review.googlesource.com/1128361
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/b3cc2efabbf3510843fc8669d38dc4df6bda7887/cipd/client/cipd/client.go
[modify] https://crrev.com/b3cc2efabbf3510843fc8669d38dc4df6bda7887/cipd/client/cipd/client_test.go
[delete] https://crrev.com/22c6809d519fab49617610409ac6a4742b7b6d0e/cipd/client/cipd/remote.go
[delete] https://crrev.com/22c6809d519fab49617610409ac6a4742b7b6d0e/cipd/client/cipd/remote_test.go
[modify] https://crrev.com/b3cc2efabbf3510843fc8669d38dc4df6bda7887/cipd/client/cipd/storage.go
[modify] https://crrev.com/b3cc2efabbf3510843fc8669d38dc4df6bda7887/cipd/client/cipd/storage_test.go
[modify] https://crrev.com/b3cc2efabbf3510843fc8669d38dc4df6bda7887/cipd/client/cli/main.go
Project Member

Comment 139 by bugdroid1@chromium.org, Jul 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/f8af071a316909f644520e3c0c83eb0f938a30ee

commit f8af071a316909f644520e3c0c83eb0f938a30ee
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Sat Jul 07 00:22:45 2018

[cipd] Split client.go into a bunch of files.

To clean it up before proceeding with the surgery.

Almost no real changes, just moves. The only significant change is in
mutateACLs: unknown roles are now rejected. This was required to get rid of
inconvenient context.Context propagation.

R=tandrii@chromium.org
BUG=801423

Change-Id: Iac6b436e8bcde8e3ad58a8831dc3154c95cdfcd1
Reviewed-on: https://chromium-review.googlesource.com/1128378
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[add] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/acl.go
[add] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/acl_test.go
[add] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/action_plan.go
[modify] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/client.go
[add] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/delete_on_close.go
[add] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/instance_enum.go
[add] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/json_structs.go
[modify] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/prpc_remote.go
[modify] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/prpc_remote_test.go
[add] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/rpc_mocks_test.go
[modify] https://crrev.com/f8af071a316909f644520e3c0c83eb0f938a30ee/cipd/client/cipd/storage_test.go
Project Member

Comment 140 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/b58aff20e2fad7f4f52bf029e867b6b2dc34deaf

commit b58aff20e2fad7f4f52bf029e867b6b2dc34deaf
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jul 09 22:43:46 2018

[prpc] Get rid of 'remote' interface, it is not needed any more.

We use pRPC's api.RepositoryClient in its place now. Merge prpcRemoteImpl with
cipd.Client.

This CL contains mostly code moves, comment changes and tests.

R=tandrii@chromium.org
BUG=801423

Change-Id: I3882b1fecba6c493ea55e304f5ba97d3d2329fa9
Reviewed-on: https://chromium-review.googlesource.com/1128464
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/b58aff20e2fad7f4f52bf029e867b6b2dc34deaf/cipd/client/cipd/acl.go
[modify] https://crrev.com/b58aff20e2fad7f4f52bf029e867b6b2dc34deaf/cipd/client/cipd/acl_test.go
[modify] https://crrev.com/b58aff20e2fad7f4f52bf029e867b6b2dc34deaf/cipd/client/cipd/client.go
[modify] https://crrev.com/b58aff20e2fad7f4f52bf029e867b6b2dc34deaf/cipd/client/cipd/client_test.go
[modify] https://crrev.com/b58aff20e2fad7f4f52bf029e867b6b2dc34deaf/cipd/client/cipd/json_structs.go
[add] https://crrev.com/b58aff20e2fad7f4f52bf029e867b6b2dc34deaf/cipd/client/cipd/json_structs_test.go
[delete] https://crrev.com/1210b742c78f39fe84cdca8d810d059736565f74/cipd/client/cipd/prpc_remote.go
[delete] https://crrev.com/1210b742c78f39fe84cdca8d810d059736565f74/cipd/client/cipd/prpc_remote_test.go
[modify] https://crrev.com/b58aff20e2fad7f4f52bf029e867b6b2dc34deaf/cipd/client/cipd/storage.go
Project Member

Comment 141 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/65f1a4bc32e94116ac3b2bebc0ea098b3c62b7b0

commit 65f1a4bc32e94116ac3b2bebc0ea098b3c62b7b0
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Mon Jul 23 23:42:48 2018

[cipd] Simplify SetRefWhenReady and AttachTagsWhenReady after v2 switch.

They now use the context deadline appropriately and share code. Also add tests.

R=iannucci@chromium.org, nodir@chromium.org
BUG=801423

Change-Id: I87508a14fda8cbd3caa5f49b176a6f035a94d443
Reviewed-on: https://chromium-review.googlesource.com/1146025
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/65f1a4bc32e94116ac3b2bebc0ea098b3c62b7b0/cipd/client/cipd/client.go
[modify] https://crrev.com/65f1a4bc32e94116ac3b2bebc0ea098b3c62b7b0/cipd/client/cipd/client_test.go
[modify] https://crrev.com/65f1a4bc32e94116ac3b2bebc0ea098b3c62b7b0/cipd/client/cipd/rpc_mocks_test.go

Comment 142 by most...@vewd.com, Jul 24

Cc: most...@vewd.com
We have started hitting cipd errors in a downstream chromium (67) fork, I wonder if one of these changes could be the cause?  depot_tools is up to date.

This is the error:
________ running 'cipd ensure -log-level error -root /home/tvsdk-bot/jenkins/WS/work/chromium/ -ensure-file /tmp/tmpNWps8G.ensure' in '.'
Error: resolving package: failed to resolve package version (line 67): ambiguity when resolving the tag, more than one instance has it.

It's not clear to me how to figure out what the duplicate tags are or where they are stored (so I can inspect them), but after some poking around the cli client I can see that p.UnresolvedVersion in go.chromium.org/luci/cipd/client/cipd/ensure/package_def.go is:

chromium/third_party/android_deps/repository/com_android_support_recyclerview_v7@version:27.0.0-cr0

Comment 143 by most...@vewd.com, Jul 24 

After digging a bit deeper, this message seems to be coming from the server backend:
https://chromium.googlesource.com/infra/luci/luci-go/+/8acab14f36eb0e48a8521720d30f77deae4a9339/cipd/appengine/impl/model/tag.go#169

Comment 144 by jbudorick@chromium.org, Jul 24 

#142, #143: duplicate tags were cleaned up in https://bugs.chromium.org/p/chromium/issues/detail?id=866912. If you're still seeing this in the 67 fork, please comment there.

Comment 145 by most...@vewd.com, Jul 24 

(After rolling back the cherry-picked https://chromium-review.googlesource.com/c/chromium/src/+/1147496 it still seems to work- thanks for the ping.)
Project Member

Comment 146 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/eda420f65f802834e7a23143930c564d75e33d1f

commit eda420f65f802834e7a23143930c564d75e33d1f
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jul 24 23:23:55 2018

[cipd] Update stale README.md

R=nodir@chromium.org, iannucci@chromium.org
BUG=801423

Change-Id: I4192d24eed8b179d0691a72b8fe447228bf27609
Reviewed-on: https://chromium-review.googlesource.com/1148765
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/eda420f65f802834e7a23143930c564d75e33d1f/cipd/README.md
[modify] https://crrev.com/eda420f65f802834e7a23143930c564d75e33d1f/cipd/appengine/README.md
Project Member

Comment 147 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/654af8e9f43d8a38aac041bb3cb56ab7288d75ef

commit 654af8e9f43d8a38aac041bb3cb56ab7288d75ef
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Jul 24 23:31:15 2018

[cipd] Simplify RegisterInstance after v2 switch.

Also RegisterInstance was the last function that explicitly mentioned SHA1. It
now uses whatever algo is used to identify cipd.Instance passed to it.

R=iannucci@chromium.org, nodir@chromium.org
BUG=801423, 821194

Change-Id: Ic5622fedccd039dfb4a1e013d87a023f55b4f7b5
Reviewed-on: https://chromium-review.googlesource.com/1147677
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/654af8e9f43d8a38aac041bb3cb56ab7288d75ef/cipd/client/cipd/client.go
[modify] https://crrev.com/654af8e9f43d8a38aac041bb3cb56ab7288d75ef/cipd/client/cipd/client_test.go
[modify] https://crrev.com/654af8e9f43d8a38aac041bb3cb56ab7288d75ef/cipd/client/cipd/storage_mock_test.go
Project Member

Comment 148 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/ed81b734060a0c88cb796f3c04895b270e9db0bc

commit ed81b734060a0c88cb796f3c04895b270e9db0bc
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jul 26 02:25:05 2018

[cipd] Fix regression in 'cipd search' subcommand.

It used to return 0 exit code and no results if asked to search inside missing
package. With v2 switch it started to return exit code 1 instead, which broke
some callers.

This change restores the original behavior. It sort of makes sense, since if
a package is missing, there's no instances of it, and search should just return
0 results.

R=nodir@chromium.org, iannucci@chromium.org
CC=​phosek@chromium.org
BUG= 867729 , 801423

Change-Id: I274b35c82be4d11db78150b444b076ef7d9787a0
Reviewed-on: https://chromium-review.googlesource.com/1150937
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/ed81b734060a0c88cb796f3c04895b270e9db0bc/cipd/client/cipd/client.go
[modify] https://crrev.com/ed81b734060a0c88cb796f3c04895b270e9db0bc/cipd/client/cipd/client_test.go
Showing comments 49 - 148 of 148 Older ›
►

Sign in to add a comment