Broken support for split keyboard mode |
|||
Issue descriptionCRD version:64.0.3282.85 What steps will reproduce the problem? (1)Hit the options menu in the iOS app and show keyboard (2)When the keyboard pops up, hit the keyboard icon on the keyboard itself to close the keyboard (3)Hit the options menu again. Note that it says "Hide keyboard" instead of "Show Keyboard" even though the keyboard has been closed For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 12 2018
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04a59c54bf1caf331f00ed7256e464a266d980c4 commit 04a59c54bf1caf331f00ed7256e464a266d980c4 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Jan 17 00:22:11 2018 [CRD iOS] Fix weird behavior when user uses split software keyboard There is a split keyboard mode on iPad mini and air. Under that mode the soft keyboard will be splitted into two parts and float on the middle of the screen (see the bug for screenshot). In the app we heavily rely on the keyboardWillShow notification to determine the presence of physical keyboard and adjust the layout for the keyboard. However in split keyboard mode, the keyboardWillShow notification is not triggered at all, causing lots of problems in the app (e.g. can't bring up the soft keyboard). This CL: * Disables the physical keyboard detector for now since it doesn't work in split keyboard mode. * Fixes the problem that tapping "Show Keyboard" doesn't show the keyboard. * Fixes other issues when adjusting layout for the keyboard. Bug: 801409 Change-Id: I6f58d423fa1487a181547999c2a817d6401487f5 Reviewed-on: https://chromium-review.googlesource.com/865852 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#529525} [modify] https://crrev.com/04a59c54bf1caf331f00ed7256e464a266d980c4/remoting/ios/app/host_view_controller.mm [modify] https://crrev.com/04a59c54bf1caf331f00ed7256e464a266d980c4/remoting/ios/client_keyboard.mm
,
Jan 17 2018
,
Jul 18
Verified Fixed in 67.0.3396.22 |
|||
►
Sign in to add a comment |
|||
Comment 1 by yuweih@chromium.org
, Jan 12 2018Status: Assigned (was: Untriaged)
Summary: Broken support for split keyboard mode (was: Keyboard toggle not in sync (iOS))
118 KB
118 KB View Download