New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801402 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR omnibox: Virtual keyboard is hidden after cancelling microphone permission request

Project Member Reported by vsupruniuk@google.com, Jan 12 2018

Issue description

Chrome Version: 65.0.3318.0
OS: Android O
VrCore: 1.12.177372015

What steps will reproduce the problem?
Make sure Chrome doesn't have microphone permission.
1. Enter VR
2. Click URL area in omnibox to switch to “omnibox text entry mode”
3. Click voice input button in the text entry field
=> Popup “Allow Chrome to record audio?” appears, virtual keyboard and text entry field are hidden
4. Click Cancel


What is the expected result?
keyboard should be visible without additional clicks after user cancels microphone permission request.

What happens instead?
Popup disappears. Text entry field is displayed, but virtual keyboard is hidden. In order to enable it we need to click text entry field.

 
Summary: VR omnibox: Virtual keyboard is hidden after cancelling microphone permission request (was: Virtual keyboard is hidden after cancelling microphone permission request)
Owner: ymalik@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd

commit fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd
Author: Yash Malik <ymalik@google.com>
Date: Thu Jan 18 17:46:36 2018

VR: Show keyboard when cancelling audio permission prompt

Also make the spacer in the suggestions layout and the back button
non-focusable so it doesn't steal focus from the omnibox and hide
the keyboard.

Bug:  801402 ,  801634 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia7b09b66e7f98ddc89ede4f67a4ad02544079553
Reviewed-on: https://chromium-review.googlesource.com/871515
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530189}
[modify] https://crrev.com/fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd/chrome/browser/vr/elements/button.cc
[modify] https://crrev.com/fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/fbb1613b7b4ed4597cf5b841cbcd4b77e1fb73dd/chrome/browser/vr/ui_scene_creator.cc

Comment 4 by ymalik@chromium.org, Jan 18 2018

Status: Fixed (was: Assigned)
Labels: Test-Complete

Sign in to add a comment