New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801386 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug


Participants' hotlists:
Hotlist-1


Sign in to add a comment

Notifications require interaction option does not update

Reported by tom.k.hi...@gmail.com, Jan 12 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce the problem:
1. Create notification with option requireInteraction set to true
2. Update notification with option requireInteraction set to false
3. The notification will still require interaction after it is updated

What is the expected behavior?
After requireInteraction is updated to false the notification should close itself after regular amount of time

What went wrong?
After updating require interaction the notification does not close until the user interacts even if it is set to false.

Did this work before? No 

Does this work in other browsers? N/A

Chrome version: 63.0.3239.132  Channel: stable
OS Version: 10.0
Flash Version:
 
notificationIssue.zip
168 KB Download
code.zip
56.1 KB Download
Labels: Needs-Triage-M63
compiled extension
notificationIssue.crx
112 KB Download
Cc: sc00335...@techmahindra.com
Components: Platform>Extensions UI>Notifications
Labels: Triaged-ET Needs-Feedback
Unable to test this issue as Extension corrupts after clicking on extension icon near omnibox. Attaching screencast for reference.

@Reporter: Could you please provide another sample extension to check this issue further as we are seeing "This extension may have been corrupted" error in chrome://extensions.

Comment 4 by peter@chromium.org, Jan 16 2018

Cc: yoshiki@chromium.org
Labels: -Needs-Feedback -Needs-Triage-M63
Status: Available (was: Unconfirmed)
Thank you for your report! It looks like we deliberately ignore changes to the `requireInteraction` value when updating notifications in Notification::CopyState(), but I have no clue why. The rest of the code path assumes that it can be updated, notably the PopupTimersController.

https://chromium-review.googlesource.com/#/c/chromium/src/+/868650

Commenting out the override makes this work as I'd expect and causes no test failures. yoshiki@, what's your feel -- let's remove it?
@sc00335...@techmahindra.com I have provided code.zip. after extraction the folder can be loaded as an extension using developer mode. It works fine on latest version of chrome.
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment