New issue
Advanced search Search tips

Issue 801378 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security


Participants' hotlists:
Hotlist-OffHeapWasm


Sign in to add a comment

Use-of-uninitialized-value in v8::internal::Assembler::target_address_at

Project Member Reported by ClusterFuzz, Jan 11 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6728375740923904

Fuzzer: libFuzzer_v8_wasm_compile_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  v8::internal::Assembler::target_address_at
  v8::internal::wasm::NativeModule::AddCode
  v8::internal::compiler::WasmCompilationUnit::FinishTurbofanCompilation
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=528635:528642

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6728375740923904

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 11 2018

Components: Blink>JavaScript>WebAssembly
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 11 2018

Cc: mstarzinger@chromium.org leszeks@chromium.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

[wasm] Use common serialization API for all modes. by mstarzinger@chromium.org - https://chromium.googlesource.com/v8/v8/+/4e116c4bc6fec07f532be068bc1c6e61e64073b3

[ignition] Change RestoreGeneratorRegisters to ResumeGenerator by leszeks@chromium.org - https://chromium.googlesource.com/v8/v8/+/713eb9e7655ec5954ab5a77c39ff9cf2874cbda9

If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Owner: mstarzinger@chromium.org
Looks like wasm rather than generators, assigning to Michi.
Cc: -mstarzinger@chromium.org
Labels: Test-Predator-Wrong-CLs
Status: Assigned (was: Untriaged)
Yes. My suspicion is that it is actually caused by enabling off-heap WebAssembly code (which is also in the prediction range but not part of the suspects in comment #2). Haven't verified that. But definitely related to WebAssembly.

commit afd8a81884b51f95595d9977723cb8bcb8f31c6b
Author: Michael Starzinger <mstarzinger@chromium.org>
Date:   Wed Jan 10 16:57:55 2018 +0100

    [wasm] Enable native-heap WebAssembly code by default.
    
    R=titzer@chromium.org
    BUG= v8:6876 
    
    Change-Id: Ib9821123e89b4a198cfa921ffd4cf5bee55cc93d
    Reviewed-on: https://chromium-review.googlesource.com/856999
    Reviewed-by: Ben Titzer <titzer@chromium.org>
    Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50498}
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 12 2018

Labels: M-65
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 12 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 12 2018

Labels: Pri-1
Project Member

Comment 8 by ClusterFuzz, Jan 18 2018

ClusterFuzz has detected this issue as fixed in range 529682:529689.

Detailed report: https://clusterfuzz.com/testcase?key=6728375740923904

Fuzzer: libFuzzer_v8_wasm_compile_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  v8::internal::Assembler::target_address_at
  v8::internal::wasm::NativeModule::AddCode
  v8::internal::compiler::WasmCompilationUnit::FinishTurbofanCompilation
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=528635:528642
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=529682:529689

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6728375740923904

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jan 18 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6728375740923904 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 26 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment