use max_plaintext_size_ when building connectivity probing packet |
|||
Issue descriptionUse max_plaintext_size_ instead of max_packet_length_ when building connectivity probing packet. So that the encrypted buffer size will be <= max_packet_length_.
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff8aa1cdc0ec19b29c3012ff31cdb537347504d4 commit ff8aa1cdc0ec19b29c3012ff31cdb537347504d4 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Wed Jan 17 05:39:41 2018 relnote: Use max_plaintext_size_ instead of max_packet_length_ when building connectivity probing packet. This way the encrypted buffer size will be <= max_packet_length_. Not flag protected. Merge internal change: 180683785 Bug: 801377 Change-Id: Id26378fe28fff75f7b24343dea4e64f37ead16f1 Reviewed-on: https://chromium-review.googlesource.com/862483 Reviewed-by: Buck Krasic <ckrasic@chromium.org> Reviewed-by: Jana Iyengar <jri@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#529632} [modify] https://crrev.com/ff8aa1cdc0ec19b29c3012ff31cdb537347504d4/net/quic/core/quic_packet_creator.cc
,
Jan 18 2018
,
Jan 18 2018
The fix landed in Comment 2 is connection migration specific. Given CMV2 is only available with version 65.0.3294.0 or above. We don't need to merge this bugfix to Beta as beta currently is on 64. +wub@: does this sound good to you?
,
Jan 18 2018
SGTM, thanks!
,
Jan 18 2018
No future merge required. Close this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by zhongyi@chromium.org
, Jan 11 2018