New issue
Advanced search Search tips

Issue 801368 link

Starred by 2 users
Status: Available
Owner:
kyleju@chromium.org
Cc:
mek@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[WPT Import] Importer does not remove all orphaned baselines and expectations

Project Member Reported by robertma@chromium.org, Jan 11 2018 
wpt-import deletes orphaned baselines by walking the external/wpt directory and removes baselines that no longer have corresponding tests:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py?q=test_importer&sq=package:chromium&l=394

This will leave platform-specific and virtual baselines behind.

Comment 1 by foolip@chromium.org, Sep 17 

robertma@, can you take a look at https://chromium-review.googlesource.com/c/chromium/src/+/1226799? It appears that we leave orphaned baselines behind more generally, not just in virtual/ and platoform/.

I've seen this a lot with .any.js tests too, which I cleaned up in https://chromium-review.googlesource.com/1200022, but there are extra complications there so perhaps not strictly the same bug.

Comment 2 by foolip@chromium.org, Sep 25

Summary: [WPT Import] Importer does not remove orphaned baselines (was: [WPT Import] Importer does not remove orphaned baselines in virtual/ or platform/)

Comment 3 by foolip@chromium.org, Sep 25 

 Issue 878657  has been merged into this issue.

Comment 4 by foolip@chromium.org, Sep 25

Labels: -Pri-3 Pri-2
Summary: [WPT Import] Importer does not remove all orphaned baselines and expectations (was: [WPT Import] Importer does not remove orphaned baselines)
I've duped  issue 878657  into this, which was also about virtual/ but in TestExpectations. Edited the title to be a bit broader since the root cause might all be the same.

Also calling it a P2 since there are now multiple people who have done cleanup of orphaned baselines/expectations.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2463e855f6f6b9fcde4bbef53859f0d0e848b3c2

commit 2463e855f6f6b9fcde4bbef53859f0d0e848b3c2
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Wed Oct 17 22:38:43 2018

Remove redundant result files in wpt/html/editing/focus

Tests were moved from html/editing/focus to html/interaction/focus/.
https://github.com/web-platform-tests/wpt/pull/12801

Bug: 801368
Change-Id: I19731a9ff1f1ab81f8fc5c8118b8d533844212c5
Reviewed-on: https://chromium-review.googlesource.com/c/1286027
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600578}
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/document-level-focus-apis/OWNERS
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/focus-01-expected.txt
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/focus-02-expected.txt
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/focus-management/OWNERS
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/sequential-focus-navigation-and-the-tabindex-attribute/OWNERS
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-negative-expected.txt
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-order-expected.txt
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-positive-expected.txt
[delete] https://crrev.com/65827fc5fd5431bba046c01fd7102d563bb65d71/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-zero-expected.txt

Comment 6 by kyleju@chromium.org, Nov 28

Owner: kyleju@chromium.org
►

Sign in to add a comment