New issue
Advanced search Search tips

Issue 801357 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 800570



Sign in to add a comment

[WPT import] Cannot update expectations for renamed/deleted any.js tests

Project Member Reported by robertma@chromium.org, Jan 11 2018

Issue description

TestImporter assumes that test names are file names when updating TestExpectations for renamed/deleted tests, which is not true for .any.js tests.
 
Blocking: 800570
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29306ef9451df45917273a80063b91d697e70188

commit 29306ef9451df45917273a80063b91d697e70188
Author: Robert Ma <robertma@chromium.org>
Date: Thu Jan 11 23:43:08 2018

Adjust TestExpectations for an incoming upstream rename

Upstream renamed a bunch of WebCryptoAPI tests to run in secure context.
Due to https://crbug.com/801357, these renames cannot be automatically
picked up by wpt-import.

We are expecting:
1. Most tests should run fine now that they are in secure context, but
   the old expectations are kept for now to prevent CQ/waterfall failing.
2. wrapKey_unwrapKey.https.worker.html will be slow, so add it to
   SlowTests.

Also change a bug link for another WebCryptoAPI test as 799547 has been
duped into 787971.

TBR=qyearsley

Bug:  787971 ,  799547 , 801357
No-Try: True
Change-Id: Id722cc4601d4bf5f2c4fbb564219eb3b89034f89
Reviewed-on: https://chromium-review.googlesource.com/862264
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528817}
[modify] https://crrev.com/29306ef9451df45917273a80063b91d697e70188/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/29306ef9451df45917273a80063b91d697e70188/third_party/WebKit/LayoutTests/TestExpectations

Cc: fhorschig@chromium.org eroman@chromium.org rsleevi@chromium.org
 Issue 801498  has been merged into this issue.
Cc: -fhorschig@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeccc449b06473ee8ada7f13e098abff44b00c71

commit aeccc449b06473ee8ada7f13e098abff44b00c71
Author: Robert Ma <robertma@chromium.org>
Date: Fri Jan 12 19:32:54 2018

Adjust expectations for WebCryptoAPI after the rename is imported

1. Remove a bunch of renamed tests.
2. Move all remaining WebCryptoAPI together and change the bug links.

TBR=fhorschig

Bug: 801357, 709227
Change-Id: If24d8a8dd4adabbbd55967950db2874bf2e9d965
Reviewed-on: https://chromium-review.googlesource.com/864844
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529020}
[modify] https://crrev.com/aeccc449b06473ee8ada7f13e098abff44b00c71/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by danyao@chromium.org, Mar 23 2018

Owner: robertma@chromium.org
Friendly ping from ecosystem-infra sheriff. Robert -- are you the right owner for this bug? Any update?
Status: Started (was: Available)
Thanks for the reminder. Starting to work on this.
Status: Assigned (was: Started)
robertma@, I came here from issue 800570, which itself seems to me like a bigger problem than this issue. Any updates on this and unblocking issue 800570?
Cc: kyleju@chromium.org
Ping!
cc Kyle, sounds relevant to some stuff you've considered recently.
Owner: kyleju@chromium.org
The issue lies at the fact that for js tests, the test name can be different from the file name. It should update text expectations file based off test names instead. 

Sign in to add a comment