Implement surface synchronization on Android |
|||||||||||||||
Issue descriptionSurface sync currently works on Aura, but not Android. This bug tracks work towards enabling it on Android. Known issues so far: - RenderWidgetHostViewAndroid doesn't have a way to produce local surface IDs. - Compositor frame metadata updates don't cause surface updates yet.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baa55ff31deb99cb096471336b7a99fc17f61cba commit baa55ff31deb99cb096471336b7a99fc17f61cba Author: Eric Karl <ericrk@chromium.org> Date: Thu Jan 18 00:46:11 2018 VIZ: Enable some Surface Sync support on Android Generate viz::LocalSurfaceIds in RenderWidgetHostViewAndroid, causing Android RenderWidgets to be sent surface IDs and unblock raster / frame submission. We only generate new Surface IDs for basic resize cases at the moment, and will need additional handling for other cases (omnibox, selection handles, autoresize?). Also works around compositor metadata change issues with by temporarily ignoring these msismatches. This will be fixed with future renderer local surface ID generation work. R=fsamuel Bug: 801350 Change-Id: Ica51b826f19f16e20cb8493522dfd47d12a22b65 Reviewed-on: https://chromium-review.googlesource.com/862712 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#529984} [modify] https://crrev.com/baa55ff31deb99cb096471336b7a99fc17f61cba/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/baa55ff31deb99cb096471336b7a99fc17f61cba/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/baa55ff31deb99cb096471336b7a99fc17f61cba/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/baa55ff31deb99cb096471336b7a99fc17f61cba/content/browser/renderer_host/render_widget_host_view_android.h [modify] https://crrev.com/baa55ff31deb99cb096471336b7a99fc17f61cba/ui/android/delegated_frame_host_android.cc [modify] https://crrev.com/baa55ff31deb99cb096471336b7a99fc17f61cba/ui/android/delegated_frame_host_android.h
,
Feb 8 2018
,
Feb 8 2018
,
Feb 8 2018
,
Feb 8 2018
,
Feb 8 2018
,
Feb 13 2018
,
Feb 13 2018
,
Jun 5 2018
,
Jun 5 2018
,
Jun 5 2018
Over to fsamuel@, who is driving this.
,
Jun 13 2018
,
Jun 18 2018
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6535d45903d9c80f4c783f602b5b2cf628368372 commit 6535d45903d9c80f4c783f602b5b2cf628368372 Author: Fady Samuel <fsamuel@chromium.org> Date: Mon Jun 18 18:45:01 2018 Surface synchronization: Check surface invariants on Android We would like to start a Finch trial for surface sync on Android soon. This CL re-enables Android-specific surface invariants violations checks on Android by removing code in RenderWidgetHostImpl that bypasses those checks. This CL also ensures that when the background transparency changes a new LocalSurfaceId is allocated as this matches the behavior pre-surface-sync. Bug: 672962 , 789259 , 801350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iad2dc6c508770314ea33eb53f05944609f29b0b9 Reviewed-on: https://chromium-review.googlesource.com/1104315 Reviewed-by: Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568091} [modify] https://crrev.com/6535d45903d9c80f4c783f602b5b2cf628368372/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/6535d45903d9c80f4c783f602b5b2cf628368372/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/6535d45903d9c80f4c783f602b5b2cf628368372/content/browser/renderer_host/render_widget_host_impl.h
,
Jun 20 2018
,
Oct 16
There isn't a whole lot of android specific work left to do here so I'm marking this as FIXED. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by ericrk@chromium.org
, Jan 12 2018