New issue
Advanced search Search tips

Issue 801336 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

The "get debug trace" button isn't working

Project Member Reported by nedngu...@google.com, Jan 11 2018

Issue description

This is from https://bugs.chromium.org/p/chromium/issues/detail?id=800448#c14


It's blocking a regression investigation, so I am putting this as P1
 
Cc: dtu@chromium.org
Owner: simonhatch@chromium.org
+dtu

Took a look, Dashboard is still using rietveld to do perf try jobs :( Didn't realize that.


2 options:

Update Dashboard to use gerrit

* This largely involves writing a new service interface (https://gerrit-review.googlesource.com/Documentation/rest-api.html), which will only see use here in the perf try job code until we switch these last bots to Pinpoint.



Switch these bots to Pinpoint

* This has largely just been waiting on documentation to use the new perf try job interface.


Switching to Pinpoint makes more sense, I can get cl's going to switch over the android bots, and some quick documentation.
+1 for switching to pinpoint, the current UX is not good enough to make pinpoint a regression, even without documentation.

Not blocking the switch, how do users get notified when their pinpoint try jobs complete?
Do perf try jobs email when they're done? I don't remember if I've seen it.

Pinpoint does get the email of the user who initiated the job, so we could have it email them afterwards. I'll file a bug about this to discuss.


As for the switch, I'll post the cl's to get started and work on some documentation after that.
I don't recall perf try jobs email when they're done either. Back then, I just check in after a day or so to see if the job is finished :-P
There's definitely nothing in the perf try job code that sends the email. I'm not sure if maybe a mail gets posted to the codereview thread?

SGTM on the switch.

Long-term it would be cool if perf try jobs could also update bugs. I'm not sure how the UI would work, but if you are working on a perf regression bug and you run a try job to get a more detailed trace, ideally the bug would be updated when the trace is available.
I've certainly lost perf tryjobs before, and had to spend a while hunting.
An email would be awesome.
I scanned the recipe code, my email, and the dashboard code and don't see anything that looks like it'd send an email on completion.

You could probably find it in the codereview thread, but not for these dashboard initiated ones since you'd have to find that cl that it made. We'll make Pinpoint notify you.

File https://github.com/catapult-project/catapult/issues/4157 for Pinpoint to send an email.
Status: Fixed (was: Untriaged)
Ok android bots are switched over to Pinpoint, and I was able to kick off a "Request Debug Trace" from dashboard: https://pinpoint-dot-chromeperf.appspot.com/job/1496f398840000

Request for emailing once the job is done is being tracked in catapult:#4157 and any new issues that come up can be tracked separately.

Sign in to add a comment