New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801323 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 711839
issue 754875

Blocking:
issue 806455
issue 809093



Sign in to add a comment

Add Linux/Win Intel HD 630 bots to optional GPU and ANGLE tryservers

Project Member Reported by kbr@chromium.org, Jan 11 2018

Issue description

Intel HD 630 bots were added into the Swarming pool in Issue 754875. They should be added to the optional GPU and ANGLE tryservers at this point.

 

Comment 1 by kbr@chromium.org, Jan 27 2018

Blockedon: 711839
Cc: jmad...@chromium.org
Status: Started (was: Assigned)
CLs in progress. Need to wait on these until the upgrade of the main NVIDIA bots from Win7 to Win10 has settled down.

Chromium side: (must land first)
https://chromium-review.googlesource.com/890108

Infra side:
https://chromium-review.googlesource.com/890113

Comment 2 by kbr@chromium.org, Jan 27 2018

Blocking: 806455
Cc: yunchao...@intel.com
Cc: yizhou.j...@intel.com
Hi Ken,

We've tested angle_deqp_gles2_tests, angle_deqp_gles3_tests and angle_deqp_gles31_tests on Intel HD 630 on both windows and linux platforms. 
The failed tests are listed as the following:

1442 LINUX INTEL : dEQP-GLES2.functional.fbo.render.color_clear.rbo_rgb5_a1_depth_component16_stencil_index8 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.units.2_units.only_cube.6 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.units.2_units.only_cube.7 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.units.2_units.only_2d_array.8 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.units.2_units.only_3d.8 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.units.2_units.mixed.0 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.units.2_units.mixed.8 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.units.2_units.mixed.9 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.units.4_units.only_3d.3 = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.mipmap.2d.min_lod.nearest_nearest = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.mipmap.2d.min_lod.linear_nearest = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.mipmap.3d.min_lod.nearest_nearest = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.texture.mipmap.3d.min_lod.linear_nearest = FAIL
1442 WIN INTEL : dEQP_GLES3.functional.negative_api.texture.bindtexture = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.fbo.color.repeated_clear.sample.tex2d.* = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_4.primitives.lines = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_4.interpolation.lines = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_max.primitives.lines = FAIL
1442 WIN INTEL : dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_max.interpolation.lines = FAIL
1442 LINUX INTEL : dEQP-GLES3.functional.fbo.blit.default_framebuffer* = FAIL
1442 LINUX INTEL : dEQP-GLES3.functional.negative_api.texture.bindtexture = FAIL
1442 LINUX INTEL : dEQP-GLES3.functional.negative_api.shader.program_binary = FAIL
1442 LINUX INTEL OPENGL : dEQP-GLES31.functional.synchronization.in_invocation.image_* = SKIP
1442 LINUX INTEL OPENGL : dEQP-GLES31.functional.synchronization.inter_invocation.image_* = SKIP
1442 LINUX INTEL OPENGL : dEQP-GLES31.functional.compute.basic.copy_image_to_ssbo_small = SKIP
1442 LINUX INTEL OPENGL : dEQP-GLES31.functional.compute.basic.copy_ssbo_to_image_small = SKIP
1442 LINUX INTEL OPENGL : dEQP-GLES31.functional.compute.basic.image_barrier_multiple = SKIP
1442 LINUX INTEL OPENGL : dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.program_binary = FAIL

Can we add those Intel specific failures to angle expectation files firstly, and then set up angle deqp bots for Intel? We will follow up the issues in the near future.

Comment 5 by kbr@chromium.org, Feb 6 2018

Yizhou: yes, certainly. Can you please put up a patch that adds those to ANGLE's dEQP test expectations?

Comment 6 by kbr@chromium.org, Feb 6 2018

Blocking: 809093
Thanks Intel for looking in to those test expectations!
Ken and Jamie, yes, I will commit an patch to suppress these failed test cases. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/5420cb2a3ae0f76a0244cf6b25f897514e545c61

commit 5420cb2a3ae0f76a0244cf6b25f897514e545c61
Author: JiangYizhou <yizhou.jiang@intel.com>
Date: Thu Feb 08 15:21:37 2018

Suppress Intel specific deqp test cases

Test deqp cases on Windows D3D and Linux on Intel HD 630.
Add failed or crashed test cases to expectation files.

BUG= 801323 
BUG=angleproject:2349

Change-Id: I495874f5e1841f6c7ce0f59224ed0da9465546ce
Reviewed-on: https://chromium-review.googlesource.com/900708
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/5420cb2a3ae0f76a0244cf6b25f897514e545c61/src/tests/deqp_support/deqp_gles2_test_expectations.txt
[modify] https://crrev.com/5420cb2a3ae0f76a0244cf6b25f897514e545c61/src/tests/deqp_support/deqp_gles3_test_expectations.txt
[modify] https://crrev.com/5420cb2a3ae0f76a0244cf6b25f897514e545c61/src/tests/deqp_support/deqp_gles31_test_expectations.txt

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/f8cac792274b01901899a4fa6e4d571d218a3e05

commit f8cac792274b01901899a4fa6e4d571d218a3e05
Author: angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Feb 08 16:10:44 2018

Roll skia/third_party/externals/angle2/ 0e65454df..5420cb2a3 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/0e65454df2b6..5420cb2a3ae0

$ git log 0e65454df..5420cb2a3 --date=short --no-merges --format='%ad %ae %s'
2018-01-24 yizhou.jiang Suppress Intel specific deqp test cases

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 801323 


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=bsalomon@google.com

Change-Id: I49dfe0cbab454acfe88674ec641cc7c4807aef5b
Reviewed-on: https://skia-review.googlesource.com/105588
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>

[modify] https://crrev.com/f8cac792274b01901899a4fa6e4d571d218a3e05/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ed324938e0f45748650b1ef60442152168f324c

commit 0ed324938e0f45748650b1ef60442152168f324c
Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Feb 08 18:04:30 2018

Roll src/third_party/skia/ 76546506d..d4746984e (7 commits)

https://skia.googlesource.com/skia.git/+log/76546506d195..d4746984e51e

$ git log 76546506d..d4746984e --date=short --no-merges --format='%ad %ae %s'
2018-02-07 reed ensure that what is valid for a surface is also valid for an image
2018-02-08 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 15193d5a1..d1d9bfad5 (1 commit)
2018-02-08 brianosman Fix typo in comment (inherited from ICC spec)
2018-02-08 robertphillips Switch MDB GrContextOptions over to Enable style
2018-02-08 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 0e65454df..5420cb2a3 (1 commit)
2018-02-08 brianosman Detect MSVC 2017 Community in GN
2018-02-08 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 645741555..15193d5a1 (1 commit)

Created with:
  roll-dep src/third_party/skia
BUG= 801323 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bsalomon@chromium.org

Change-Id: I63136006a490b95d81d2bcd20115532704feb911
Reviewed-on: https://chromium-review.googlesource.com/909088
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#535437}
[modify] https://crrev.com/0ed324938e0f45748650b1ef60442152168f324c/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1e495b0f39636c19bdad620152be1532c9d923a

commit c1e495b0f39636c19bdad620152be1532c9d923a
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Feb 08 18:05:17 2018

Roll src/third_party/angle/ 0e65454df..5420cb2a3 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/0e65454df2b6..5420cb2a3ae0

$ git log 0e65454df..5420cb2a3 --date=short --no-merges --format='%ad %ae %s'
2018-01-24 yizhou.jiang Suppress Intel specific deqp test cases

Created with:
  roll-dep src/third_party/angle
BUG= 801323 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Icda2703fdb047394eb6c6edc1dc2f4ee864a8e09
Reviewed-on: https://chromium-review.googlesource.com/908571
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#535438}
[modify] https://crrev.com/c1e495b0f39636c19bdad620152be1532c9d923a/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41721322bace5342826400751ab7784f1ded443a

commit 41721322bace5342826400751ab7784f1ded443a
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Feb 08 18:45:00 2018

Add Optional Win10 and Linux Intel HD 630 trybots.

These will be run as part of win_optional_gpu_tests_rel and
linux_optional_gpu_tests_rel, running tests such as the WebGL 2.0
conformance suite.

TBR=jmadill@chromium.org

Bug:  801323 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia2996ef724422ff1a3e04f307fdc6716c21adaae
Reviewed-on: https://chromium-review.googlesource.com/890108
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535459}
[modify] https://crrev.com/41721322bace5342826400751ab7784f1ded443a/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/41721322bace5342826400751ab7784f1ded443a/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8a1d0107cde1a6456de57a8cb9765cde4f4c293f

commit 8a1d0107cde1a6456de57a8cb9765cde4f4c293f
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Feb 08 20:06:09 2018

Start running tryjobs through Intel HD 630 bots.

This adds the Intel HD 630 bots to these trybots:

  win_optional_gpu_tests_rel
  linux_optional_gpu_tests_rel
  win_angle_rel_ng
  linux_angle_rel_ng

TBR=jmadill@chromium.org

Bug:  801323 
Change-Id: I99bfa0e078e93201a318a98d6ee6c9e78c8c8960
Reviewed-on: https://chromium-review.googlesource.com/890113
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/8a1d0107cde1a6456de57a8cb9765cde4f4c293f/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/8a1d0107cde1a6456de57a8cb9765cde4f4c293f/scripts/slave/recipe_modules/chromium_tests/trybots.py

Comment 15 by kbr@chromium.org, Feb 9 2018

Status: Fixed (was: Started)
Jobs on https://ci.chromium.org/buildbot/tryserver.chromium.win/win_optional_gpu_tests_rel/ are running tasks on the Intel HD 630 bots.

Working well on ANGLE's tryservers too:

https://ci.chromium.org/buildbot/tryserver.chromium.angle/win_angle_rel_ng/9074

Thanks a lot Ken!

Sign in to add a comment