New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801310 link

Starred by 1 user
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Apr 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Aanlyzer - Reset heuristic_analysis_status

Project Member Reported by lijeffrey@chromium.org, Jan 11 2018 
the field heuristic_analysis_status was recently introduced to MasterFlakeAnalysis. Update reset() method to set it to analysis_status.PENDING when called.

This should be done at the same time that the pipelines are switched to use the new merged pipeline, but not before as it'll leave rerun analyses with heuristic_analysis_results as PENDING which is incorrect.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3c2a02686b49fee6a56559ba3bfc763756a2ad23

commit 3c2a02686b49fee6a56559ba3bfc763756a2ad23
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Apr 26 00:57:48 2018

[Findit] Flake Analyzer - Hooking up heuristic analysis to new pipelines

1. Run heuristic results as soon as the builds adjacent to a requested
   commit position are also adjacent to one another.
2. Always check for heuristic analysis first for the next commit positition
   to run before falling back to the one suggested by the lookback algorithm
   depending on pass rates.

Bug:  798228 ,  801310 
Change-Id: I5572d1fed0c9111d49946c4c8cce74d3f618d5b4
Reviewed-on: https://chromium-review.googlesource.com/1000105
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/3c2a02686b49fee6a56559ba3bfc763756a2ad23/appengine/findit/services/flake_failure/heuristic_analysis.py
[modify] https://crrev.com/3c2a02686b49fee6a56559ba3bfc763756a2ad23/appengine/findit/pipelines/flake_failure/test/next_commit_position_pipeline_test.py
[modify] https://crrev.com/3c2a02686b49fee6a56559ba3bfc763756a2ad23/appengine/findit/pipelines/flake_failure/next_commit_position_pipeline.py
[modify] https://crrev.com/3c2a02686b49fee6a56559ba3bfc763756a2ad23/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/3c2a02686b49fee6a56559ba3bfc763756a2ad23/appengine/findit/services/flake_failure/next_commit_position_utils.py
[modify] https://crrev.com/3c2a02686b49fee6a56559ba3bfc763756a2ad23/appengine/findit/services/flake_failure/test/heuristic_analysis_test.py
[modify] https://crrev.com/3c2a02686b49fee6a56559ba3bfc763756a2ad23/appengine/findit/services/flake_failure/test/next_commit_position_utils_test.py

Comment 2 by lijeffrey@chromium.org, Apr 26 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment