New issue
Advanced search Search tips

Issue 801299 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 803541



Sign in to add a comment

int32 overflow in WebApk.LaunchInterval

Project Member Reported by pkotw...@chromium.org, Jan 11 2018

Issue description

int32 overflow in WebApk.LaunchInterval

 

Comment 1 by wychen@chromium.org, Jan 18 2018

Blocking: 803541
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96b0d1ceabb26286593bde294b861084b28062be

commit 96b0d1ceabb26286593bde294b861084b28062be
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Wed Jan 24 18:01:42 2018

Fix overflow in WebApk.LaunchInterval

Use minutes instead of milliseconds to remove int32 overflow.

BUG= 801299 

Change-Id: Ifadd974d7e574d43b487c7754a689c45afcccc69
Reviewed-on: https://chromium-review.googlesource.com/861825
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531603}
[modify] https://crrev.com/96b0d1ceabb26286593bde294b861084b28062be/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
[modify] https://crrev.com/96b0d1ceabb26286593bde294b861084b28062be/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java
[modify] https://crrev.com/96b0d1ceabb26286593bde294b861084b28062be/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment