New issue
Advanced search Search tips

Issue 801280 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 800984



Sign in to add a comment

app-benchmarks/glmark2 fails to build with llvm-next

Project Member Reported by rahulchaudhry@chromium.org, Jan 11 2018

Issue description

This happens when testing the next version of llvm: https://bugs.chromium.org/p/chromium/issues/detail?id=800984

For chell (amd64), app-benchmarks/glmark2 build fails with new errors.

The new errors are from [-Wreserved-user-defined-literal] and [-Wdeprecated-declarations].

Here's an example of [-Wreserved-user-defined-literal]:
../src/options.cpp:127:48: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
           "                         Default: "GLMARK_DATA_PATH"\n"
                                               ^

And here's an example of [-Wdeprecated-declarations]:
../src/image-reader.cpp:123:16: error: 'auto_ptr<std::basic_istream<char> >' is deprecated [-Werror,-Wdeprecated-declarations]
    const std::auto_ptr<std::istream> is_ptr(Util::get_resource(filename));
               ^
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/4.9.x/include/g++-v4/backward/auto_ptr.h:281:7: note: 'auto_ptr<std::basic_istream<char> >' has been explicitly marked deprecated here
    } _GLIBCXX_DEPRECATED;
      ^
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/4.9.x/include/g++-v4/x86_64-pc-linux-gnu/bits/c++config.h:82:46: note: expanded from macro '_GLIBCXX_DEPRECATED'
# define _GLIBCXX_DEPRECATED __attribute__ ((__deprecated__)) 
                                             ^

 
Summary: app-benchmarks/glmark2 fails to build with llvm-next (was: app-benchmarks/glmark2 fails to build llvm-next)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/faf0e5d1bfef2d5bbaab1eb8e1553639f4fb34d6

commit faf0e5d1bfef2d5bbaab1eb8e1553639f4fb34d6
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jan 19 08:29:48 2018

app-benchmarks/glmark2: fix build issue with llvm-next.

Fix a build error due to [-Wreserved-user-defined-literal].
C++11 requires a space between literal and identifier.

BUG= chromium:801280 
TEST='src/options.cpp' compiles with llvm-next.

Change-Id: I8abfae4efcd70e96358d28871190ac89ad9a84a8
Reviewed-on: https://chromium-review.googlesource.com/875147
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/faf0e5d1bfef2d5bbaab1eb8e1553639f4fb34d6/app-benchmarks/glmark2/files/0002-Add-data-path-command-line-option.patch
[rename] https://crrev.com/faf0e5d1bfef2d5bbaab1eb8e1553639f4fb34d6/app-benchmarks/glmark2/glmark2-285-r13.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ce8271f6be50d3b141d206d45a97c6c4c4fe1942

commit ce8271f6be50d3b141d206d45a97c6c4c4fe1942
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Sat Jan 20 04:35:39 2018

app-benchmarks/glmark2: fix build issue with llvm-next.

Backport upstream patch
https://github.com/glmark2/glmark2/commit/3137e5c184581c9a69c687ecf46ba08f02c4117b
to remove uses of deprecated std::auto_ptr.

We need to pass -std=gnu++11 to be able to use std::unique_ptr.

BUG= chromium:801280 
TEST='emerge-chell app-benchmarks/glmark2' works with llvm-next.

Change-Id: I743f8eb6bffbdd3a10ff6f6de6ec3b80e5b44db5
Reviewed-on: https://chromium-review.googlesource.com/875203
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/ce8271f6be50d3b141d206d45a97c6c4c4fe1942/app-benchmarks/glmark2/glmark2-285-r14.ebuild
[add] https://crrev.com/ce8271f6be50d3b141d206d45a97c6c4c4fe1942/app-benchmarks/glmark2/files/deprecated-auto-ptr.patch
[modify] https://crrev.com/ce8271f6be50d3b141d206d45a97c6c4c4fe1942/app-benchmarks/glmark2/glmark2-285.ebuild

Status: Fixed (was: Untriaged)

Sign in to add a comment